Received-SPF: pass (google.com: domain of linux-kernel+bounces-203923-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Message-ID: <0ae387c1-31b2-4e87-aa7d-f98e3c90e985@arinc9.com>
Date: Thu, 6 Jun 2024 12:01:03 +0300
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] arm64: dts: mt7622: fix switch probe on bananapi-r64
To: Thorsten Leemhuis <regressions@leemhuis.info>,
 Linux regressions mailing list <regressions@lists.linux.dev>,
 Frank Wunderlich <linux@fw-web.de>, Paolo Abeni <pabeni@redhat.com>
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
 linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org,
 Daniel Golle <daniel@makrotopia.org>,
 AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>,
 Krzysztof Kozlowski <krzk+dt@kernel.org>, Conor Dooley
 <conor+dt@kernel.org>, Matthias Brugger <matthias.bgg@gmail.com>,
 frank-w@public-files.de, Rob Herring <robh@kernel.org>
References: <20240516204847.171029-1-linux@fw-web.de>
 <a29dd7d1-40a8-4c88-99aa-651a3305b640@arinc9.com>
 <5AEE5668-0C8E-4EE4-A398-66CB99DF5650@public-files.de>
 <43aacd9d-b851-4100-8ccc-878ac6ae10f8@leemhuis.info>
 <698cf562-1ca9-4aa3-be7e-a1474b612c5b@leemhuis.info>
 <0cba095c-3d55-416a-a7ad-b359129731cf@arinc9.com>
 <714da201-654b-4183-8e5e-8ff0b64fe621@leemhuis.info>
Content-Language: en-US
From: =?UTF-8?B?QXLEsW7DpyDDnE5BTA==?= <arinc.unal@arinc9.com>
In-Reply-To: <714da201-654b-4183-8e5e-8ff0b64fe621@leemhuis.info>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

On 06/06/2024 11.26, Thorsten Leemhuis wrote:
> On 31.05.24 08:10, Arınç ÜNAL wrote:
>> I had already submitted a patch series that would've prevented this
>> issue back in 14 March 2024 [1]. I've asked numerous times for the patch
>> series to be applied [2][3][4][5].
>>> Eventually Daniel asked for some changes [6]. But I won't have time to do
>> that anytime soon and I think the patch series is good enough to be applied
>> as is.
> 
> Then I guess we need some other way to resolve this in mainline to unfix

I don't believe we need another way to resolve it. I've already told that
the patch series is good enough to be applied as is and I don't see any
responses with reasons against this here.

> Frank's device. The two obvious options are afaics:
> 
> * revert the culprit (868ff5f4944aa9 ("net: dsa: mt7530-mdio: read PHY
> address of switch from device tree")) and reapply it in a later cycle

Sorry, no. There's nothing wrong with that patch. The actual cause of this
issue is the patch that introduced this device tree source file with the
wrong PHY address.

> * apply Frank's patch (or an improved one) in this thread (and if needed
> revert it when some better changes emerge.
> 
> Arınç ÜNAL, could you please comment on that and ideally handle the
> necessary tasks, as it's your patch that causes the regression.

I don't see any necessary tasks for me to handle. AngeloGioacchino Del
Regno whom is the only person I know that maintains these device tree
source files can simply apply the patch series that I have already
submitted and we can all move on. I haven't heard from them whilst the
patch had been waiting since March. So I'm not sure who's going to apply
this patch, and to which tree.

Arınç