Received-SPF: pass (google.com: domain of linux-kernel+bounces-204018-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Message-ID: <cee5e4ee-3d67-4eba-a790-c0c016cee937@leemhuis.info>
Date: Thu, 6 Jun 2024 11:34:38 +0200
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] arm64: dts: mt7622: fix switch probe on bananapi-r64
To: =?UTF-8?B?QXLEsW7DpyDDnE5BTA==?= <arinc.unal@arinc9.com>,
 Paolo Abeni <pabeni@redhat.com>,
 AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
 linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org,
 Daniel Golle <daniel@makrotopia.org>,
 Krzysztof Kozlowski <krzk+dt@kernel.org>, Conor Dooley
 <conor+dt@kernel.org>, Matthias Brugger <matthias.bgg@gmail.com>,
 frank-w@public-files.de, Rob Herring <robh@kernel.org>,
 Linux regressions mailing list <regressions@lists.linux.dev>,
 Frank Wunderlich <linux@fw-web.de>
References: <20240516204847.171029-1-linux@fw-web.de>
 <a29dd7d1-40a8-4c88-99aa-651a3305b640@arinc9.com>
 <5AEE5668-0C8E-4EE4-A398-66CB99DF5650@public-files.de>
 <43aacd9d-b851-4100-8ccc-878ac6ae10f8@leemhuis.info>
 <698cf562-1ca9-4aa3-be7e-a1474b612c5b@leemhuis.info>
 <0cba095c-3d55-416a-a7ad-b359129731cf@arinc9.com>
 <714da201-654b-4183-8e5e-8ff0b64fe621@leemhuis.info>
 <0ae387c1-31b2-4e87-aa7d-f98e3c90e985@arinc9.com>
From: Thorsten Leemhuis <regressions@leemhuis.info>
Content-Language: en-US, de-DE
In-Reply-To: <0ae387c1-31b2-4e87-aa7d-f98e3c90e985@arinc9.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

On 06.06.24 11:01, Arınç ÜNAL wrote:
> On 06/06/2024 11.26, Thorsten Leemhuis wrote:
>> On 31.05.24 08:10, Arınç ÜNAL wrote:
>>> I had already submitted a patch series that would've prevented this
>>> issue back in 14 March 2024 [1]. I've asked numerous times for the patch
>>> series to be applied [2][3][4][5].
>>>> Eventually Daniel asked for some changes [6]. But I won't have time
>>>> to do
>>> that anytime soon and I think the patch series is good enough to be
>>> applied
>>> as is.
>>
>> Then I guess we need some other way to resolve this in mainline to unfix
> 
> I don't believe we need another way to resolve it. I've already told that
> the patch series is good enough to be applied as is and I don't see any
> responses with reasons against this here.
> 
>> Frank's device. The two obvious options are afaics:
>>
>> * revert the culprit (868ff5f4944aa9 ("net: dsa: mt7530-mdio: read PHY
>> address of switch from device tree")) and reapply it in a later cycle
> 
> Sorry, no. There's nothing wrong with that patch. The actual cause of this
> issue is the patch that introduced this device tree source file with the
> wrong PHY address.

Was that also merged for 6.10? Because if not, then what matters here
afaics is what patch exposed the problem. Of course ideally we wound fix
that problem -- but if nobody takes care of that any time soon it might
come down to a revert of the patch that exposed the problem. At least
that how Linus handles these things afaics.

>> * apply Frank's patch (or an improved one) in this thread (and if needed
>> revert it when some better changes emerge.
>>
>> Arınç ÜNAL, could you please comment on that and ideally handle the
>> necessary tasks, as it's your patch that causes the regression.
> 
> I don't see any necessary tasks for me to handle. AngeloGioacchino Del
> Regno whom is the only person I know that maintains these device tree
> source files can simply apply the patch series that I have already
> submitted and we can all move on. I haven't heard from them whilst the
> patch had been waiting since March. So I'm not sure who's going to apply
> this patch, and to which tree.

AngeloGioacchino Del Regno, if you have a minute, could you please
comment if merging those changes for 6.10 is an option?

Ciao, Thorsten