Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758041AbYBET6T (ORCPT ); Tue, 5 Feb 2008 14:58:19 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753564AbYBET6A (ORCPT ); Tue, 5 Feb 2008 14:58:00 -0500 Received: from sovereign.computergmbh.de ([85.214.69.204]:33675 "EHLO sovereign.computergmbh.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752805AbYBET57 (ORCPT ); Tue, 5 Feb 2008 14:57:59 -0500 Date: Tue, 5 Feb 2008 20:57:58 +0100 (CET) From: Jan Engelhardt To: Andi Kleen cc: Glenn Griffin , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Add IPv6 support to TCP SYN cookies In-Reply-To: <20080205155558.GA23145@one.firstfloor.org> Message-ID: References: <47a79d64.16538c0a.5b6a.ffffb0fe@mx.google.com> <20080205155558.GA23145@one.firstfloor.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1135 Lines: 23 On Feb 5 2008 16:55, Andi Kleen wrote: >On Mon, Feb 04, 2008 at 03:01:01PM -0800, Glenn Griffin wrote: >> Add IPv6 support to TCP SYN cookies. This is written and tested against >> 2.6.24, and applies cleanly to linus' current HEAD (d2fc0b). Unfortunately >> linus' HEAD breaks my sky2 card at the moment, so I'm unable to test against >> that. I see no reason why it would be affected though. Comments/suggestions >> are welcome. > >Syncookies are discouraged these days. They disable too many >valuable TCP features (window scaling, SACK) and even without them >the kernel is usually strong enough to defend against syn floods >and systems have much more memory than they used to be. > >So I don't think it makes much sense to add more code to it, sorry. Distributions should then probably deactivate it by default. SUSE 10.3 for example still has it enabled on default installs. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/