Received-SPF: pass (google.com: domain of linux-kernel+bounces-204063-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID: <fc03506c-210f-4d79-9a99-8bc9b0587d25@redhat.com>
Date: Thu, 6 Jun 2024 11:53:42 +0200
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v1 0/2] asus wmi and hid: use HID LED for brightness
To: Benjamin Tissoires <bentiss@kernel.org>
Cc: "Luke D. Jones" <luke@ljones.dev>, Jiri Kosina <jikos@kernel.org>,
 ilpo.jarvinen@linux.intel.com, corentin.chary@gmail.com,
 platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org,
 linux-input@vger.kernel.org
References: <20240529012827.146005-1-luke@ljones.dev>
 <b0d8eebc-5abb-4ec0-898c-af7eedc730d9@redhat.com>
 <dflqwdl4fo3wv4zjj4jl6sbot6cotscksgpyrbiu3j77lyrwal@s6nomonx4gv6>
Content-Language: en-US, nl
From: Hans de Goede <hdegoede@redhat.com>
In-Reply-To: <dflqwdl4fo3wv4zjj4jl6sbot6cotscksgpyrbiu3j77lyrwal@s6nomonx4gv6>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit

Hi Benjamin,

On 6/6/24 10:49 AM, Benjamin Tissoires wrote:
> On May 29 2024, Hans de Goede wrote:
>> Hi all,
>>
>> On 5/29/24 3:28 AM, Luke D. Jones wrote:
>>> Changelog:
>>> - v1
>>>   - Split the patch in two
>>>   - Move function body to asus-wmi and export
>>>   - Use array of names and for loops
>>>
>>> History:
>>> - https://lore.kernel.org/linux-input/20240528013959.14661-1-luke@ljones.dev/T/#u
>>>
>>> Luke D. Jones (2):
>>>   hid-asus: use hid for brightness control on keyboard
>>>   hid-asus: change the report_id used for HID LED control
>>>
>>>  drivers/hid/hid-asus.c                     | 32 +++++++++++++++++++-
>>>  drivers/platform/x86/asus-wmi.c            | 35 +++++++++++++++++++++-
>>>  include/linux/platform_data/x86/asus-wmi.h | 10 +++++++
>>>  3 files changed, 75 insertions(+), 2 deletions(-)
>>
>> Jiri, Benjamin since the first patch now also touches pdx86 files
>> we need to coordinate merging this.
>>
>> There also is a long list of patches pending for
>> drivers/platform/x86/asus-wmi.c
>>
>> So I would prefer to take this series (both patches) upstream through
>> the pdx86 tree to avoid conflicts.
>>
>> May we have an ack from one of you for merging this through pdx86/for-next ?
> 
> Sure:
> Acked-by: Benjamin Tissoires <bentiss@kernel.org>

Thank you for the ack.

> But I haven't seen the v2. Are you sure you want to take this series as
> it is?

No I plan to wait for v2, I just thought it would be good to have
an ack to merge this through the pdx86 tree beforehand.

Regards,

Hans