Received-SPF: pass (google.com: domain of linux-kernel+bounces-204072-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
From: Laura Nao <laura.nao@collabora.com>
To: laura.nao@collabora.com
Cc: kernel@collabora.com,
	linux-kernel@vger.kernel.org,
	linux-kselftest@vger.kernel.org,
	shuah@kernel.org
Subject: Re: [PATCH 0/2] Modify the watchdog selftest for execution with
Date: Thu,  6 Jun 2024 11:57:14 +0200
Message-Id: <20240606095714.397658-1-laura.nao@collabora.com>
In-Reply-To: <20240506111359.224579-1-laura.nao@collabora.com>
References: <20240506111359.224579-1-laura.nao@collabora.com>
Precedence: bulk
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Hi Shuah,

On 5/6/24 13:13, Laura Nao wrote:
> The watchdog selftest script supports various parameters for testing
> different IOCTLs. The watchdog ping functionality is validated by
> starting
> a loop where the watchdog device is periodically pet, which can only
> be
> stopped by the user interrupting the script.
> 
> This results in a timeout when running this test using the kselftest
> runner
> with no non-oneshot parameters (or no parameters at all):
> 
>   TAP version 13
>   1..1
>   # timeout set to 45
>   # selftests: watchdog: watchdog-test
>   # Watchdog Ticking Away!
>   # .............................................#
>   not ok 1 selftests: watchdog: watchdog-test # TIMEOUT 45 seconds
> 
> To address this issue, the first patch in this series limits the loop
> to 5
> iterations by default and adds support for a new '-c' option to
> customize
> the number of pings as required.
> 
> The second patch conforms the test output to the KTAP format.
> 

Gentle ping - any thoughts on this series? It would simplify running the
watchdog kselftest in CI environments by leveraging the runner.

Thanks!

Laura