Received-SPF: pass (google.com: domain of linux-kernel+bounces-204079-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Thu, 6 Jun 2024 13:04:39 +0300
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Chia-I Wu <olvaffe@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Dave Jiang <dave.jiang@intel.com>,
	Alison Schofield <alison.schofield@intel.com>,
	Baoquan He <bhe@redhat.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5] resource: add a simple test for walk_iomem_res_desc()
Message-ID: <ZmGJt1I4Glvq_Myz@smile.fi.intel.com>
References: <20240606004002.3280960-1-olvaffe@gmail.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240606004002.3280960-1-olvaffe@gmail.com>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo

On Wed, Jun 05, 2024 at 05:39:48PM -0700, Chia-I Wu wrote:
> This mainly tests that find_next_iomem_res() does not miss resources.

Read Submitting Patches documentation on imperative mood and modify the commit
message to follow.

...

> +	/* build the resource tree under the test root:
> +	 *
> +	 *   0x0000-0x0fff: res[0], a match
> +	 *   0x1000-0x1fff: res[1], a non-match
> +	 *   0x2000-0x2fff: a hole
> +	 *   0x3000-0x3fff: res[2], a non-match
> +	 *     0x3800-0x3bff: res[3], a match
> +	 *   0x4000-0x4fff: res[4], a match
> +	 */

/*
 * This is good, but multi-line comment
 * style is broken along with English grammar, i.e.
 * do not forget that sentences are started with
 * a capital letter.
 */

...

Please, do not send a new version this week. Take your time.

-- 
With Best Regards,
Andy Shevchenko