Received-SPF: pass (google.com: domain of linux-kernel+bounces-204086-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
From: Heiko =?ISO-8859-1?Q?St=FCbner?= <heiko@sntech.de>
To: Linus Walleij <linus.walleij@linaro.org>, Huang-Huang Bao <i@eh5.me>
Cc: linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
 linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
 Huang-Huang Bao <i@eh5.me>
Subject:
 Re: [PATCH 2/3] pinctrl: rockchip: use dedicated pinctrl type for RK3328
Date: Thu, 06 Jun 2024 12:11:15 +0200
Message-ID: <4429508.MSiuQNM8U4@diego>
In-Reply-To: <2182307.KiezcSG77Q@diego>
References:
 <20240606060435.765716-1-i@eh5.me> <20240606060435.765716-3-i@mail.eh5.me>
 <2182307.KiezcSG77Q@diego>
Precedence: bulk
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="iso-8859-1"

Am Donnerstag, 6. Juni 2024, 11:43:56 CEST schrieb Heiko St=FCbner:
> Am Donnerstag, 6. Juni 2024, 08:04:34 CEST schrieb Huang-Huang Bao:
> > rk3328_pin_ctrl uses type of RK3288 which has a hack in
> > rockchip_pinctrl_suspend and rockchip_pinctrl_resume to restore GPIO6-C6
> > at assume, the hack is not applicable to RK3328 as GPIO6 is not even
> > exist in it. So use a dedicated pinctrl type to skip this hack.
> >=20
> > Signed-off-by: Huang-Huang Bao <i@eh5.me>
>=20
> Reviewed-by: Heiko Stuebner <heiko@sntech.de>

I think this actually also warrants a Fixes-tag, because as you said, the
suspend handling for the rk3288 will change GRF registers it should not
touch on the rk3328.

=46ixes: 3818e4a7678e ("pinctrl: rockchip: Add rk3328 pinctrl support")