Received: by 2002:ab2:6309:0:b0:1fb:d597:ff75 with SMTP id s9csp281017lqt; Thu, 6 Jun 2024 03:31:16 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCUurAyXmM98S/9AWmCBf/qDxNFaeOAIf22bFOqG7odMCelkeulkJC0etNZm3zr4dCS4D5/p+xpG0MoLB5BR5zM173Wni7axQ6zkRtki8A== X-Google-Smtp-Source: AGHT+IE39Sx8ah+qp/TN6o4n3gCWOkZSoLtC86UDSAaNo3ZQ3fzdh+MXS1rcPxjSEbG4Sn/eOJh2 X-Received: by 2002:a05:6a20:12c4:b0:1b2:b4ac:1991 with SMTP id adf61e73a8af0-1b2b747e846mr6020266637.35.1717669875952; Thu, 06 Jun 2024 03:31:15 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1717669875; cv=pass; d=google.com; s=arc-20160816; b=cElKFPk03BclpzdU1J2f4aMOLRjvuWxx2UqF6qb9oZSq5x5EkiQG2g3MC53PLxNI/6 a+zEoA7c3mw9H+78t6Iv1e4O+7tMKsSX7Wnja8nPlQ8qu7u5aNRMbIqzsXmqtCWSSZas 9s1z4F3tXsURKKd6/yzuGkG/6wQQAar13QLcCzX1xMIcmwaAEd1vMpPMlsOgbV4dUxfG 5TuwgtPd5FpGtvm03D2unlOdvfdwOo/b9PgCJr/QGCNoZiFCQSznkNKLi/Jt28pmODqN 9rNSNbf/Ymnlw9PYpdPz2IdwZTFNH/TwTTxDssx9GJKITykkQuEKBPTP8JfTJ7AqZDyM gwOA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:message-id:date:subject:cc:to :from:dkim-signature; bh=kYLhpAMZR61cty6AvZweA/m3vDLXR4UUWCD1h1qb/EA=; fh=3gbPhre1OB9gPaTtmCq689W9XI462kLAqPsb9Z8n0A8=; b=g5p2sP2VWNa0a/fJ8e5+gnerQs5YYqnkOsvq+GqA/y1DpPaTCU/anX40wN49aglrlb R504FEjpjxXH7+zDj9cHV6+1Pxn5ErktsouYFrCgkkTDBXra3UUBlDthwg2LipV2LaqQ SmukLbZ5Sd6V5xrviE2mEz/oXXx/X8/OnKY+5w7eF6YmPBrFQqtpSqIIKmgqNjtTxWhC jKt1X8ui8lfFI4UCwGN7KtqdRFedEnokAtqmeMgm1Qi57HFu6hM3bXzNJdhVwKmQq0t8 UlYKqMbYpw8wKxSjKEw/ngWGhjC6cKd6hnZL5jm4mEJyfBc8qrKB7wAp1jTtf7klRZ7w S41g==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=l27xivrE; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-204059-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-204059-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [147.75.48.161]) by mx.google.com with ESMTPS id 41be03b00d2f7-6de29cb9be3si894503a12.770.2024.06.06.03.31.15 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 06 Jun 2024 03:31:15 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-204059-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=l27xivrE; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-204059-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-204059-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 65109B2D3EC for ; Thu, 6 Jun 2024 09:52:48 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 4DA5E17E8F2; Thu, 6 Jun 2024 09:52:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="l27xivrE" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7CC0E17DE1C for ; Thu, 6 Jun 2024 09:52:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717667545; cv=none; b=bMkEkBkCb0YwwYvmQtT0y/9mkrzaCYo6K8LDFQWkWOEM9Tjxl89E/MFtBpCogabccBrr9yzn1IazzClcUeFkHpkI4ULSyZ9SsAiEJcPEaxTk7nsRZXVHmc63mWOTn9Gt17SWkIb4E+MqDT0S3Kq0qO+tXHp0wSnnic61zxlX47Y= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717667545; c=relaxed/simple; bh=vpCESMH7oAFny3mUZ0bjEmQ2oG/eItdcKHHoG8MCYVk=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=lZhkukLr4zMwp8n7s+lZndkhHbNp2uVeKxbZUvro3updMSno1t8eTMsoV5c0D1jrNvIrrVmgwyVxdH8aISC3DBug1x6w1trbW8wVJveT5H+zqfS9cI7+OHQ1DuY9Pic0rMhVZ64YiEKVBXRp3tsTCu9omGfgjDyessNw1XhUZ3w= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=l27xivrE; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id BCEDEC32782; Thu, 6 Jun 2024 09:52:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1717667545; bh=vpCESMH7oAFny3mUZ0bjEmQ2oG/eItdcKHHoG8MCYVk=; h=From:To:Cc:Subject:Date:From; b=l27xivrEPzpxVDgprs68EK4yUasJGbA3yLIIjSfpYXxi4LKXBtuHRk3WlVi8bFqBl Fj1gX8Xt0d4KAY+1AYWagZ7etA/10ur6WFFgl6vdJiXexEemB1+im/tVI/QIrgzF3X f1G/cARZ64LKcMhxzm8o0LiSm2H2CPd5p5PDCMp1zhJHceulunVb6iNrOpuuS2HQQY G9LEs8KrwtxDcnWjuFxQ+OSkUTsv+Dsq2SIuLe8KqVaPL9Askqvx7yP//gUluOuOiV uCwEk1RMO0OlCve3ITcXAab+usskbJA5oTG4IDZvoyRUN9AB0KhrafemKm2h9gNFmJ ZK7RYlkSTtCsg== From: Chao Yu To: jaegeuk@kernel.org Cc: linux-f2fs-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org, Chao Yu , Daeho Jeong Subject: [PATCH 1/2] f2fs: fix to add missing sb_{start,end}_intwrite() for ckpt thread Date: Thu, 6 Jun 2024 17:52:12 +0800 Message-Id: <20240606095213.4087668-1-chao@kernel.org> X-Mailer: git-send-email 2.40.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit After commit 261eeb9c1585 ("f2fs: introduce checkpoint_merge mount option"), checkpoint can be triggered in background thread, it missed to cover f2fs inner checkpoint operation w/ sb_{start,end}_intwrite(), fix it. Fixes: 261eeb9c1585 ("f2fs: introduce checkpoint_merge mount option") Cc: Daeho Jeong Signed-off-by: Chao Yu --- fs/f2fs/checkpoint.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/fs/f2fs/checkpoint.c b/fs/f2fs/checkpoint.c index 55d444bec5c0..66eaad591b60 100644 --- a/fs/f2fs/checkpoint.c +++ b/fs/f2fs/checkpoint.c @@ -1828,8 +1828,11 @@ static int issue_checkpoint_thread(void *data) if (kthread_should_stop()) return 0; - if (!llist_empty(&cprc->issue_list)) + if (!llist_empty(&cprc->issue_list)) { + sb_start_intwrite(sbi->sb); __checkpoint_and_complete_reqs(sbi); + sb_end_intwrite(sbi->sb); + } wait_event_interruptible(*q, kthread_should_stop() || !llist_empty(&cprc->issue_list)); -- 2.40.1