Received: by 2002:ab2:6309:0:b0:1fb:d597:ff75 with SMTP id s9csp281629lqt; Thu, 6 Jun 2024 03:32:43 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCVeF1fPlGSwDk7jn/JXb9dYlrbVa5lHrGdZv4iY46D97xXECECtQF6IBKf8SOYrjeXSFzS7mx2zOrh8JxvXBACn0KwE/7wXRBm4pF9htw== X-Google-Smtp-Source: AGHT+IFSzofII36BkAXMoy1AFob44SILFPIDDXOIdexfBDXCxri3GJ8ZH2cgzcYHPAg1YAx0mEoB X-Received: by 2002:a17:906:4694:b0:a68:44ed:613d with SMTP id a640c23a62f3a-a699f776a1emr342303266b.14.1717669963249; Thu, 06 Jun 2024 03:32:43 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1717669961; cv=pass; d=google.com; s=arc-20160816; b=Ure9G5uJLMmjPmIQAR3Iiq56JhgFNsrdn/SZFIlzp72K2b/d4VuppLKVPRZSSCn01v L9cOj58iOlak0LzFx6N1SIj1OaWLd8h31+dkJqztSTqKKrR/KOgfoeNqPq8Hs9JCjo+D L84RoOlry/eyx0NC9se0h1sukroOptP820/neKeZKihk82H8CKjAESyYxqQCZHqH7Etg ItjH2yUZ0fygh+DAYt0uTLlrkiduT6zHQZKcYmf1ysAWvTdAv0rHWf6r8Um/Rki5wx4+ uk70FhOVbFELVmHNaVtFbF0ujjD5Wv1b6zpfslikmPVs7bLbgQqT6dxbLfqiwjs6j/zq AdNg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:list-unsubscribe:list-subscribe:list-id:precedence :user-agent:content-transfer-encoding:autocrypt:references :in-reply-to:date:cc:to:from:subject:message-id:dkim-signature; bh=okcCBnpBaepvEzHkq6pZ+HVb3a6/ILeWW2zUqiVZXkE=; fh=uuoe4UKYT2E5OMwnAY+SI7vyjGAVTqtTGW4QUL8ZvlE=; b=cLTRy9VYnXpHKlHl/86Bjzdc5ekZYMCQgvCjdLzt1b2hsCWNV5W3pQ7TWNNT/zdGUz GCmk9OUpqlPDPECC1j4QzKddV6rV+KnSrnbNe3Kp6BsDWeVYumbGFIHYdtr7rOZwMjEQ XuoyEOZRsF7SOrhpLWgB/E90EuUy77rBEctaaDXDAxjtizmkfyOFkf/F/b3FO6oJTvRb rGekMmZMPRtXIpGGrnvtsEzJHrZR6KxaAjKA4gxJPZGsJLoAl51sSV6cp1K6jz+MTk1J xYqzJpTtTL2X/e/5qJ5LKBlkOgkAcwpYUerP3zrRxl5+iCHxlmZfiLch3BakLe7K0jiE H0rw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=XbulXuX5; arc=pass (i=1 spf=pass spfdomain=redhat.com dkim=pass dkdomain=redhat.com dmarc=pass fromdomain=redhat.com); spf=pass (google.com: domain of linux-kernel+bounces-204113-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-204113-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id a640c23a62f3a-a6c806db566si56459966b.426.2024.06.06.03.32.41 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 06 Jun 2024 03:32:41 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-204113-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=XbulXuX5; arc=pass (i=1 spf=pass spfdomain=redhat.com dkim=pass dkdomain=redhat.com dmarc=pass fromdomain=redhat.com); spf=pass (google.com: domain of linux-kernel+bounces-204113-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-204113-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 6837D1F26CF4 for ; Thu, 6 Jun 2024 10:32:41 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 228371957ED; Thu, 6 Jun 2024 10:32:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="XbulXuX5" Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 987441953A8 for ; Thu, 6 Jun 2024 10:32:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717669931; cv=none; b=dCYoH1Fokyb9AheX2p8m+3ktq8XtIx7FlN+3tF5coB+6WLZayz4GWWn/NyEOugu9NIRap2ggKddu4k3Uw+UHOC1pWisujIJsikFyae8LvmcH2loaYfVvqYTNOvEJsiY9QnCrZcEkuC25O4Ve1k2QDnu00jm2BoHos5vC7YKVEEQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717669931; c=relaxed/simple; bh=YdSiMdtyFWm0ebM3vMJuUzuqgktJqM5o3IypdS48e7w=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=Q0Jbi3YpN7Nu0qDAyrNzmq3zVAQf4XDUu+kZc+ijf0+Ch7SeILmiEsACMN34pEUPscE1Z2IepJgf5qMZBz29T7r+63I20vO8VdAxX1zt0yy8FkelvM8hKo13qH6C0LB00wyvDBscn5H8ZF3EKM3a5eVLtByl0mS3Vd1fzqTgn4g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=XbulXuX5; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1717669928; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=okcCBnpBaepvEzHkq6pZ+HVb3a6/ILeWW2zUqiVZXkE=; b=XbulXuX5E5Sp4f02G8WJV9tWLbUOCU8tS8b19G+3IUFv0a5AFIbEOmEcvKLy/Y/MfpDVAC 9t50vy6EQzhykcLX58p1nLZeTrFf/YUJfCSfUXQtqDFMw6ewm6FdvrXYAtsSmZOUuzxMD9 AzvJc5NAlBCXXMKr3BORilrgjfvFc0Q= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-621-TfFr0kyFPfCE64X0prDu2A-1; Thu, 06 Jun 2024 06:32:07 -0400 X-MC-Unique: TfFr0kyFPfCE64X0prDu2A-1 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-35dc02bfc28so121816f8f.1 for ; Thu, 06 Jun 2024 03:32:07 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717669926; x=1718274726; h=mime-version:user-agent:content-transfer-encoding:autocrypt :references:in-reply-to:date:cc:to:from:subject:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=okcCBnpBaepvEzHkq6pZ+HVb3a6/ILeWW2zUqiVZXkE=; b=koWF5QNRrR0gr2IQsGDXDj00I48sGdr0O3JPIKMXhKoaIQEY7izu+HvVMXoPjomDl5 YvycrD8t+sIjvEO3PBPyR05iae/ZXrk0rTqL3ECzU0TawQF+4D/uJ4W4c/ikwL3CFO49 FlMBhrRWrYbb9wJEVzOrzAPctln+DX64pZ7pUUraO4C3CZjy5KY/fo92STRGXk1/3+t0 vWLWEBSRFx7MJh9iP2T3LrY7++oSDzg9v/30195LGCftDDVJSIFLsMiHksGT4OyQW1fC jgaoj3/LVR8shmaZZPsWnO8AJZsENCF3HSjwhvVAweLI0nvEeJP+4WWIlY4GSLPXQS6f 3ttA== X-Forwarded-Encrypted: i=1; AJvYcCVFR+I6wsryG5Nil4lPBlV3OCdUqlopqxW4hIgdaUxn98N44aQB/ScKoxixst43yB/jYPRPfuEET9diUljzM+bircLLkTQStX+X8p/Q X-Gm-Message-State: AOJu0Yx/i9u5NX4obLgzk8Y6pqjPjgTpNMKlBzuJG97VRbCX1pin47jy tc0gLB9MPqhfTN8aLkcqNnkt4XHzbFZzi3bqKlbJpJ9VFybCfVGjBLDw9VbiMYMY7CR2GymyltG qK/qHa95/i0cNCwMFJ/ji69RMvr3jbmDkj+SWTAU91P/8cvxd4Wmz+RMu1zm56w== X-Received: by 2002:a05:600c:1c84:b0:419:f68e:118c with SMTP id 5b1f17b1804b1-421562be89emr38745445e9.1.1717669926173; Thu, 06 Jun 2024 03:32:06 -0700 (PDT) X-Received: by 2002:a05:600c:1c84:b0:419:f68e:118c with SMTP id 5b1f17b1804b1-421562be89emr38745275e9.1.1717669925822; Thu, 06 Jun 2024 03:32:05 -0700 (PDT) Received: from gerbillo.redhat.com ([2a0d:3344:1b74:3a10::f71]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4215c1aa954sm17043235e9.17.2024.06.06.03.32.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 06 Jun 2024 03:32:05 -0700 (PDT) Message-ID: Subject: Re: [PATCH net-next v2 2/3] net: ti: icss-iep: Enable compare events From: Paolo Abeni To: Diogo Ivo , MD Danish Anwar , Roger Quadros , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Richard Cochran , Nishanth Menon , Vignesh Raghavendra , Tero Kristo , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Jan Kiszka , Jacob Keller , Simon Horman Cc: linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Date: Thu, 06 Jun 2024 12:32:03 +0200 In-Reply-To: <20240604-iep-v2-2-ea8e1c0a5686@siemens.com> References: <20240604-iep-v2-0-ea8e1c0a5686@siemens.com> <20240604-iep-v2-2-ea8e1c0a5686@siemens.com> Autocrypt: addr=pabeni@redhat.com; prefer-encrypt=mutual; keydata=mQINBGISiDUBEAC5uMdJicjm3ZlWQJG4u2EU1EhWUSx8IZLUTmEE8zmjPJFSYDcjtfGcbzLPb63BvX7FADmTOkO7gwtDgm501XnQaZgBUnCOUT8qv5MkKsFH20h1XJyqjPeGM55YFAXc+a4WD0YyO5M0+KhDeRLoildeRna1ey944VlZ6Inf67zMYw9vfE5XozBtytFIrRyGEWkQwkjaYhr1cGM8ia24QQVQid3P7SPkR78kJmrT32sGk+TdR4YnZzBvVaojX4AroZrrAQVdOLQWR+w4w1mONfJvahNdjq73tKv51nIpu4SAC1Zmnm3x4u9r22mbMDr0uWqDqwhsvkanYmn4umDKc1ZkBnDIbbumd40x9CKgG6ogVlLYeJa9WyfVMOHDF6f0wRjFjxVoPO6p/ZDkuEa67KCpJnXNYipLJ3MYhdKWBZw0xc3LKiKc+nMfQlo76T/qHMDfRMaMhk+L8gWc3ZlRQFG0/Pd1pdQEiRuvfM5DUXDo/YOZLV0NfRFU9SmtIPhbdm9cV8Hf8mUwubihiJB/9zPvVq8xfiVbdT0sPzBtxW0fXwrbFxYAOFvT0UC2MjlIsukjmXOUJtdZqBE3v3Jf7VnjNVj9P58+MOx9iYo8jl3fNd7biyQWdPDfYk9ncK8km4skfZQIoUVqrWqGDJjHO1W9CQLAxkfOeHrmG29PK9tHIwARAQABtB9QYW9sbyBBYmVuaSA8cGFiZW5pQHJlZGhhdC5jb20+iQJSBBMBCAA8FiEEg1AjqC77wbdLX2LbKSR5jcyPE6QFAmISiDUCGwMFCwkIBwIDIgIBBhUKCQgLAgQWAgMBAh4HAheAAAoJECkkeY3MjxOkJSYQAJcc6MTsuFxYdYZkeWjW//zbD3ApRHzpNlHLVSuJqHr9/aDS+tyszgS8jj9MiqALzgq4iZbg 7ZxN9ZsDL38qVIuFkSpgMZCiUHdxBC11J8nbBSLlpnc924UAyr5XrGA99 6Wl5I4Km3128GY6iAkH54pZpOmpoUyBjcxbJWHstzmvyiXrjA2sMzYjt3Xkqp0cJfIEekOi75wnNPofEEJg28XPcFrpkMUFFvB4Aqrdc2yyR8Y36rbw18sIX3dJdomIP3dL7LoJi9mfUKOnr86Z0xltgcLPGYoCiUZMlXyWgB2IPmmcMP2jLJrusICjZxLYJJLofEjznAJSUEwB/3rlvFrSYvkKkVmfnfro5XEr5nStVTECxfy7RTtltwih85LlZEHP8eJWMUDj3P4Q9CWNgz2pWr1t68QuPHWaA+PrXyasDlcRpRXHZCOcvsKhAaCOG8TzCrutOZ5NxdfXTe3f1jVIEab7lNgr+7HiNVS+UPRzmvBc73DAyToKQBn9kC4jh9HoWyYTepjdcxnio0crmara+/HEyRZDQeOzSexf85I4dwxcdPKXv0fmLtxrN57Ae82bHuRlfeTuDG3x3vl/Bjx4O7Lb+oN2BLTmgpYq7V1WJPUwikZg8M+nvDNcsOoWGbU417PbHHn3N7yS0lLGoCCWyrK1OY0QM4EVsL3TjOfUtCNQYW9sbyBBYmVuaSA8cGFvbG8uYWJlbmlAZ21haWwuY29tPokCUgQTAQgAPBYhBINQI6gu+8G3S19i2ykkeY3MjxOkBQJiEoitAhsDBQsJCAcCAyICAQYVCgkICwIEFgIDAQIeBwIXgAAKCRApJHmNzI8TpBzHD/45pUctaCnhee1vkQnmStAYvHmwrWwIEH1lzDMDCpJQHTUQOOJWDAZOFnE/67bxSS81Wie0OKW2jvg1ylmpBA0gPpnzIExQmfP72cQ1TBoeVColVT6Io35BINn+ymM7c0Bn8RvngSEpr3jBtqvvWXjvtnJ5/HbOVQCg62NC6ewosoKJPWpGXMJ9SKsVIOUHsmoWK60spzeiJoSmAwm3zTJQnM5kRh2q iWjoCy8L35zPqR5TV+f5WR5hTVCqmLHSgm1jxwKhPg9L+GfuE4d0SWd84y GeOB3sSxlhWsuTj1K6K3MO9srD9hr0puqjO9sAizd0BJP8ucf/AACfrgmzIqZXCfVS7jJ/M+0ic+j1Si3yY8wYPEi3dvbVC0zsoGj9n1R7B7L9c3g1pZ4L9ui428vnPiMnDN3jh9OsdaXeWLvSvTylYvw9q0DEXVQTv4/OkcoMrfEkfbXbtZ3PRlAiddSZA5BDEkkm6P9KA2YAuooi1OD9d4MW8LFAeEicvHG+TPO6jtKTacdXDRe611EfRwTjBs19HmabSUfFcumL6BlVyceIoSqXFe5jOfGpbBevTZtg4kTSHqymGb6ra6sKs+/9aJiONs5NXY7iacZ55qG3Ib1cpQTps9bQILnqpwL2VTaH9TPGWwMY3Nc2VEc08zsLrXnA/yZKqZ1YzSY9MGXWYLkCDQRiEog1ARAAyXMKL+x1lDvLZVQjSUIVlaWswc0nV5y2EzBdbdZZCP3ysGC+s+n7xtq0o1wOvSvaG9h5q7sYZs+AKbuUbeZPu0bPWKoO02i00yVoSgWnEqDbyNeiSW+vI+VdiXITV83lG6pS+pAoTZlRROkpb5xo0gQ5ZeYok8MrkEmJbsPjdoKUJDBFTwrRnaDOfb+Qx1D22PlAZpdKiNtwbNZWiwEQFm6mHkIVSTUe2zSemoqYX4QQRvbmuMyPIbwbdNWlItukjHsffuPivLF/XsI1gDV67S1cVnQbBgrpFDxN62USwewXkNl+ndwa+15wgJFyq4Sd+RSMTPDzDQPFovyDfA/jxN2SK1Lizam6o+LBmvhIxwZOfdYH8bdYCoSpqcKLJVG3qVcTwbhGJr3kpRcBRz39Ml6iZhJyI3pEoX3bJTlR5Pr1Kjpx13qGydSMos94CIYWAKhegI06aTdvvuiigBwjngo/Rk5S+iEGR5KmTqGyp27o6YxZy6D4NIc6PKUzhIUxfvuHNvfu sD2W1U7eyLdm/jCgticGDsRtweytsgCSYfbz0gdgUuL3EBYN3JLbAU+UZpy v/fyD4cHDWaizNy/KmOI6FFjvVh4LRCpGTGDVPHsQXaqvzUybaMb7HSfmBBzZqqfVbq9n5FqPjAgD2lJ0rkzb9XnVXHgr6bmMRlaTlBMAEQEAAYkCNgQYAQgAIBYhBINQI6gu+8G3S19i2ykkeY3MjxOkBQJiEog1AhsMAAoJECkkeY3MjxOkY1YQAKdGjHyIdOWSjM8DPLdGJaPgJdugHZowaoyCxffilMGXqc8axBtmYjUIoXurpl+f+a7S0tQhXjGUt09zKlNXxGcebL5TEPFqgJTHN/77ayLslMTtZVYHE2FiIxkvW48yDjZUlefmphGpfpoXe4nRBNto1mMB9Pb9vR47EjNBZCtWWbwJTIEUwHP2Z5fV9nMx9Zw2BhwrfnODnzI8xRWVqk7/5R+FJvl7s3nY4F+svKGD9QHYmxfd8Gx42PZc/qkeCjUORaOf1fsYyChTtJI4iNm6iWbD9HK5LTMzwl0n0lL7CEsBsCJ97i2swm1DQiY1ZJ95G2Nz5PjNRSiymIw9/neTvUT8VJJhzRl3Nb/EmO/qeahfiG7zTpqSn2dEl+AwbcwQrbAhTPzuHIcoLZYV0xDWzAibUnn7pSrQKja+b8kHD9WF+m7dPlRVY7soqEYXylyCOXr5516upH8vVBmqweCIxXSWqPAhQq8d3hB/Ww2A0H0PBTN1REVw8pRLNApEA7C2nX6RW0XmA53PIQvAP0EAakWsqHoKZ5WdpeOcH9iVlUQhRgemQSkhfNaP9LqR1XKujlTuUTpoyT3xwAzkmSxN1nABoutHEO/N87fpIbpbZaIdinF7b9srwUvDOKsywfs5HMiUZhLKoZzCcU/AEFjQsPTATACGsWf3JYPnWxL9 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.50.4 (3.50.4-1.fc39) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Tue, 2024-06-04 at 14:15 +0100, Diogo Ivo wrote: > @@ -571,6 +573,57 @@ static int icss_iep_perout_enable(struct icss_iep *i= ep, > return ret; > } > =20 > +static void icss_iep_cap_cmp_work(struct work_struct *work) > +{ > + struct icss_iep *iep =3D container_of(work, struct icss_iep, work); > + const u32 *reg_offs =3D iep->plat_data->reg_offs; > + struct ptp_clock_event pevent; > + unsigned int val; > + u64 ns, ns_next; > + > + spin_lock(&iep->irq_lock); 'irq_lock' is always acquired with the irqsave variant, and here we are in process context. This discrepancy would at least deserve a comment; likely the above lock type is not correct. Cheers, Paolo