Received-SPF: pass (google.com: domain of linux-kernel+bounces-204091-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Date: Thu, 6 Jun 2024 13:14:53 +0300
From: Serge Semin <fancer.lancer@gmail.com>
To: Simon Horman <horms@kernel.org>
Cc: Andrew Lunn <andrew@lunn.ch>, Heiner Kallweit <hkallweit1@gmail.com>, 
	Russell King <linux@armlinux.org.uk>, Alexandre Torgue <alexandre.torgue@foss.st.com>, 
	Jose Abreu <joabreu@synopsys.com>, Jose Abreu <Jose.Abreu@synopsys.com>, 
	Vladimir Oltean <olteanv@gmail.com>, Florian Fainelli <f.fainelli@gmail.com>, 
	Maxime Chevallier <maxime.chevallier@bootlin.com>, Rob Herring <robh+dt@kernel.org>, 
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley <conor+dt@kernel.org>, 
	"David S. Miller" <davem@davemloft.net>, Eric Dumazet <edumazet@google.com>, 
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>, 
	Sagar Cheluvegowda <quic_scheluve@quicinc.com>, Abhishek Chauhan <quic_abchauha@quicinc.com>, 
	Andrew Halaney <ahalaney@redhat.com>, Jiawen Wu <jiawenwu@trustnetic.com>, 
	Mengyuan Lou <mengyuanlou@net-swift.com>, Tomer Maimon <tmaimon77@gmail.com>, openbmc@lists.ozlabs.org, 
	netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v2 07/10] net: pcs: xpcs: Add Synopsys DW xPCS
 platform device driver
Message-ID: <uhswmnjhbu333kz5z4mbjtoao6grftfsn7aj4mcizmqgukn6be@6wc65fpsgkzu>
References: <20240602143636.5839-1-fancer.lancer@gmail.com>
 <20240602143636.5839-8-fancer.lancer@gmail.com>
 <20240605174817.GQ791188@kernel.org>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240605174817.GQ791188@kernel.org>

Hi Simon

On Wed, Jun 05, 2024 at 06:48:17PM +0100, Simon Horman wrote:
> On Sun, Jun 02, 2024 at 05:36:21PM +0300, Serge Semin wrote:
> 
> ...
> 
> > diff --git a/drivers/net/pcs/pcs-xpcs-plat.c b/drivers/net/pcs/pcs-xpcs-plat.c
> 
> ...
> 
> > +const struct dev_pm_ops xpcs_plat_pm_ops = {
> > +	SET_RUNTIME_PM_OPS(xpcs_plat_pm_runtime_suspend,
> > +			   xpcs_plat_pm_runtime_resume,
> > +			   NULL)
> > +};
> 

> nit: xpcs_plat_pm_ops only seems to be used in this file.
>      If so it should probably be static.
> 
>      Flagged by Sparse.

Right. I'll convert it to being static. Thanks.

-Serge(y)

> 
> ...
> 
> > +static struct platform_driver xpcs_plat_driver = {
> > +	.probe = xpcs_plat_probe,
> > +	.driver = {
> > +		.name = "dwxpcs",
> > +		.pm = &xpcs_plat_pm_ops,
> > +		.of_match_table = xpcs_of_ids,
> > +	},
> > +};
> > +module_platform_driver(xpcs_plat_driver);
> 
> ...