Received-SPF: pass (google.com: domain of linux-kernel+bounces-204150-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Message-ID: <bc12b046-d2fb-48ae-bd5b-a6ef6cc78c07@collabora.com>
Date: Thu, 6 Jun 2024 13:00:11 +0200
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] remoteproc: mediatek: Increase MT8188 SCP core0 DRAM size
To: jason-ch chen <jason-ch.chen@mediatek.corp-partner.google.com>,
 Bjorn Andersson <andersson@kernel.org>,
 Mathieu Poirier <mathieu.poirier@linaro.org>,
 Matthias Brugger <matthias.bgg@gmail.com>
Cc: Project_Global_Chrome_Upstream_Group@mediatek.com,
 linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org,
 linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org,
 Jason Chen <Jason-ch.Chen@mediatek.com>
References: <20240606090609.3199-1-jason-ch.chen@mediatek.corp-partner.google.com>
From: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Content-Language: en-US
In-Reply-To: <20240606090609.3199-1-jason-ch.chen@mediatek.corp-partner.google.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Il 06/06/24 11:06, jason-ch chen ha scritto:
> From: Jason Chen <Jason-ch.Chen@mediatek.com>
> 
> Increase MT8188 SCP core0 DRAM size for HEVC driver.
> 

....so the second core only gets a maximum of 0x200000 of SRAM?
I'm not sure how useful is the secondary SCP core, at this point, with so little
available SRAM but... okay, as you wish.

Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>


> Signed-off-by: Jason Chen <Jason-ch.Chen@mediatek.com>
> ---
>   drivers/remoteproc/mtk_scp.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/remoteproc/mtk_scp.c b/drivers/remoteproc/mtk_scp.c
> index b885a9a041e4..2119fc62c3f2 100644
> --- a/drivers/remoteproc/mtk_scp.c
> +++ b/drivers/remoteproc/mtk_scp.c
> @@ -1390,7 +1390,7 @@ static const struct mtk_scp_sizes_data default_scp_sizes = {
>   };
>   
>   static const struct mtk_scp_sizes_data mt8188_scp_sizes = {
> -	.max_dram_size = 0x500000,
> +	.max_dram_size = 0x800000,
>   	.ipi_share_buffer_size = 600,
>   };
>