Received-SPF: pass (google.com: domain of linux-kernel+bounces-204179-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Subject: Re: [PATCH] block: bio-integrity: fix potential null-ptr-deref in
 bio_integrity_free
To: Christoph Hellwig <hch@infradead.org>
References: <20240606062655.2185006-1-yebin@huaweicloud.com>
 <ZmFatW3BEzTPgR7S@infradead.org>
Cc: axboe@kernel.dk, linux-block@vger.kernel.org,
 linux-kernel@vger.kernel.org, ming.lei@redhat.com,
 Ye Bin <yebin10@huawei.com>
From: yebin <yebin@huaweicloud.com>
Message-ID: <66619EB6.4040002@huaweicloud.com>
Date: Thu, 6 Jun 2024 19:34:14 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:38.0) Gecko/20100101
 Thunderbird/38.1.0
Precedence: bulk
MIME-Version: 1.0
In-Reply-To: <ZmFatW3BEzTPgR7S@infradead.org>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit


On 2024/6/6 14:44, Christoph Hellwig wrote:
> What kernel is this on?  As of Linux 6.9 we are now always freezing
v4.18
> the queue while updating the logical_block_size in the nvme driver,
> so there should be no inflight I/O while it is changing.
>
The root cause of the problem is that there is no concurrency protection 
between
issuing DIO checks in __ blkdev direct IO simple() and updating logical 
block sizes ,
resulting in the block layer being able to see DIOs that are not aligned 
with logical
blocks.