Received-SPF: pass (google.com: domain of linux-kernel+bounces-203761-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Date: Thu, 6 Jun 2024 10:50:51 +0300
From: Heikki Krogerus <heikki.krogerus@linux.intel.com>
To: Markus Elfring <Markus.Elfring@web.de>
Cc: linux-usb@vger.kernel.org, kernel-janitors@vger.kernel.org,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Xin Ji <xji@analogixsemi.com>, LKML <linux-kernel@vger.kernel.org>,
	Jonathan Cameron <Jonathan.Cameron@huawei.com>
Subject: Re: [PATCH] usb: typec: anx7411: Use scope-based resource management
 in anx7411_typec_port_probe()
Message-ID: <ZmFqWxqOsd6FxD3l@kuha.fi.intel.com>
References: <889729ac-3fc5-4666-b9f5-ce6e588a341a@web.de>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <889729ac-3fc5-4666-b9f5-ce6e588a341a@web.de>

On Wed, Jun 05, 2024 at 07:11:04PM +0200, Markus Elfring wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Wed, 5 Jun 2024 18:56:19 +0200
> 
> Scope-based resource management became supported also for another
> programming interface by contributions of Jonathan Cameron on 2024-02-17.
> See also the commit 59ed5e2d505bf5f9b4af64d0021cd0c96aec1f7c ("device
> property: Add cleanup.h based fwnode_handle_put() scope based cleanup.").
> 
> * Thus use the attribute “__free(fwnode_handle)”.
> 
> * Reduce the scope for the local variable “fwnode”.
> 
> Fixes: fe6d8a9c8e64 ("usb: typec: anx7411: Add Analogix PD ANX7411 support")
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>

Was the fwnode leaked, or why else is this a "fix"? It's not clear
from the commit message. In any case:

Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>

> ---
>  drivers/usb/typec/anx7411.c | 7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/usb/typec/anx7411.c b/drivers/usb/typec/anx7411.c
> index b12a07edc71b..9fb52f233a30 100644
> --- a/drivers/usb/typec/anx7411.c
> +++ b/drivers/usb/typec/anx7411.c
> @@ -16,6 +16,7 @@
>  #include <linux/of_graph.h>
>  #include <linux/of_platform.h>
>  #include <linux/pm_runtime.h>
> +#include <linux/property.h>
>  #include <linux/regulator/consumer.h>
>  #include <linux/slab.h>
>  #include <linux/types.h>
> @@ -1142,11 +1143,11 @@ static int anx7411_typec_port_probe(struct anx7411_data *ctx,
>  {
>  	struct typec_capability *cap = &ctx->typec.caps;
>  	struct typec_params *typecp = &ctx->typec;
> -	struct fwnode_handle *fwnode;
>  	const char *buf;
>  	int ret, i;
> 
> -	fwnode = device_get_named_child_node(dev, "connector");
> +	struct fwnode_handle *fwnode __free(fwnode_handle)
> +				     = device_get_named_child_node(dev, "connector");
>  	if (!fwnode)
>  		return -EINVAL;
> 
> @@ -1237,7 +1238,7 @@ static int anx7411_typec_port_probe(struct anx7411_data *ctx,
>  		typecp->caps_flags |= HAS_SINK_WATT;
>  	}
> 
> -	cap->fwnode = fwnode;
> +	cap->fwnode = no_free_ptr(fwnode);
> 
>  	ctx->typec.role_sw = usb_role_switch_get(dev);
>  	if (IS_ERR(ctx->typec.role_sw)) {
> --
> 2.45.1

-- 
heikki