Received-SPF: pass (google.com: domain of linux-kernel+bounces-204281-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Thu, 6 Jun 2024 13:38:14 +0100
From: Matthew Wilcox <willy@infradead.org>
To: Chao Yu <chao@kernel.org>
Cc: jaegeuk@kernel.org, linux-f2fs-devel@lists.sourceforge.net,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] f2fs: get rid of buffer_head use
Message-ID: <ZmGttup4xQM_jWky@casper.infradead.org>
References: <20240606095037.4086881-1-chao@kernel.org>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240606095037.4086881-1-chao@kernel.org>

On Thu, Jun 06, 2024 at 05:50:37PM +0800, Chao Yu wrote:
> For later folio conversion.

What tree is this against?

> @@ -3957,32 +3976,32 @@ static int read_raw_super_block(struct f2fs_sb_info *sbi,
>  		return -ENOMEM;
>  
>  	for (block = 0; block < 2; block++) {
> -		bh = sb_bread(sb, block);
> -		if (!bh) {
> +		page = read_mapping_page(sb->s_bdev->bd_inode->i_mapping,
> +								block, NULL);

You need to use bd_mapping, not bd_inode->i_mapping (since May 21 in
Linus' tree).

And I don't think there's much point in switching to pages as an
intermediate step.  You may as well go straight to folios.

		folio = read_mapping_folio(sb->s_bdev->bd_mapping, block, NULL);