Received: by 2002:ab2:6309:0:b0:1fb:d597:ff75 with SMTP id s9csp354952lqt; Thu, 6 Jun 2024 05:56:47 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCWrZ+shQrdRu7WxbXCbqXsyILzCVZb6gq6DRwufBiIqZMOKCl5/kBigGBtDIejGkJ8+KEeIPcLHnrE3fP5WBE+X9ydofP3PunbiexA73A== X-Google-Smtp-Source: AGHT+IGaWSoD5YkYYS55lZyWN9CEZtAkYnuXy9ZiKGT9HlCN1qxvym0EO532jU4DUZP08IEIpXiw X-Received: by 2002:ac8:7f12:0:b0:440:29e8:819b with SMTP id d75a77b69052e-4402b6ea9b1mr50146131cf.64.1717678606985; Thu, 06 Jun 2024 05:56:46 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1717678606; cv=pass; d=google.com; s=arc-20160816; b=ak2G32R2ySFIBCGVafSbstWs7vCPOA/7R5HTRnkZ5IsLC5jt5iBxyNg4CF9T4u3SI+ s8VNDIcCL4g9j4EjV0ByVl3Bh/zroU1SZYojdO5LPeDhpXZNXp2PiY9ZqaD8SRqVau8p Ulfwmi36V2kicFKixmF9bFyQm9QzJjAQ1U7oHUkkD7jyfvDar89ksbP3ast2Ycpm4AI6 7EMTCBZpAqF/6Pi5r8fK2YAvdKGggA7qiImorBEvUnAatKiztzgxIjrRkm3L2rkLMe2g c11CW4FnQch44lfbk8Qbyc4yG8Wx/bK+r7b+HrxSwUt4OcId4MpFB9A0xS2KQuIWrwpd A5zA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from; bh=lhVTKfVf3Z6YMV/6a4p2f4s3suyYGjeBWvmjm+NkF64=; fh=eu2llfKjKKC0QBUtW6YWJ13du6subP7SB8ZN6DjSWMA=; b=iRbUnh16DXH4+0zDTOlvCfha2zamJvslHaHO21pPTocoHNFiMldkMoz7RNsqrwh7FJ 8/u13P6L8zye8GhtvBetitU1loUDnqJh9ql2UEV87baMdPal5BpvJjbZxvqw4jxeqkg2 r/kjB+FrZcgn+WojwvPzc6Ztn31N2ztcMBfIxrxkXPVtyTz228NdY/VoXX5B3vgrAmue t/RiUUP+a2xYWSJnHeW9CJmEfxL2m+o3lBAh1KgCD94EM1oP7ap5IxIOfjMU+z/HKK1b eN+WRgk3Mk6z5ikp11rS2URT2rqR+ebjBL0ivOjoPdkWVoH6lMZgzzN/R2i2fAIrNAy+ XJWQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; arc=pass (i=1 spf=pass spfdomain=huaweicloud.com); spf=pass (google.com: domain of linux-kernel+bounces-204299-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-204299-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id d75a77b69052e-44038b15f12si15628631cf.271.2024.06.06.05.56.46 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 06 Jun 2024 05:56:46 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-204299-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; arc=pass (i=1 spf=pass spfdomain=huaweicloud.com); spf=pass (google.com: domain of linux-kernel+bounces-204299-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-204299-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id B1DB31C23DAE for ; Thu, 6 Jun 2024 12:56:46 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id C5436195F31; Thu, 6 Jun 2024 12:56:25 +0000 (UTC) Received: from dggsgout11.his.huawei.com (unknown [45.249.212.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E5F8B195B13; Thu, 6 Jun 2024 12:56:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=45.249.212.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717678585; cv=none; b=diQFn87XxHCZ8ermyEsSgYjWolCuCiyQd7vRsGZYBeMQusuMhvzybjAAqMW5srDJ6eKF5W/+/WK2jIPKbPHoxXYQyarItaV1sB80ZbUJphwPMMzs0J0RrmqONDskicVXSgFMO5BBspwi7kRMgomnMBGwlwA6w7iFmM4pViacLd0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717678585; c=relaxed/simple; bh=RgTX+M5nQNBqP5GqXs68I/ytp3G6EXzwjpsGD6jj/sQ=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=id61v0fDvNKuEoKkMqDQ5E/HbcfhCWB6tgKC2YmaBkBRvfjkbxV+50vPkLwuJ5ecj27WrwrRnIIE1zNftUHCYQn8Ca7+q0iQLOKFcrE6BNoBMurVsYTRHzT5NA4ijcXr6T1ZcHwtQbEIqeEJn+1Ns4HCLIWqtjhPK2BDBpALFSw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=huaweicloud.com; spf=pass smtp.mailfrom=huaweicloud.com; arc=none smtp.client-ip=45.249.212.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=huaweicloud.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=huaweicloud.com Received: from mail.maildlp.com (unknown [172.19.163.235]) by dggsgout11.his.huawei.com (SkyGuard) with ESMTP id 4Vw4884Vt7z4f3nZy; Thu, 6 Jun 2024 20:56:08 +0800 (CST) Received: from mail02.huawei.com (unknown [10.116.40.112]) by mail.maildlp.com (Postfix) with ESMTP id C98CA1A06E0; Thu, 6 Jun 2024 20:56:19 +0800 (CST) Received: from huaweicloud.com (unknown [10.175.124.27]) by APP1 (Coremail) with SMTP id cCh0CgC31A3xsWFmlILsOg--.39039S5; Thu, 06 Jun 2024 20:56:19 +0800 (CST) From: Kemeng Shi To: tytso@mit.edu, adilger.kernel@dilger.ca Cc: linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 3/3] ext4: correct comment of h_checksum Date: Thu, 6 Jun 2024 20:55:08 +0800 Message-Id: <20240606125508.1459893-4-shikemeng@huaweicloud.com> X-Mailer: git-send-email 2.30.0 In-Reply-To: <20240606125508.1459893-1-shikemeng@huaweicloud.com> References: <20240606125508.1459893-1-shikemeng@huaweicloud.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CM-TRANSID:cCh0CgC31A3xsWFmlILsOg--.39039S5 X-Coremail-Antispam: 1UD129KBjvdXoWrZw1ruF1kXr1xAFWfGryUJrb_yoWfGwb_Ka 4kKr48Jry5WFs2gr1fCF1rt3yvqr4Iyr43WF4Utr1fWa45ta18Z34DJr45Zr98Wa48G34r Aw18ZFy7Cry8KjkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUIcSsGvfJTRUUUbV8YFVCjjxCrM7AC8VAFwI0_Xr0_Wr1l1xkIjI8I6I8E6xAIw20E Y4v20xvaj40_Wr0E3s1l1IIY67AEw4v_Jr0_Jr4l82xGYIkIc2x26280x7IE14v26r1rM2 8IrcIa0xkI8VCY1x0267AKxVW8JVW5JwA2ocxC64kIII0Yj41l84x0c7CEw4AK67xGY2AK 021l84ACjcxK6xIIjxv20xvE14v26ryj6F1UM28EF7xvwVC0I7IYx2IY6xkF7I0E14v26r 4UJVWxJr1l84ACjcxK6I8E87Iv67AKxVW0oVCq3wA2z4x0Y4vEx4A2jsIEc7CjxVAFwI0_ GcCE3s1le2I262IYc4CY6c8Ij28IcVAaY2xG8wAqx4xG64xvF2IEw4CE5I8CrVC2j2WlYx 0E2Ix0cI8IcVAFwI0_Jr0_Jr4lYx0Ex4A2jsIE14v26r1j6r4UMcvjeVCFs4IE7xkEbVWU JVW8JwACjcxG0xvY0x0EwIxGrwCF04k20xvY0x0EwIxGrwCFx2IqxVCFs4IE7xkEbVWUJV W8JwC20s026c02F40E14v26r1j6r18MI8I3I0E7480Y4vE14v26r106r1rMI8E67AF67kF 1VAFwI0_JF0_Jw1lIxkGc2Ij64vIr41lIxAIcVC0I7IYx2IY67AKxVWUJVWUCwCI42IY6x IIjxv20xvEc7CjxVAFwI0_Gr0_Cr1lIxAIcVCF04k26cxKx2IYs7xG6r1j6r1xMIIF0xvE x4A2jsIE14v26r1j6r4UMIIF0xvEx4A2jsIEc7CjxVAFwI0_Gr0_Gr1UYxBIdaVFxhVjvj DU0xZFpf9x07jec_-UUUUU= X-CM-SenderInfo: 5vklyvpphqwq5kxd4v5lfo033gof0z/ Checksum of xattr block is always crc32c(uuid+blknum+xattrblock), see ext4_xattr_block_csum_set for detail. Remove incorrect comment that "id = inum if refcount=1". Signed-off-by: Kemeng Shi --- fs/ext4/xattr.h | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/fs/ext4/xattr.h b/fs/ext4/xattr.h index bd97c4aa8177..7df0d77643c7 100644 --- a/fs/ext4/xattr.h +++ b/fs/ext4/xattr.h @@ -32,8 +32,7 @@ struct ext4_xattr_header { __le32 h_refcount; /* reference count */ __le32 h_blocks; /* number of disk blocks used */ __le32 h_hash; /* hash value of all attributes */ - __le32 h_checksum; /* crc32c(uuid+id+xattrblock) */ - /* id = inum if refcount=1, blknum otherwise */ + __le32 h_checksum; /* crc32c(uuid+blknum+xattrblock) */ __u32 h_reserved[3]; /* zero right now */ }; -- 2.30.0