Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761385AbYBEUw1 (ORCPT ); Tue, 5 Feb 2008 15:52:27 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1760688AbYBEUwK (ORCPT ); Tue, 5 Feb 2008 15:52:10 -0500 Received: from smtp5.pp.htv.fi ([213.243.153.39]:59933 "EHLO smtp5.pp.htv.fi" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758923AbYBEUwI (ORCPT ); Tue, 5 Feb 2008 15:52:08 -0500 Date: Tue, 5 Feb 2008 22:52:13 +0200 From: Adrian Bunk To: Sam Ravnborg Cc: Ingo Molnar , James Bottomley , linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org Subject: Re: aic7xxx build failure Message-ID: <20080205205213.GH505@cs181133002.pp.htv.fi> References: <20080205174024.GE505@cs181133002.pp.htv.fi> <20080205184735.GA26270@uranus.ravnborg.org> <20080205200623.GA26798@uranus.ravnborg.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20080205200623.GA26798@uranus.ravnborg.org> User-Agent: Mutt/1.5.17+20080114 (2008-01-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2479 Lines: 67 On Tue, Feb 05, 2008 at 09:06:23PM +0100, Sam Ravnborg wrote: > On Tue, Feb 05, 2008 at 07:47:35PM +0100, Sam Ravnborg wrote: > > On Tue, Feb 05, 2008 at 07:40:24PM +0200, Adrian Bunk wrote: > > > Commit 8891fec65ac5b5a74b50c705e31b66c92c3eddeb broke aic7xxx > > > compilation: > > > > > > <-- snip --> > > > > > > $ make O=../out/x86-full > > > ... > > > SHIPPED drivers/scsi/aic7xxx/aic79xx_seq.h > > > SHIPPED drivers/scsi/aic7xxx/aic79xx_reg.h > > > CC drivers/scsi/aic7xxx/aic79xx_core.o > > > gcc: drivers/scsi/aic7xxx/aic79xx_core.c: No such file or directory > > > gcc: no input files > > > make[4]: *** [drivers/scsi/aic7xxx/aic79xx_core.o] Error 1 > > > > > > <-- snip --> > > > > > > Next "make" run brings the same failure in > > > drivers/scsi/aic7xxx/aic7xxx_core.c. > > > > > > With the third "make" it works. > > > > > > It might compile for people with SMP systems using -j? > > > > I can reproduce it and will fix it. > Seems I was sidetracked by some wrong assumptions. > Could you please test this fix. > > Works for me but this time I will do more testing.... Thanks, works fine for me. > Sam > > diff --git a/drivers/scsi/aic7xxx/Makefile b/drivers/scsi/aic7xxx/Makefile > index 4c54954..6aa49e7 100644 > --- a/drivers/scsi/aic7xxx/Makefile > +++ b/drivers/scsi/aic7xxx/Makefile > @@ -44,8 +44,8 @@ clean-files += aic79xx_seq.h aic79xx_reg.h aic79xx_reg_print.c > > # Dependencies for generated files need to be listed explicitly > > -$(addprefix $(src)/,$(aic7xxx-y:.o=.c)): $(obj)/aic7xxx_seq.h $(obj)/aic7xxx_reg.h > -$(addprefix $(src)/,$(aic79xx-y:.o=.c)): $(obj)/aic79xx_seq.h $(obj)/aic79xx_reg.h > +$(addprefix $(src)/,$(aic7xxx-y)): $(obj)/aic7xxx_seq.h $(obj)/aic7xxx_reg.h > +$(addprefix $(src)/,$(aic79xx-y)): $(obj)/aic79xx_seq.h $(obj)/aic79xx_reg.h > > aic7xxx-gen-$(CONFIG_AIC7XXX_BUILD_FIRMWARE) := $(obj)/aic7xxx_reg.h > aic7xxx-gen-$(CONFIG_AIC7XXX_REG_PRETTY_PRINT) += $(obj)/aic7xxx_reg_print.c cu Adrian -- "Is there not promise of rain?" Ling Tan asked suddenly out of the darkness. There had been need of rain for many days. "Only a promise," Lao Er said. Pearl S. Buck - Dragon Seed -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/