Received-SPF: pass (google.com: domain of linux-kernel+bounces-204096-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Thu, 6 Jun 2024 13:17:39 +0300
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Nuno Sa <nuno.sa@analog.com>
Cc: Petr Mladek <pmladek@suse.com>, Jonathan Cameron <jic23@kernel.org>,
	Lars-Peter Clausen <lars@metafoo.de>,
	Olivier Moysan <olivier.moysan@foss.st.com>,
	Jyoti Bhayana <jbhayana@google.com>,
	Chris Down <chris@chrisdown.name>,
	John Ogness <john.ogness@linutronix.de>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Andi Shyti <andi.shyti@kernel.org>, linux-kernel@vger.kernel.org,
	linux-iio@vger.kernel.org
Subject: Re: [PATCH v3 2/4] iio: temperature: ltc2983: convert to
 dev_err_probe()
Message-ID: <ZmGMwwglUlS6_NI_@smile.fi.intel.com>
References: <20240606-dev-add_dev_errp_probe-v3-0-51bb229edd79@analog.com>
 <20240606-dev-add_dev_errp_probe-v3-2-51bb229edd79@analog.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240606-dev-add_dev_errp_probe-v3-2-51bb229edd79@analog.com>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo

On Thu, Jun 06, 2024 at 09:22:38AM +0200, Nuno Sa wrote:
> Use dev_err_probe() (and variants) in the probe() path. While at it, made
> some simple improvements:
>  * Explicitly included the err.h and errno.h headers;
>  * Removed some unnecessary line breaks;
>  * Removed a redundant 'else';
>  * Added some missing \n to prink.

...

> -		if (ret) {
> +		if (ret)
>  			/*
>  			 * This would be catched later but we can just return
>  			 * the error right away.
>  			 */
> -			dev_err(&st->spi->dev, "Property reg must be given\n");
> -			return ERR_PTR(ret);
> -		}
> +			return dev_err_ptr_probe(&st->spi->dev, ret,
> +						 "Property reg must be given\n");

Even if it becomes a one line of code, it's still a multiline branch, due to
comment. I think {} is better to be there. What does checkpatch say about this?


...

> +			return dev_err_ptr_probe(&st->spi->dev, -EINVAL,

You can make all these lines shorter by using

	struct device *dev = &st->spi->dev; // or analogue

at the top of the function.

> +						 "Invalid chann:%d for RTD\n",
> +						 sensor->chan);

-- 
With Best Regards,
Andy Shevchenko