Received-SPF: pass (google.com: domain of linux-kernel+bounces-204102-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Content-Type: text/plain;
	charset=utf-8
Subject: Re: [PATCH] perf sched map: Add command-name option to filter the
 output map
From: Athira Rajeev <atrajeev@linux.vnet.ibm.com>
In-Reply-To: <20240417152521.80340-1-vineethr@linux.ibm.com>
Date: Thu, 6 Jun 2024 15:51:55 +0530
Cc: Peter Zijlstra <peterz@infradead.org>, Ingo Molnar <mingo@redhat.com>,
        Mark Rutland <mark.rutland@arm.com>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Jiri Olsa <jolsa@kernel.org>, Adrian Hunter <adrian.hunter@intel.com>,
        Kan Liang <kan.liang@linux.intel.com>, acme@redhat.com,
        Kajol Jain <kjain@linux.ibm.com>,
        linux-perf-users <linux-perf-users@vger.kernel.org>,
        LKML <linux-kernel@vger.kernel.org>
Message-Id: <92D17E14-8565-4162-81C6-1ADA18AF48C2@linux.vnet.ibm.com>
References: <20240417152521.80340-1-vineethr@linux.ibm.com>
To: Madadi Vineeth Reddy <vineethr@linux.ibm.com>,
        Arnaldo Carvalho de Melo <acme@kernel.org>,
        Namhyung Kim <namhyung@kernel.org>, Ian Rogers <irogers@google.com>
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
MIME-Version: 1.0


> On 17 Apr 2024, at 8:55=E2=80=AFPM, Madadi Vineeth Reddy <vineethr@linux.=
ibm.com> wrote:
>=20
> By default, perf sched map prints sched-in events for all the tasks
> which may not be required all the time as it prints lot of symbols
> and rows to the terminal.
>=20
> With --command-name option, one could specify the specific command
> for which the map has to be shown. This would help in analyzing the
> CPU usage patterns easier for that specific command. Since multiple
> PID's might have the same command name, using command-name filter
> would be more useful for debugging.
>=20
> For other tasks, instead of printing the symbol, ** is printed and
> the same . is used to represent idle. ** is used instead of symbol
> for other tasks because it helps in clear visualization of command
> of interest and secondly the symbol itself doesn't mean anything
> because the sched-in of that symbol will not be printed(first sched-in
> contains pid and the corresponding symbol).
>=20
> 6.8.0
> =3D=3D=3D=3D=3D=3D
>  *A0                   213864.670142 secs A0 =3D> migration/0:18
>  *.                    213864.670148 secs .  =3D> swapper:0
>   .  *B0               213864.670217 secs B0 =3D> migration/1:21
>   .  *.                213864.670223 secs
>   .   .  *C0           213864.670247 secs C0 =3D> migration/2:26
>   .   .  *.            213864.670252 secs
>=20
> 6.8.0 + patch (--command-name =3D schbench)
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
>   **  .   ** *A0       213864.671055 secs A0 =3D> schbench:104834
>  *B0  .   .   A0       213864.671156 secs B0 =3D> schbench:104835
>  *C0  .   .   A0       213864.671187 secs C0 =3D> schbench:104836
>  *D0  .   .   A0       213864.671219 secs D0 =3D> schbench:104837
>  *E0  .   .   A0       213864.671250 secs E0 =3D> schbench:104838
>   E0  .  *D0  A0
>=20
> This helps in visualizing how a benchmark like schbench is spread over
> the available cpus while also knowing which cpus are idle(.) and which
> are not(**). This will be more useful as number of CPUs increase.
>=20
> Signed-off-by: Madadi Vineeth Reddy <vineethr@linux.ibm.com>

Tested the patch and looks good to me

Command to record: perf sched record sleep 5

With the patch, tested below and checked it filters and provides results fo=
r =E2=80=9Csleep=E2=80=9D and =E2=80=9Cperf=E2=80=9D

 perf sched map --command-name sleep
 perf sched map --command-name perf

Reviewed-and-tested-by: Athira Rajeev <atrajeev@linux.vnet.ibm.com <mailto:=
atrajeev@linux.vnet.ibm.com>>

Thanks
Athira
> ---
> tools/perf/Documentation/perf-sched.txt |  4 ++++
> tools/perf/builtin-sched.c              | 17 ++++++++++++++---
> 2 files changed, 18 insertions(+), 3 deletions(-)
>=20
> diff --git a/tools/perf/Documentation/perf-sched.txt b/tools/perf/Documen=
tation/perf-sched.txt
> index 5fbe42bd599b..b04a37560935 100644
> --- a/tools/perf/Documentation/perf-sched.txt
> +++ b/tools/perf/Documentation/perf-sched.txt
> @@ -94,6 +94,10 @@ OPTIONS for 'perf sched map'
> --color-pids::
> Highlight the given pids.
>=20
> +--command-name::
> + Map output only for the given command name.
> + (** indicates other tasks while . is idle).
> +
> OPTIONS for 'perf sched timehist'
> ---------------------------------
> -k::
> diff --git a/tools/perf/builtin-sched.c b/tools/perf/builtin-sched.c
> index 0fce7d8986c0..e60836da53e5 100644
> --- a/tools/perf/builtin-sched.c
> +++ b/tools/perf/builtin-sched.c
> @@ -156,6 +156,7 @@ struct perf_sched_map {
> const char *color_pids_str;
> struct perf_cpu_map *color_cpus;
> const char *color_cpus_str;
> + const char *command;
> struct perf_cpu_map *cpus;
> const char *cpus_str;
> };
> @@ -1594,8 +1595,6 @@ static int map_switch_event(struct perf_sched *sche=
d, struct evsel *evsel,
>=20
> sched->curr_thread[this_cpu.cpu] =3D thread__get(sched_in);
>=20
> - printf("  ");
> -
> new_shortname =3D 0;
> if (!tr->shortname[0]) {
> if (!strcmp(thread__comm_str(sched_in), "swapper")) {
> @@ -1605,7 +1604,8 @@ static int map_switch_event(struct perf_sched *sche=
d, struct evsel *evsel,
> */
> tr->shortname[0] =3D '.';
> tr->shortname[1] =3D ' ';
> - } else {
> + } else if (!sched->map.command || !strcmp(thread__comm_str(sched_in),
> + sched->map.command)) {
> tr->shortname[0] =3D sched->next_shortname1;
> tr->shortname[1] =3D sched->next_shortname2;
>=20
> @@ -1618,10 +1618,18 @@ static int map_switch_event(struct perf_sched *sc=
hed, struct evsel *evsel,
> else
> sched->next_shortname2 =3D '0';
> }
> + } else {
> + tr->shortname[0] =3D '*';
> + tr->shortname[1] =3D '*';
> }
> new_shortname =3D 1;
> }
>=20
> + if (sched->map.command && strcmp(thread__comm_str(sched_in), sched->map=
.command))
> + goto skip;
> +
> + printf("  ");
> +
> for (i =3D 0; i < cpus_nr; i++) {
> struct perf_cpu cpu =3D {
> .cpu =3D sched->map.comp ? sched->map.comp_cpus[i].cpu : i,
> @@ -1678,6 +1686,7 @@ static int map_switch_event(struct perf_sched *sche=
d, struct evsel *evsel,
> out:
> color_fprintf(stdout, color, "\n");
>=20
> +skip:
> thread__put(sched_in);
>=20
> return 0;
> @@ -3560,6 +3569,8 @@ int cmd_sched(int argc, const char **argv)
>                     "highlight given CPUs in map"),
> OPT_STRING(0, "cpus", &sched.map.cpus_str, "cpus",
>                     "display given CPUs in map"),
> + OPT_STRING(0, "command-name", &sched.map.command, "command",
> + "map output only for the given command name"),
> OPT_PARENT(sched_options)
> };
> const struct option timehist_options[] =3D {
> --=20
> 2.39.1
>=20
>=20