Received: by 2002:ab2:6309:0:b0:1fb:d597:ff75 with SMTP id s9csp433333lqt; Thu, 6 Jun 2024 07:52:28 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCUQJXjr+nZox9Q/CuCbfHXObl6Q0qaA9v1vvnae4zzQOWFtZvnYck/XPVmnW/3N2Qyq4FBdk8YCiuheULYJNDoropJ9Nv9OGUMN8jY4LQ== X-Google-Smtp-Source: AGHT+IFMKyN8buGcjmdWrvSTjFxXJ4zS7Ie/FHqWcpfd9wJu5OzHDw/o81PTGcUhiBaOaN1fC+/E X-Received: by 2002:a17:902:f681:b0:1f6:1ef5:8841 with SMTP id d9443c01a7336-1f6a5a26d60mr67429035ad.34.1717685547844; Thu, 06 Jun 2024 07:52:27 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1717685547; cv=pass; d=google.com; s=arc-20160816; b=TEliOW2Yz3RrbxVHVS506XB6KFEprckSsnsR3d/pc8LifGeWLHtdaJzJpQRDNE0b80 kolM9xjfCjyk8FmHP+mXgp22AFHq0HPsHuiKjdfuMA+NfcgM8o/nqbj9ykvO6v5baiAp DoP45k/zMiaNQZHNzfXw3TgaTjynayD1pJCcAuWqXKXXVqmUBNJyG0Ox2ZTXkvxO/L0g ybfZaVfo6fbwJxBEuffSHBdjQqPmNqwukuEnE94/dDmMbfZAB7WXHpn0ofiLdI7zJ+7W 8vDlSRP+PNBQR3ImelyH8ZyQg38c1UmZoZFU+v7h4WVfMcPniWpj7aQfuBY/fq0O6jKw eGiw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:message-id:date:references :in-reply-to:subject:cc:to:dkim-signature:dkim-signature:from; bh=lbeeeM/qoQSiUICaXa6gooEnbgBLMQqpZYgf5h+mTsY=; fh=5B/v7pZwy9PlJrzUIqnMBhJsyPw1kpn+dX6hKs+AGBo=; b=gT6i2BNJ3sydmgpz/R25WX5gC06k7rxrW2UjUT55rRef/Rgj6ieP/Z+kByDo9dd+1E n//FDg91fkO6DFJuGtWfgIeUQncb0Q9Wwrm72zxbwlAPqzu74KBbsitlGDXAjHpZqO3Z +ezC7Ld1NF6fAhuVgqRp7F+7IorfCl5ACgLtd8hU6VKHHvil1Y29DDaLjNRZqBud6l1K 1fSQ7tCHra9ctA4Iopd4OOZXlGIIE8e1aTd37lybtmKqBPWIzQfaAb1qHb9s/Hl7vkkb hlkqC1P2psoaefoMhwaDR9ggW1PavitAX6wVV+PQemRELRH/ij9lMgJ2EWQXkvFA+H8l 7uAA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b="vl/CC76J"; dkim=neutral (no key) header.i=@linutronix.de header.s=2020e; arc=pass (i=1 spf=pass spfdomain=linutronix.de dkim=pass dkdomain=linutronix.de dmarc=pass fromdomain=linutronix.de); spf=pass (google.com: domain of linux-kernel+bounces-204456-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-204456-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id d9443c01a7336-1f6bd822b4dsi12612515ad.583.2024.06.06.07.52.27 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 06 Jun 2024 07:52:27 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-204456-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b="vl/CC76J"; dkim=neutral (no key) header.i=@linutronix.de header.s=2020e; arc=pass (i=1 spf=pass spfdomain=linutronix.de dkim=pass dkdomain=linutronix.de dmarc=pass fromdomain=linutronix.de); spf=pass (google.com: domain of linux-kernel+bounces-204456-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-204456-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 6E385287450 for ; Thu, 6 Jun 2024 14:51:45 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 9BA56199E9C; Thu, 6 Jun 2024 14:25:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="vl/CC76J"; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="lxgvhS5U" Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 662C9196434 for ; Thu, 6 Jun 2024 14:25:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=193.142.43.55 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717683914; cv=none; b=eC9zwxlIaZROlDcsMebQhhZ3pQep2+n5eebFyHmp/DgFcOGqOAlNqGlM9n+ArAcU4PDJCfhDa3clYc5f8o++VdKbJtfTb3J8nhd7du6pr6CjrZtn9E5N3z2iJCrb7cVjIyd+aibABHcA991si2CpVTgyBQpvZoLyWP83jolnB1k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717683914; c=relaxed/simple; bh=55DOv+WemzOHgA1LKxXbk15qfaceo7b16a6UQvpzg70=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=rxc+eOfFLkj6LUI16a9zV+VMgMVzy826I8+BmMXjhSjPXCdQfMNNC7+Dqv8BVtIb9hEewxVvaqdhTx30HXeyjFGTuzQwHZCkeUJo070adsOpyVbFfcX09HAoOdawcCnEQ05ZiyP+z0kp6sbqLQt3XSoRvl+E0BDEaDX02HrvlaE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linutronix.de; spf=pass smtp.mailfrom=linutronix.de; dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b=vl/CC76J; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b=lxgvhS5U; arc=none smtp.client-ip=193.142.43.55 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linutronix.de From: Thomas Gleixner DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1717683911; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=lbeeeM/qoQSiUICaXa6gooEnbgBLMQqpZYgf5h+mTsY=; b=vl/CC76JVyuHea++LLkkeFFPN+h0T08lOlpreAjgAuNSZj1ftiRWoeKUKXLjKvByggEEiF sd2rSI4gJg4DVn3v9YQvJGfF2CB9/mvTsZvYLx4c4TU/0EqBywk3gvQJVyrMhAxlKEsiCi 71eOgXcmJVMsMFfWCg7sKdSq+87TF0q3rbgwEMi53fMaDMMFkTTGaUMDBG80A9JmU1RzxR /i/pbLAHJgNjFwdbbghCv7LzaCmrfS846prGvVyDj0yn44Jznr6dmXZt6UhwBGKNXqdtIo Kq7wBYgkJFgHlIDB2nuToEy0VRU2U05B/0BGzzTFcPgT8xs0TChPsKc727JQ1Q== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1717683911; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=lbeeeM/qoQSiUICaXa6gooEnbgBLMQqpZYgf5h+mTsY=; b=lxgvhS5UoeLtFUJJBkq8ADcxbQuVzPCCMU2x2vpQ6mp5sR3vqhm2hHL1eyUT2F2a0FFf47 5msiK/OBbW+WXOCQ== To: gaosong , linux-kernel@vger.kernel.org Cc: chenhuacai@kernel.org, jiaxun.yang@flygoat.com, maobibo@loongson.cn Subject: Re: [PATCH] irqchip/loongson-eiointc: Add extioi virt extension support In-Reply-To: References: <20240605070229.2569875-1-gaosong@loongson.cn> <87a5jz47hc.ffs@tglx> Date: Thu, 06 Jun 2024 16:25:11 +0200 Message-ID: <871q5a2lo8.ffs@tglx> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Song! On Thu, Jun 06 2024 at 20:58, gaosong wrote: > =E5=9C=A8 2024/6/6 =E4=B8=8A=E5=8D=881:36, Thomas Gleixner =E5=86=99=E9= =81=93: >> On Wed, Jun 05 2024 at 15:02, Song Gao wrote: >>> int index =3D eiointc_index(node); >>> + int cores =3D (cpu_has_hypervisor ? MAX_CORES_PER_EIO_NODE : CORES_PE= R_EIO_NODE); >> Sigh. Please use the documented ordering of variable declaration >> ordering. > > Sorry, I didn't find the information in document [1]. > > [1]: https://www.kernel.org/doc/html/next/process/coding-style.html https://www.kernel.org/doc/html/latest/process/maintainer-tip.html#coding-s= tyle-notes Thanks, tglx