Received-SPF: pass (google.com: domain of linux-kernel+bounces-204460-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Date: Thu, 6 Jun 2024 19:56:32 +0530
From: "Gautham R. Shenoy" <gautham.shenoy@amd.com>
To: Perry Yuan <perry.yuan@amd.com>
Cc: Mario.Limonciello@amd.com, Ray.Huang@amd.com, Borislav.Petkov@amd.com,
	rafael.j.wysocki@intel.com, Alexander.Deucher@amd.com,
	Xinmei.Huang@amd.com, Xiaojian.Du@amd.com, Li.Meng@amd.com,
	linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 03/10] cpufreq: amd-pstate: show CPPC debug message if
 CPPC is not supported
Message-ID: <ZmHHGLbWbwIzel0z@BLRRASHENOY1.amd.com>
References: <cover.1715356532.git.perry.yuan@amd.com>
 <e6132ee6b6e3c3db5cd9c1e8adc0777881bd2cbd.1715356532.git.perry.yuan@amd.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <e6132ee6b6e3c3db5cd9c1e8adc0777881bd2cbd.1715356532.git.perry.yuan@amd.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?rsxEErxDCkHP3V+V1UMpn0cwp/cip51n1Rx58Pfal8L5Mso5P2+QFw4J2rJt?=
 =?us-ascii?Q?lSg/5/+LZn5Uza1E/AZ9JvR0l+4xg0gwM4IuZgn1n91lArZ5ACdcaSW7XmTw?=
 =?us-ascii?Q?QVMwHCutv2zszYsOlAyERJgFVo10luITBjHX3aa8OiNTQhsTpav8D/u8bYzV?=
 =?us-ascii?Q?m3gnkY3xgifyCCCbAHxbKBTXQrQE31dKtXMuEk0T7MfVTfWj2VPEbsVHSZaF?=
 =?us-ascii?Q?FNeJOMygePg6E2DdbVmd/2Rn9ZTx7nTlqlcRHIEkdsmxh4NNVocptYd/N8BN?=
 =?us-ascii?Q?3lfDFOlIFS5uH+hUKkXtIC6mV44ETd9qBSjinXpVCpifVmFEyWIk9lo25eiV?=
 =?us-ascii?Q?Ra7AuBsRt5dyiR9VYNXXlWmbjFIrJtWdm4jbWVkCBdtQMBsxb3QDUtFcDlwP?=
 =?us-ascii?Q?EHGewWgfWnfMewX/JB3QMH5LcaAgUfhtMGKi3u3FWXqOb5AimsVfJJcLAaS7?=
 =?us-ascii?Q?7pcQZMwjHmj5eZ7e9NFFnfAB21kliVlrSnn/cpP1040Og7WwpbYlUC6+8eBo?=
 =?us-ascii?Q?J12BsVTwj+jbEUSfCdr4VHTqX+K9qLMkDw615wd5WtJ9+OhbHEI+3HwqmsQo?=
 =?us-ascii?Q?QggOYUWiY09it3lQv05Hzzeu99cKGrBjAIhsQENG7neRBlgeMclBzCyEAGAu?=
 =?us-ascii?Q?1vvb5+LYKokEJCmuIk6DaS9RbyMehnBMG1kbT6MmDoirNpRixH7lKVgVjmbW?=
 =?us-ascii?Q?8fjwQm4m9VwqMTr9hSQ1i68Jzf0hK8wbE3wnDCxMljcm6v4khIphGPDlzph3?=
 =?us-ascii?Q?bZumxUO6+/1o0t+gWtFqtRwDOW/5243Cmfl7nXIR692rPLP/IRUwrul5ggT5?=
 =?us-ascii?Q?W13y8nq15CjFe+RvbAkf00vo3DBTtqqjDAOPaKxg1A1gP3ISO0fOKcAxGiOG?=
 =?us-ascii?Q?FUvAouLD5NHcofwMXVhWIqAkcHzHoYcka55rS1KBsFasS16yNoUepAVg2rXj?=
 =?us-ascii?Q?QPpRe2HZUnGmuV7LINrIIi3WOSXq3y/RCAVCUOWx57jW9+wX+b55CF/aK/1R?=
 =?us-ascii?Q?CFKVHZkvj9eilEyXYwZZyq+01eMfELvg7Wo7/dvMheMjrvdz/+R04tIr6lRS?=
 =?us-ascii?Q?SJyY88uvuyQSSAffVQQA7hpXTmN+5wK8LAhKbFVFI5+XkegcBC9LtaHx/Dm6?=
 =?us-ascii?Q?5MbZdfukx4mqKoIsR/f4W9SO56sOgSaGcJ6Zt58D4ooPGQS39p91sJMIzFjU?=
 =?us-ascii?Q?uEr2ycZ+HgYdoi4tz7WZpTHfHKKiTZt8aGlCm/74dDmxF6LfYjWY9SbT32iN?=
 =?us-ascii?Q?5COw5M3dAa07YjDstCAXO+ynnq8NAG1lB5Nk3DCaEogbpZpMA4C0ObRSS+Nj?=
 =?us-ascii?Q?d6JINXlnDDefXfrr+7s5pFxRhxHUi3HZQruzfkQd2chEupD6t5S+o5eFJB31?=
 =?us-ascii?Q?usRFSfp09M/Lko5lpUcm6L5Zo8QPVMzC6oZyG8BOzlQ15+x+64MGREZzqH1t?=
 =?us-ascii?Q?Ec2cDQRLt/RlVnmh94AFg46Wnvcl9m1dL1oj92tJg6JMlOZFmNmQLzwuInpU?=
 =?us-ascii?Q?Q6bNKPvhrHxRnRqOnsqkdMS2R2AGJboQDJDSKQQ6FOAsJnFQeiG2cPPU/LeY?=
 =?us-ascii?Q?5eAE0qQzP+X1SgQaqhI/IJKu+b9E5d+MtPy2NAnP?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 483b7d18-7f84-4e72-3383-08dc8634ae7a
X-MS-Exchange-CrossTenant-AuthSource: DS7PR12MB8252.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Jun 2024 14:26:40.6840
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: a+lUNFST1NGfliucy14sWH4ZMp/CH7LTG6/bXh574loC9nunX88F7gPE07lwy37/MKvTOUen7MX2f36C+txkuw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB7283

On Mon, May 13, 2024 at 10:07:21AM +0800, Perry Yuan wrote:
> Add CPU ID checking in case the driver attempt to load on systems where
> CPPC functionality is unavailable. And the warning message will not
> be shown if CPPC is not supported.
> 
> It will also print debug message if the CPU has no CPPC support that
> helps to debug the driver loading failure issue.
> 
> Reported-by: Paul Menzel <pmenzel@molgen.mpg.de>
> Closes: https://lore.kernel.org/linux-pm/CYYPR12MB8655D32EA18574C9497E888A9C122@CYYPR12MB8655.namprd12.prod.outlook.com/T/#t
> Signed-off-by: Perry Yuan <perry.yuan@amd.com>

Reviewed-by: Gautham R. Shenoy <gautham.shenoy@amd.com>

> ---
>  drivers/cpufreq/amd-pstate.c | 19 +++++++++++++++++++
>  1 file changed, 19 insertions(+)
> 
> diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c
> index 9ca22e94f3f3..3109b46fb02e 100644
> --- a/drivers/cpufreq/amd-pstate.c
> +++ b/drivers/cpufreq/amd-pstate.c
> @@ -1701,6 +1701,20 @@ static int __init amd_pstate_set_driver(int mode_idx)
>  	return -EINVAL;
>  }
>  
> +/**
> + * CPPC function is not supported for family ID 17H with model_ID ranging from 0x10 to 0x2F.
> + * show the debug message that helps to check if the CPU has CPPC support for loading issue.
> + */
> +static bool amd_cppc_supported(void)
> +{
> +	if ((boot_cpu_data.x86 == 0x17) && (boot_cpu_data.x86_model < 0x30)) {
> +		pr_debug_once("CPPC feature is not supported by the processor\n");
> +		return false;
> +	}
> +
> +	return true;
> +}
> +
>  static int __init amd_pstate_init(void)
>  {
>  	struct device *dev_root;
> @@ -1709,6 +1723,11 @@ static int __init amd_pstate_init(void)
>  	if (boot_cpu_data.x86_vendor != X86_VENDOR_AMD)
>  		return -ENODEV;
>  
> +	/* show debug message only if CPPC is not supported */
> +	if (!amd_cppc_supported())
> +		return -EOPNOTSUPP;
> +
> +	/* show warning message when BIOS broken or ACPI disabled */
>  	if (!acpi_cpc_valid()) {
>  		pr_warn_once("the _CPC object is not present in SBIOS or ACPI disabled\n");
>  		return -ENODEV;
> -- 
> 2.34.1
>