Received: by 2002:ab2:6309:0:b0:1fb:d597:ff75 with SMTP id s9csp458489lqt;
        Thu, 6 Jun 2024 08:28:43 -0700 (PDT)
X-Forwarded-Encrypted: i=3; AJvYcCU6AcAKIv+noMWUhR9LmnLadvVA/Hy82dsrlcaCWBpPPKNYY8TZ5V4+Q8EZ1BukOlsK70vj+edVb7jbd00COo/OMFUtZQpva5h37D0i9w==
X-Google-Smtp-Source: AGHT+IH03MYkpKdGoU8LJXF/uuCSSnnd9CduqqAm4RyoEQkbDoxAMqk/Adii+ebt608+kKFCXEVk
X-Received: by 2002:ae9:e50a:0:b0:795:2944:d1bd with SMTP id af79cd13be357-7952944e19dmr449115785a.6.1717687723323;
        Thu, 06 Jun 2024 08:28:43 -0700 (PDT)
ARC-Seal: i=2; a=rsa-sha256; t=1717687723; cv=pass;
        d=google.com; s=arc-20160816;
        b=DBHdJyay2lxdgNUEIAqjGAN6UpV9Q9GzdK8mQ9DuXXdvqcESajfyLIZlBEur7tXnp4
         Fw02Kr169yfpYEuEas6jiG3gBOpMeXyF9HgRBVyPAFCsL5OURcP902YXnVqzlkS0pmTR
         naGrAHbwOgzSmiSlHawJEunecembevCSz3iIvlyZf8qhS/iVG9jLK+tZU7Q4uRHqG2ya
         REHSOCEqYHe/IRR1dA1oojK/Hux/exz9iib8G/1sDzyFxYDoKIAvNHPMm5RbzhJSnGDj
         aTdhyc7kDpur0frnZxnj+J34eEWv5IEnb/NY/WAD9+FSF3NiIHkECSgUrVnzklL7hMNF
         rM+w==
ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=content-transfer-encoding:mime-version:list-unsubscribe
         :list-subscribe:list-id:precedence:references:in-reply-to:message-id
         :subject:cc:to:from:date:dkim-signature;
        bh=y3sWSfcVKzKXwM82BXYfEwhQOQElKVzrlpuOvAbuufw=;
        fh=3ZdWCB/UY5vhQDVtt3AdsZNJO8PvOxMctaQ6kp0yBXE=;
        b=NrGfXoPJpG2KHL6wOUuQ4dOL226TYuB8U6K4/qmt91vEfU8lkuuZIFpcFH77m7uJm3
         gnOI4yWIE0Lp8/b0FqRVj6r/ub3KQHaNZTWOh9XQL4kxHJAjkYqGRAViGZhU06aMjz2Q
         J97kwmWxjIt+iehBlwxn6ddJR4yUus/xqY6beRpjoC0+4eYonoo279/tt1Wajh55VFnn
         xh1GpxU9uF/NwME8v2kQp66ZwxF/2RU2SF38axxVtoLPxAnQL+fvnWCoH1lCtCvbCx3Y
         qZN+6OqCWoNSt3t2Y/VVXMUcjM9g2J1x+aJUBjre1nlWweSPHd7b/Xc5Z46ZJIEYYLpT
         p7sg==;
        dara=google.com
ARC-Authentication-Results: i=2; mx.google.com;
       dkim=pass header.i=@kernel.org header.s=k20201202 header.b=udZ46Thb;
       arc=pass (i=1 dkim=pass dkdomain=kernel.org);
       spf=pass (google.com: domain of linux-kernel+bounces-204574-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-204574-linux.lists.archive=gmail.com@vger.kernel.org";
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org
Return-Path: <linux-kernel+bounces-204574-linux.lists.archive=gmail.com@vger.kernel.org>
Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223])
        by mx.google.com with ESMTPS id af79cd13be357-795332ef296si159662685a.490.2024.06.06.08.28.43
        for <linux.lists.archive@gmail.com>
        (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
        Thu, 06 Jun 2024 08:28:43 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-kernel+bounces-204574-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Authentication-Results: mx.google.com;
       dkim=pass header.i=@kernel.org header.s=k20201202 header.b=udZ46Thb;
       arc=pass (i=1 dkim=pass dkdomain=kernel.org);
       spf=pass (google.com: domain of linux-kernel+bounces-204574-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-204574-linux.lists.archive=gmail.com@vger.kernel.org";
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org
Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by ny.mirrors.kernel.org (Postfix) with ESMTPS id EE1B81C218BC
	for <linux.lists.archive@gmail.com>; Thu,  6 Jun 2024 15:28:42 +0000 (UTC)
Received: from localhost.localdomain (localhost.localdomain [127.0.0.1])
	by smtp.subspace.kernel.org (Postfix) with ESMTP id 8616E196C9D;
	Thu,  6 Jun 2024 15:28:33 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org;
	dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="udZ46Thb"
Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id AC89E1E880;
	Thu,  6 Jun 2024 15:28:31 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201
ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
	t=1717687712; cv=none; b=E91URKEMSukNVfjZPWIf8Kz3HBPToNFn48Mbmd22/dQ7ch5K1uoa2qjMdsa5dvIvJE6tJd497Ovs1nQI3ou0JCD1dFRs8w0oRsKZumUVG+PFwvgBtYSaKs4FV1cvu2Dq5tIJh6zj2h3Be3kzonGQCtjN+pgMBemMuEma9InPX6A=
ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org;
	s=arc-20240116; t=1717687712; c=relaxed/simple;
	bh=y3sWSfcVKzKXwM82BXYfEwhQOQElKVzrlpuOvAbuufw=;
	h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References:
	 MIME-Version:Content-Type; b=gXMS030TcBO8K6HoKqQE3JpomcC2LHo5ZM88CEIZyTyUAqczeaoriwbg7pyxZKH9jqV1A1DtaIwewNlflnsxeLcDnEcZg6R124Fwm9qjE+Q1+pGwmuv+zvJSDHPwJD8jOQXJ1mIhUzT84jWqCXoeeXX5/gDCHTdTkp9++unYK84=
ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=udZ46Thb; arc=none smtp.client-ip=10.30.226.201
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4BB9DC2BD10;
	Thu,  6 Jun 2024 15:28:31 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1717687711;
	bh=y3sWSfcVKzKXwM82BXYfEwhQOQElKVzrlpuOvAbuufw=;
	h=Date:From:To:Cc:Subject:In-Reply-To:References:From;
	b=udZ46Thb5WE0MeVGRuLkcnO36E4gxuFkIgmEiESX8Qp6j6+nIZzVbN2xG4kv15Rov
	 oAX6d5DNjOsSFHI9156WEkbFv1ZWMKW79fgbioPlvAEKAc8L1sglHDOOfI7tjiVQvh
	 ANycJw9HUGAJEl/8WECUio3WkIDWDIvYJBdf7lagWEoRfA0A8zr5LE1A45GZKpreyy
	 4bbbaZMQosaZAtmyVXf0LiHKWHlY2iqacEiB3BJK4sBIa0DkW03WLYVxF8P3tOPOGF
	 9WNFtdfM8gNHGiBugTcxt3NffTWlQF9NarlkCWxlSAidjlOPNqtLu/kz7S2EZoiN93
	 HGlEJT2GHIUMg==
Date: Thu, 6 Jun 2024 08:28:30 -0700
From: Jakub Kicinski <kuba@kernel.org>
To: Andrew Lunn <andrew@lunn.ch>
Cc: "=?UTF-8?B?Q3PDs2vDoXMsXA==?=" Bence <csokas.bence@prolan.hu>, Russell
 King <rmk+kernel@armlinux.org.uk>, netdev@vger.kernel.org,
 linux-kernel@vger.kernel.org, Russell King <linux@armlinux.org.uk>, Heiner
 Kallweit <hkallweit1@gmail.com>, "David S. Miller" <davem@davemloft.net>,
 Eric Dumazet <edumazet@google.com>, Paolo Abeni <pabeni@redhat.com>
Subject: Re: [PATCH] net: sfp: Always call `sfp_sm_mod_remove()` on remove
Message-ID: <20240606082830.30e3a294@kernel.org>
In-Reply-To: <24a48e5a-efb3-4066-af6f-69f4a254b9c3@lunn.ch>
References: <20240605084251.63502-1-csokas.bence@prolan.hu>
	<24a48e5a-efb3-4066-af6f-69f4a254b9c3@lunn.ch>
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: quoted-printable

On Thu, 6 Jun 2024 17:21:45 +0200 Andrew Lunn wrote:
> I was expecting Russell to review this. Maybe he missed it.

While it's fresh in your mind - does it look like a fix to you?
=46rom a quick look - we're failing to unregister a device?