Received-SPF: pass (google.com: domain of linux-kernel+bounces-204618-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Date: Thu, 6 Jun 2024 17:54:18 +0200
From: Andrew Lunn <andrew@lunn.ch>
To: MD Danish Anwar <danishanwar@ti.com>
Cc: Wolfram Sang <wsa+renesas@sang-engineering.com>,
	Diogo Ivo <diogo.ivo@siemens.com>,
	Roger Quadros <rogerq@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Jakub Kicinski <kuba@kernel.org>,
	Eric Dumazet <edumazet@google.com>,
	"David S. Miller" <davem@davemloft.net>,
	linux-kernel@vger.kernel.org, netdev@vger.kernel.org, srk@ti.com,
	Vignesh Raghavendra <vigneshr@ti.com>,
	kernel test robot <lkp@intel.com>,
	Thorsten Leemhuis <linux@leemhuis.info>
Subject: Re: [PATCH net-next v2] net: ti: icssg-prueth: Split out common
 object into module
Message-ID: <66b917d6-3b72-41c5-9e30-e87cf5505729@lunn.ch>
References: <20240606073639.3299252-1-danishanwar@ti.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240606073639.3299252-1-danishanwar@ti.com>

> +EXPORT_SYMBOL_GPL(icssg_class_set_mac_addr);
> +EXPORT_SYMBOL_GPL(icssg_class_disable);
> +EXPORT_SYMBOL_GPL(icssg_class_default);
> +EXPORT_SYMBOL_GPL(icssg_class_promiscuous_sr1);
> +EXPORT_SYMBOL_GPL(icssg_class_add_mcast_sr1);
> +EXPORT_SYMBOL_GPL(icssg_ft1_set_mac_addr);
> +EXPORT_SYMBOL_GPL(prueth_cleanup_rx_chns);
> +EXPORT_SYMBOL_GPL(prueth_cleanup_tx_chns);
> +EXPORT_SYMBOL_GPL(prueth_ndev_del_tx_napi);
> +EXPORT_SYMBOL_GPL(prueth_xmit_free);
> +EXPORT_SYMBOL_GPL(prueth_ndev_add_tx_napi);
> +EXPORT_SYMBOL_GPL(prueth_init_tx_chns);
> +EXPORT_SYMBOL_GPL(prueth_init_rx_chns);
> +EXPORT_SYMBOL_GPL(prueth_dma_rx_push);
> +EXPORT_SYMBOL_GPL(icssg_ts_to_ns);
> +EXPORT_SYMBOL_GPL(emac_ndo_start_xmit);
> +EXPORT_SYMBOL_GPL(prueth_rx_irq);
> +EXPORT_SYMBOL_GPL(prueth_emac_stop);
> +EXPORT_SYMBOL_GPL(prueth_cleanup_tx_ts);
> +EXPORT_SYMBOL_GPL(emac_napi_rx_poll);
> +EXPORT_SYMBOL_GPL(prueth_prepare_rx_chan);
> +EXPORT_SYMBOL_GPL(prueth_reset_tx_chan);
> +EXPORT_SYMBOL_GPL(prueth_reset_rx_chan);
> +EXPORT_SYMBOL_GPL(emac_ndo_tx_timeout);
> +EXPORT_SYMBOL_GPL(emac_ndo_ioctl);
> +EXPORT_SYMBOL_GPL(emac_ndo_get_stats64);
> +EXPORT_SYMBOL_GPL(emac_ndo_get_phys_port_name);
> +EXPORT_SYMBOL_GPL(prueth_node_port);
> +EXPORT_SYMBOL_GPL(prueth_node_mac);
> +EXPORT_SYMBOL_GPL(prueth_netdev_exit);
> +EXPORT_SYMBOL_GPL(prueth_get_cores);
> +EXPORT_SYMBOL_GPL(prueth_put_cores);
> +EXPORT_SYMBOL_GPL(prueth_dev_pm_ops);
> +EXPORT_SYMBOL_GPL(icssg_config_ipg);
> +EXPORT_SYMBOL_GPL(icssg_config);
> +EXPORT_SYMBOL_GPL(emac_set_port_state);
> +EXPORT_SYMBOL_GPL(icssg_config_half_duplex);
> +EXPORT_SYMBOL_GPL(icssg_config_set_speed);
> +EXPORT_SYMBOL_GPL(icssg_send_fdb_msg);
> +EXPORT_SYMBOL_GPL(icssg_fdb_add_del);
> +EXPORT_SYMBOL_GPL(icssg_fdb_lookup);
> +EXPORT_SYMBOL_GPL(icssg_vtbl_modify);
> +EXPORT_SYMBOL_GPL(icssg_get_pvid);
> +EXPORT_SYMBOL_GPL(icssg_set_pvid);
> +EXPORT_SYMBOL_GPL(icssg_ethtool_ops);
> +EXPORT_SYMBOL_GPL(icssg_mii_update_mtu);
> +EXPORT_SYMBOL_GPL(icssg_update_rgmii_cfg);
> +EXPORT_SYMBOL_GPL(icssg_rgmii_get_speed);
> +EXPORT_SYMBOL_GPL(icssg_rgmii_get_fullduplex);
> +EXPORT_SYMBOL_GPL(icssg_queue_pop);
> +EXPORT_SYMBOL_GPL(icssg_queue_push);
> +EXPORT_SYMBOL_GPL(emac_stats_work_handler);

Please could you clean up the namespace a little. icssg_ and prueth_
are O.K, but we also have arc/emac_rockchip.c, allwinner/sun4i-emac.c,
ibm/emac/, and qualcomm/emac/ using the emac_ prefix.

Thanks
    Andrew

---
pw-bot: cr