Received-SPF: pass (google.com: domain of linux-kernel+bounces-204601-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Message-ID: <a11a3cf2-5e25-471f-ad74-4834d3540e1d@siemens.com>
Date: Thu, 6 Jun 2024 16:47:04 +0100
Precedence: bulk
MIME-Version: 1.0
Subject: Re: [PATCH] usb: typec: ucsi: treat get_pdos not supported condition
 as info instead of error
To: Mark Pearson <mpearson-lenovo@squebb.ca>,
 Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Cc: Heikki Krogerus <heikki.krogerus@linux.intel.com>,
 Greg KH <gregkh@linuxfoundation.org>, linux-usb@vger.kernel.org,
 linux-kernel@vger.kernel.org
References: <mpearson-lenovo@squebb.ca>
 <20240604194056.16625-1-mpearson-lenovo@squebb.ca>
 <2midmmssv2i3plvtc2hajar6alfvggpnbvgpmldspelxsnjvcl@qiblhwat6n3p>
 <a517bb13-9772-49f9-b75c-8fa4d98b2ae9@app.fastmail.com>
Content-Language: en-US
From: Diogo Ivo <diogo.ivo@siemens.com>
In-Reply-To: <a517bb13-9772-49f9-b75c-8fa4d98b2ae9@app.fastmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Feedback-ID: 519:519-1320519:519-21489:flowmailer

Hi Mark,

On 6/5/24 6:09 PM, Mark Pearson wrote:
> 
> @@ -645,9 +645,13 @@ static int ucsi_read_pdos(struct ucsi_connector *con,
>   static int ucsi_get_pdos(struct ucsi_connector *con, enum typec_role role,
>                           int is_partner, u32 *pdos)
>   {
> +       struct ucsi *ucsi = con->ucsi;
>          u8 num_pdos;
>          int ret;
>   
> +       if (!(ucsi->cap.features & UCSI_CAP_PDO_DETAILS))
> +               return 0;
> +
>          /* UCSI max payload means only getting at most 4 PDOs at a time */
>          ret = ucsi_read_pdos(con, role, is_partner, pdos, 0, UCSI_MAX_PDOS);
> 

Seems good to me too.

Best regards,
Diogo