Received-SPF: pass (google.com: domain of linux-kernel+bounces-204715-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Message-ID: <b0b3b7f4-306c-4091-bf19-bf16d25c407c@intel.com>
Date: Thu, 6 Jun 2024 09:42:18 -0700
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] ntb: intel: Fix using link status DB's
To: n.shubin@yadro.com, Jon Mason <jdmason@kudzu.us>,
 Allen Hubbe <allenbh@gmail.com>
Cc: Nikita Shubin <nikita.shubin@maquefel.me>, ntb@lists.linux.dev,
 linux-kernel@vger.kernel.org, linux@yadro.com
References: <20240606-ntb_intel_db_fix-v1-1-ba9033aea289@yadro.com>
Content-Language: en-US
From: Dave Jiang <dave.jiang@intel.com>
In-Reply-To: <20240606-ntb_intel_db_fix-v1-1-ba9033aea289@yadro.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit


On 6/6/24 1:15 AM, Nikita Shubin via B4 Relay wrote:
> From: Nikita Shubin <n.shubin@yadro.com>
> 
> Make sure we are not using DB's which were remapped for link status.
> 
> Fixes: f6e51c354b60 ("ntb: intel: split out the gen3 code")
> Signed-off-by: Nikita Shubin <n.shubin@yadro.com>

Thank you for the patch.

Reviewed-by: Dave Jiang <dave.jiang@intel.com>

> ---
> Hello Dave, sending a patch as planned.
> 
> Thank you for looking into this!
> 
> Link: https://lore.kernel.org/all/686c55cc658564e8f37147e0d6d5ab62bb8372af.camel@maquefel.me/
> ---
>  drivers/ntb/hw/intel/ntb_hw_gen3.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/ntb/hw/intel/ntb_hw_gen3.c b/drivers/ntb/hw/intel/ntb_hw_gen3.c
> index ffcfc3e02c35..a5aa96a31f4a 100644
> --- a/drivers/ntb/hw/intel/ntb_hw_gen3.c
> +++ b/drivers/ntb/hw/intel/ntb_hw_gen3.c
> @@ -215,6 +215,9 @@ static int gen3_init_ntb(struct intel_ntb_dev *ndev)
>  	}
>  
>  	ndev->db_valid_mask = BIT_ULL(ndev->db_count) - 1;
> +	/* Make sure we are not using DB's used for link status */
> +	if (ndev->hwerr_flags & NTB_HWERR_MSIX_VECTOR32_BAD)
> +		ndev->db_valid_mask &= ~ndev->db_link_mask;
>  
>  	ndev->reg->db_iowrite(ndev->db_valid_mask,
>  			      ndev->self_mmio +
> 
> ---
> base-commit: 2df0193e62cf887f373995fb8a91068562784adc
> change-id: 20240606-ntb_intel_db_fix-036299fabc48
> 
> Best regards,