Received-SPF: pass (google.com: domain of linux-kernel+bounces-204716-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
From: Vamsi Krishna Attunuru <vattunuru@marvell.com>
To: Greg KH <gregkh@linuxfoundation.org>
CC: Jerin Jacob <jerinj@marvell.com>, Srujana Challa <schalla@marvell.com>,
        "arnd@arndb.de" <arnd@arndb.de>,
        "linux-kernel@vger.kernel.org"
	<linux-kernel@vger.kernel.org>
Subject: RE: [EXTERNAL] Re: [PATCH v7 1/1] misc: mrvl-cn10k-dpi: add Octeon
 CN10K DPI administrative driver
Thread-Topic: [EXTERNAL] Re: [PATCH v7 1/1] misc: mrvl-cn10k-dpi: add Octeon
 CN10K DPI administrative driver
Thread-Index: AQHaqqXUeJduCBvv+0e3+QVunpJsgbG32TAAgAAF9zCAAyjT4A==
Date: Thu, 6 Jun 2024 16:42:34 +0000
Message-ID: 
 <MW4PR18MB524422223AC92181942C75E2A6FA2@MW4PR18MB5244.namprd18.prod.outlook.com>
References: <2024042950-refurbish-duckbill-77b4@gregkh>
 <20240520110630.2568767-1-vattunuru@marvell.com>
 <2024060412-amulet-unflawed-f37a@gregkh>
 <SJ0PR18MB52462AA2A9F15103D5198CC5A6F82@SJ0PR18MB5246.namprd18.prod.outlook.com>
In-Reply-To: 
 <SJ0PR18MB52462AA2A9F15103D5198CC5A6F82@SJ0PR18MB5246.namprd18.prod.outlook.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?us-ascii?Q?GWKI5sQtQymulZ3gs7SRmdzh63fUcV7TZt9vDN3wQJUdt0PRVD0Rm4LCbd8z?=
 =?us-ascii?Q?CJM+BIm3WOaSn8CUB1RuaKZkkGj+mPOKX12Ly0GuqJDV5ER5rMkHXjTRGWlY?=
 =?us-ascii?Q?ofnuHLHVfsR9ReAS8U4JYW9l0DCgGJy70IfBf5o6q9xv7OxXpykXtg6VYZLv?=
 =?us-ascii?Q?K9y6PzU6dPCupl/hVcAtgcrnlAH2AS5K0IkrOOnWxX38Wa16Zq0kcRC1cp2a?=
 =?us-ascii?Q?C5mGqehcTtm5mRPbInh3swBjLwfXsvuEUjn7qb0LMq1RaE4djsngfLD7iy1s?=
 =?us-ascii?Q?jbGJPfYpiJc7EQJM5zBd1SRIQJl4D+XZvZUyrNAmkZXb9zYc+D654VCA7uy7?=
 =?us-ascii?Q?Jr42rd+O0/txoJXRWWENEQTDdF3SYFRBvUPWIdEOAzG2nDyt4VgrpoPSySFS?=
 =?us-ascii?Q?9+dBEZ2cDM9rX2AHdmT5tKlgTiNOr/XTbfvLDPD3ScH3qhp0X8VHhispA6Sq?=
 =?us-ascii?Q?zzeupOCuBl+xWORDJVsIHDJ9T1rDY0Wo/6ihtDT0O/+Y9+WYi3b48x6LTfPw?=
 =?us-ascii?Q?B6gUkWc5lfNLxZzjwSxYERTpDkRSfc4YKXX0A8ROajYM6QCHMQCOfYcmD6dz?=
 =?us-ascii?Q?kE5KB7ghJgdoXxLi/QGYGznBnp/nMKku5v2dvizNDXHCoi5VbAGTVS1goCev?=
 =?us-ascii?Q?/gTDSZZfhe6ysbu8AhLWdS5z+7RlPzdOzcRQq5VIN13kvDJO4Se0SW67gi1T?=
 =?us-ascii?Q?ZTk7u2ygNbE6IOserZcF1sc5oiY1Usxuo0epX6ZPJM/w/l8IZOtvsjSPwojk?=
 =?us-ascii?Q?VFIBt+PXIhuDr9cNsjdnu7vR1pdGychW4vScbV+z7tUKt5h50UeavNFAWhs1?=
 =?us-ascii?Q?McG9dNwHtAlLBPQZWU181J4d0ivhwFZb3N2BknUHek3lq5ERUBr1STG53xpI?=
 =?us-ascii?Q?QNxKBMRry5rOb9DqlNnbLBN8KLzHchAf/nkukl6a217Ixvqn49lQBCYzhJmq?=
 =?us-ascii?Q?6fbS1vQsmOLWKxdxX2AGK3YRA+2E8vLBEUmkT2dilDceE4JSIuZhdoSEvhL/?=
 =?us-ascii?Q?KiWU8lz0Skkn1wSJJ/D+qD8KfwhqkYQL/xGaQRGDhCuv8AZYCu//6+GuoFvC?=
 =?us-ascii?Q?295M9PNyXQwOoTNb0niMKJQN7JW2Ae1xs1hRv+MoloNL2BEG+kA+fDMRPrwz?=
 =?us-ascii?Q?oGt5524cJoJaoJ+miRxKcvyvfM+FBO31o7mNDSlTQlzoo9nDHadgDGpTFka2?=
 =?us-ascii?Q?l2BTETHfx9b0yArON2Xt9zWI62q4dM7swSyg6ELywHLGFgMvNK7o2F91DXtj?=
 =?us-ascii?Q?PKfojSC7KIOBtzK23LjBSUOC7soICWn7j3mSjxRr4q+zTpq6gF+ia03Wcec8?=
 =?us-ascii?Q?+eSQAqwduYjQT+vWxqED5A8UcTwDBdDGqAuVz2KV2e+XYhuCo/A/2uK8Jny4?=
 =?us-ascii?Q?0f/w4FY1SCGKW3rTc5h8Bbmv5BPDGKfhBh7dE0HSKYbqO6XhKw3RbjgWTpaa?=
 =?us-ascii?Q?V8nb9z3Ik+We7hANjZG6CGUfzTJEaM9rYAG7mLyCTmPMe/j4bQbe/ArBWIEI?=
 =?us-ascii?Q?lchf0bCXUHBnUA7lWPXla2zl7084rq1BFYzdOWmneADFUxT4SnAed3pWJzhT?=
 =?us-ascii?Q?TIoJ1N9uAUymfZgCyrVpXXyolpdz9pvSUQgB5hHv?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-OriginatorOrg: marvell.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: MW4PR18MB5244.namprd18.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c63848c7-4b18-44b4-b742-08dc8647aae4
X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Jun 2024 16:42:34.7067
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: G86LyoXbBSafxe9VkI5Ly8GhICU+7jA5kXNYOC+IRflLVpwmoK+lGQtspUmL3JqBSZ45F8KXafy8Uk4Z7Sa9mA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR18MB4776
X-Proofpoint-GUID: 5jzwqnbQS126sLH8m8xOWvTqT728KiYT
X-Proofpoint-ORIG-GUID: 5jzwqnbQS126sLH8m8xOWvTqT728KiYT
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.28.16
 definitions=2024-06-06_13,2024-06-06_02,2024-05-17_01


> -----Original Message-----
> From: Vamsi Krishna Attunuru
> Sent: Tuesday, June 4, 2024 9:51 PM
> To: 'Greg KH' <gregkh@linuxfoundation.org>
> Cc: Jerin Jacob <jerinj@marvell.com>; Srujana Challa <schalla@marvell.com=
>;
> arnd@arndb.de; linux-kernel@vger.kernel.org
> Subject: RE: [EXTERNAL] Re: [PATCH v7 1/1] misc: mrvl-cn10k-dpi: add Octe=
on
> CN10K DPI administrative driver
>=20
>=20
>=20
> > -----Original Message-----
> > From: Greg KH <gregkh@linuxfoundation.org>
> > Sent: Tuesday, June 4, 2024 9:23 PM
> > To: Vamsi Krishna Attunuru <vattunuru@marvell.com>
> > Cc: Jerin Jacob <jerinj@marvell.com>; Srujana Challa
> > <schalla@marvell.com>; arnd@arndb.de; linux-kernel@vger.kernel.org
> > Subject: [EXTERNAL] Re: [PATCH v7 1/1] misc: mrvl-cn10k-dpi: add
> > Octeon CN10K DPI administrative driver
> >
> > Prioritize security for external emails: Confirm sender and content
> > safety before clicking links or opening attachments
> >
> > ----------------------------------------------------------------------
> > On Mon, May 20, 2024 at 04:06:30AM -0700, Vamsi Attunuru wrote:
> > > +union dpi_mbox_message {
> > > +	u64 word[2];
> > > +	struct {
> > > +#if defined(__BIG_ENDIAN_BITFIELD)
> > > +		/* SSO PF function */
> > > +		u64 sso_pf_func  :16;
> > > +		/* Aura of the command buffer */
> > > +		u64 aura         :20;
> > > +		/* Command buffer size in 8-byte words */
> > > +		u64 csize        :16;
> > > +		/* Command code */
> > > +		u64 cmd          :4;
> > > +		/* VF ID to configure */
> > > +		u64 vfid         :8;
> > > +		/* Reserved for future use */
> > > +		u64 rsvd_85_127  :40;
> > > +		/* Work queue completion status byte offset */
> > > +		u64 wqecsoff     :7;
> > > +		/* Work queue completion status enable */
> > > +		u64 wqecs        :1;
> > > +		/* NPA PF function */
> > > +		u64 npa_pf_func  :16;
> > > +#else
> > > +		/* VF ID to configure */
> > > +		u64 vfid         :8;
> > > +		/* Command code */
> > > +		u64 cmd          :4;
> > > +		/* Command buffer size in 8-byte words */
> > > +		u64 csize        :16;
> > > +		/* Aura of the command buffer */
> > > +		u64 aura         :20;
> > > +		/* SSO PF function */
> > > +		u64 sso_pf_func  :16;
> > > +		/* NPA PF function */
> > > +		u64 npa_pf_func  :16;
> > > +		/* Work queue completion status enable */
> > > +		u64 wqecs        :1;
> > > +		/* Work queue completion status byte offset */
> > > +		u64 wqecsoff     :7;
> > > +		/* Reserved for future use */
> > > +		u64 rsvd_85_127  :40;
> > > +#endif
> > > +	};
> > > +};
> >
> > The ifdef is cute, but not correct, sorry.  Please use bit shifts to
> > handle this properly without any #ifdef needed at all.
> >
> Ack, will fix it next version. Thanks for the suggestion.
>=20

Hi Greg, the ARM64 cores on the Octeon CN10K hardware platform always run i=
n LE mode and this CN10K DPI PF driver is only supported on Octeon CN10K pl=
atforms as the DPI PF device is an onboard PCIe device. Can I remove the BE=
 format and only define the LE format for the dpi_mbox_message structure?, =
other HW device drivers of Octeon CN10K platform also only support LE forma=
t.

Regards
Vamsi

> >
> >
> >
> > > +
> > > +static inline void dpi_reg_write(struct dpipf *dpi, u64 offset, u64
> > > +val) {
> > > +	writeq(val, dpi->reg_base + offset);
> >
> > No read needed after a write to ensure the write made it to the
> > hardware properly?
>=20
> Yes, as it's an onboard PCIe device, writes will happen properly. I will =
modify
> it as write followed by a write barrier to avoid any reordering.
>=20
> Thanks
> Vamsi
> >
> > thanks,
> >
> > greg k-h