Received-SPF: pass (google.com: domain of linux-kernel+bounces-204631-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Message-ID: <7ad9261c-115b-451d-9b93-832f98124116@intel.com>
Date: Thu, 6 Jun 2024 08:59:15 -0700
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] acpi,hmat: Use ACCESS_COORDINATE_CPU when appropriate
To: Huang Ying <ying.huang@intel.com>, "Rafael J . Wysocki"
 <rafael@kernel.org>
Cc: linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org,
 Jonathan Cameron <Jonathan.Cameron@huawei.com>,
 Dan Williams <dan.j.williams@intel.com>, Bharata B Rao <bharata@amd.com>,
 Alistair Popple <apopple@nvidia.com>,
 "Aneesh Kumar K . V" <aneesh.kumar@linux.ibm.com>
References: <20240606022845.189710-1-ying.huang@intel.com>
Content-Language: en-US
From: Dave Jiang <dave.jiang@intel.com>
In-Reply-To: <20240606022845.189710-1-ying.huang@intel.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit


On 6/5/24 7:28 PM, Huang Ying wrote:
> To improve the readability of the code via replacing the magic number
> "1" with ACCESS_COORDINATE_CPU when appropriate.  No functionality
> change.
> 
> Signed-off-by: "Huang, Ying" <ying.huang@intel.com>
> Cc: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> Cc: Dave Jiang <dave.jiang@intel.com>
> Cc: Dan Williams <dan.j.williams@intel.com>
> Cc: Bharata B Rao <bharata@amd.com>
> Cc: Alistair Popple <apopple@nvidia.com>
> Cc: Aneesh Kumar K.V <aneesh.kumar@linux.ibm.com>

Thanks for this. Looks like I missed a few.

Reviewed-by: Dave Jiang <dave.jiang@intel.com>

> ---
>  drivers/acpi/numa/hmat.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/acpi/numa/hmat.c b/drivers/acpi/numa/hmat.c
> index 2c8ccc91ebe6..febd9e51350b 100644
> --- a/drivers/acpi/numa/hmat.c
> +++ b/drivers/acpi/numa/hmat.c
> @@ -408,7 +408,7 @@ static __init void hmat_update_target(unsigned int tgt_pxm, unsigned int init_px
>  	if (target && target->processor_pxm == init_pxm) {
>  		hmat_update_target_access(target, type, value,
>  					  ACCESS_COORDINATE_LOCAL);
> -		/* If the node has a CPU, update access 1 */
> +		/* If the node has a CPU, update access ACCESS_COORDINATE_CPU */
>  		if (node_state(pxm_to_node(init_pxm), N_CPU))
>  			hmat_update_target_access(target, type, value,
>  						  ACCESS_COORDINATE_CPU);
> @@ -948,7 +948,7 @@ static int hmat_set_default_dram_perf(void)
>  		target = find_mem_target(pxm);
>  		if (!target)
>  			continue;
> -		attrs = &target->coord[1];
> +		attrs = &target->coord[ACCESS_COORDINATE_CPU];
>  		rc = mt_set_default_dram_perf(nid, attrs, "ACPI HMAT");
>  		if (rc)
>  			return rc;
> @@ -975,7 +975,7 @@ static int hmat_calculate_adistance(struct notifier_block *self,
>  	hmat_update_target_attrs(target, p_nodes, ACCESS_COORDINATE_CPU);
>  	mutex_unlock(&target_lock);
>  
> -	perf = &target->coord[1];
> +	perf = &target->coord[ACCESS_COORDINATE_CPU];
>  
>  	if (mt_perf_to_adistance(perf, adist))
>  		return NOTIFY_OK;