Received-SPF: pass (google.com: domain of linux-kernel+bounces-204762-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Thu, 6 Jun 2024 12:02:36 -0500
From: Lucas De Marchi <lucas.demarchi@intel.com>
To: <intel-xe@lists.freedesktop.org>
CC: Ilia Levi <illevi@habana.ai>, Masahiro Yamada <masahiroy@kernel.org>,
	Nathan Chancellor <nathan@kernel.org>, Nicolas Schier <nicolas@fjasle.eu>,
	<linux-kbuild@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: =?utf-8?B?4pyXIENJLkhvb2tz?= =?utf-8?Q?=3A?= failure for
 drm/xe/irq: remove xe_irq_shutdown
Message-ID: <efbt3hl22g73r3372agpzowfejrpxzvaiqu2ysscntwa6dtioe@2ao55jz262rs>
References: <20240606124705.822451-1-illevi@habana.ai>
 <171767982099.22567.196132369501507254@a6498e030952>
Content-Type: text/plain; charset="us-ascii"; format=flowed
Content-Disposition: inline
In-Reply-To: <171767982099.22567.196132369501507254@a6498e030952>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?W1cV//WOkGnGeL3FQdbIFUMbZzbcL+Gl4DsAOkgNDWVj4oGjf3Y1YqNFGRcY?=
 =?us-ascii?Q?dD7VPbPm3oGZJLWVElQPDfGz+yzPdHsMFeuecLDmvMgb6TCqRldrN2FkP+V6?=
 =?us-ascii?Q?8+/RxYuYdHwng6rcCmNIuE1F6ny0Mfkuf+vuKwoyDRxyr0W/LTtE8uta7ZPz?=
 =?us-ascii?Q?PGyfXCqZjbrIQXxvrQXu7BJwMjM//8axuCScdti6SKgb1iDF8dTJF3ZPngsA?=
 =?us-ascii?Q?x3nFhFHLd/o+3fgqDXPjw3h5ZKXOiv7vD0E+u0kVdEz5wUdSkY1cpife6DGS?=
 =?us-ascii?Q?BaTyQhKCLV8D2y1+h/swIuikxCDOMhk5ZlLETXmVoB7eaNud+yzPlayhjwdg?=
 =?us-ascii?Q?uOLkDq2A15jrpnrCYHdAqtRLAu7tuJwLD0+cwb6FlN94JHnW9bKwnBuS67sn?=
 =?us-ascii?Q?RkInQuFpRmMegS7VqtL7ntRSqENLmoS4X/ZWJvAJeGYyy+ZRz90XkC95PJ2J?=
 =?us-ascii?Q?DooJDCniOd5JYEcEboL4Ne2yz/ttqliF2KpB6iVUd9mTn8dRMPao+fzE0xZJ?=
 =?us-ascii?Q?xAEzPtJGOuBasmBTUpuBBTnc67F09JyAi1CSybOl7dgTT3C1InyJcxfTgIpu?=
 =?us-ascii?Q?GPe7inT788LPY6a8/9n7rfUIPYA71TpBVKBgX2HkGSK4HAlGrs3i4Vb3mE55?=
 =?us-ascii?Q?zXpSh2kGFq7O1DwKt6cA41V0ElCYqrA8YdgsZxO9AOK4YYqrkFbgFW86nj3h?=
 =?us-ascii?Q?jYxkb3WTF+q7ZJAMNQrm57ppZxw061JQRSfBEAo27/C2PvjaX6F5bloHE+jx?=
 =?us-ascii?Q?bNp65vuegWkDiWf0aRvb/imRm++XOyfONrQWSYuad0UIS3wEvz86zSc14xUO?=
 =?us-ascii?Q?DyPPpm464fPawA4xs4yrbo1zL57a5fp0OQHCv1a3qevbcuTc4W21c4F6jxch?=
 =?us-ascii?Q?BWIskXlPs3VmwdgqFnyqE7jmroVOKtz/Mf5D18IUy8BFaGhaFhbprFFAkct5?=
 =?us-ascii?Q?8K6CtJPX5gQkS7I9jIBn6N7ZPXb9gKXx2N2JX4ExW7KW2obE5bQwu+BgLMq8?=
 =?us-ascii?Q?RmWhzG3hlUNRGkx40ZVvzs5i0H2UyUBdXIjdUXor6+CjMzlGy1s0dSZJWxrq?=
 =?us-ascii?Q?VEX3JBixH6jHzBmBes44z+6r68VhWDLHQ0/1Z3hiZfHCbMltIkfBX9X61KFS?=
 =?us-ascii?Q?OMkidz3aVDbkwhEiUSx7cJtTGb9WYI14JXh6lwvlboyyw8dgBe12O+es3YDO?=
 =?us-ascii?Q?N5M3hi+EXJg8C7OM75FXXnu3X6bIINkG1YR9j3ajzqiXthJGKb7/4g9wnVR4?=
 =?us-ascii?Q?SbSj5zW0DkcBH+oeCms3aJPXF+RxHkKGXOp75YXNyd6g46IIKBGomB+Clb4s?=
 =?us-ascii?Q?L1c4ab0HEBw3YmKuULHRgLy5qQ2QjZh8xDi3vuSqxLTZcWq3ObV7jFzvgOTW?=
 =?us-ascii?Q?QSOcJd8x0QW0KA/v/i+ozdv6YeA8BoXOci8w8bPjSg1Q7xtSNIrhhW/1dYqG?=
 =?us-ascii?Q?o/+//oxhenR+TNxbWmXr+WM2GWUMMbPlwHfhSC0XFmfEY+0P7Fx5AO/XuLwM?=
 =?us-ascii?Q?TG1qniZR3+sOtDnyv2whN2K618+WMvbuAaoAg2Cy0TFNCT/xokVSi2mcajpP?=
 =?us-ascii?Q?qu+rC67z+Y4B1JvweCf/o558bHl/LhI9jCURe1LuIR6EpXOOfvhZEOpIdj3Z?=
 =?us-ascii?Q?lw=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 01de1142-8225-4be6-8594-08dc864a78fa
X-MS-Exchange-CrossTenant-AuthSource: CY5PR11MB6139.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Jun 2024 17:02:39.7380
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: iCS6vZXlFVpj4/ufilyYAVVjJkI6tDJa4YMmm74coUJoC0syIR8QDZMYx16h8IF2kWX1eX7+Gy8/PzMctU+cmoUOuou73Cl8jxEGU670vKI=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR11MB5186
X-OriginatorOrg: intel.com

Cc'ing kbuild + lkml and maintainers.

On Thu, Jun 06, 2024 at 01:17:00PM GMT, Patchwork wrote:
>== Series Details ==
>
>Series: drm/xe/irq: remove xe_irq_shutdown
>URL   : https://patchwork.freedesktop.org/series/134565/
>State : failure
>
>== Summary ==
>
>run-parts: executing /workspace/ci/hooks/00-showenv
>+ export
>+ grep -Ei '(^|\W)CI_'
>declare -x CI_KERNEL_BUILD_DIR="/workspace/kernel/build64-default"
>declare -x CI_KERNEL_SRC_DIR="/workspace/kernel"
>declare -x CI_TOOLS_SRC_DIR="/workspace/ci"
>declare -x CI_WORKSPACE_DIR="/workspace"
>run-parts: executing /workspace/ci/hooks/10-build-W1
>+ SRC_DIR=/workspace/kernel
>+ RESTORE_DISPLAY_CONFIG=0
>+ '[' -n /workspace/kernel/build64-default ']'
>+ BUILD_DIR=/workspace/kernel/build64-default
>+ cd /workspace/kernel
>++ nproc
>+ make -j48 O=/workspace/kernel/build64-default modules_prepare
>make[1]: Entering directory '/workspace/kernel/build64-default'
>  GEN     Makefile
>  UPD     include/generated/compile.h
>  UPD     include/config/kernel.release
>mkdir -p /workspace/kernel/build64-default/tools/objtool && make O=/workspace/kernel/build64-default subdir=tools/objtool --no-print-directory -C objtool
>  UPD     include/generated/utsrelease.h
>  HOSTCC  /workspace/kernel/build64-default/tools/objtool/fixdep.o
>  CALL    ../scripts/checksyscalls.sh
>  HOSTLD  /workspace/kernel/build64-default/tools/objtool/fixdep-in.o
>  LINK    /workspace/kernel/build64-default/tools/objtool/fixdep
>  INSTALL libsubcmd_headers
>  CC      /workspace/kernel/build64-default/tools/objtool/libsubcmd/exec-cmd.o
>  CC      /workspace/kernel/build64-default/tools/objtool/libsubcmd/help.o
>  CC      /workspace/kernel/build64-default/tools/objtool/libsubcmd/pager.o
>  CC      /workspace/kernel/build64-default/tools/objtool/libsubcmd/parse-options.o
>  CC      /workspace/kernel/build64-default/tools/objtool/libsubcmd/run-command.o
>  CC      /workspace/kernel/build64-default/tools/objtool/libsubcmd/sigchain.o
>  CC      /workspace/kernel/build64-default/tools/objtool/libsubcmd/subcmd-config.o
>  LD      /workspace/kernel/build64-default/tools/objtool/libsubcmd/libsubcmd-in.o
>  AR      /workspace/kernel/build64-default/tools/objtool/libsubcmd/libsubcmd.a
>  CC      /workspace/kernel/build64-default/tools/objtool/weak.o
>  CC      /workspace/kernel/build64-default/tools/objtool/check.o
>  CC      /workspace/kernel/build64-default/tools/objtool/special.o
>  CC      /workspace/kernel/build64-default/tools/objtool/builtin-check.o
>  CC      /workspace/kernel/build64-default/tools/objtool/elf.o
>  CC      /workspace/kernel/build64-default/tools/objtool/objtool.o
>  CC      /workspace/kernel/build64-default/tools/objtool/orc_gen.o
>  CC      /workspace/kernel/build64-default/tools/objtool/orc_dump.o
>  CC      /workspace/kernel/build64-default/tools/objtool/libstring.o
>  CC      /workspace/kernel/build64-default/tools/objtool/libctype.o
>  CC      /workspace/kernel/build64-default/tools/objtool/str_error_r.o
>  CC      /workspace/kernel/build64-default/tools/objtool/librbtree.o
>  CC      /workspace/kernel/build64-default/tools/objtool/arch/x86/special.o
>  CC      /workspace/kernel/build64-default/tools/objtool/arch/x86/decode.o
>  CC      /workspace/kernel/build64-default/tools/objtool/arch/x86/orc.o
>  LD      /workspace/kernel/build64-default/tools/objtool/arch/x86/objtool-in.o
>  LD      /workspace/kernel/build64-default/tools/objtool/objtool-in.o
>  LINK    /workspace/kernel/build64-default/tools/objtool/objtool
>make[1]: Leaving directory '/workspace/kernel/build64-default'
>++ nproc
>+ make -j48 O=/workspace/kernel/build64-default M=drivers/gpu/drm/xe W=1
>make[1]: Entering directory '/workspace/kernel/build64-default'
>../scripts/Makefile.build:41: drivers/gpu/drm/xe/Makefile: No such file or directory

This started happening since commit b1992c3772e6 ("kbuild: use $(src)
instead of $(srctree)/$(src) for source directory"). For context: after
building the entire kernel our CI tries to build just the xe module with
additional CFLAGS... in this case by passing W=1.

Trying to build just xe.ko by path doesn't work:

	make O=build64 W=1 drivers/gpu/drm/xe/xe.ko

WARNING: modpost: missing MODULE_DESCRIPTION() in vmlinux.o
ERROR: modpost: "ttm_bo_vm_dummy_page" [drivers/gpu/drm/xe/xe.ko] undefined!
ERROR: modpost: "drm_mode_is_420_also" [drivers/gpu/drm/xe/xe.ko] undefined!
ERROR: modpost: "drm_dp_downstream_max_dotclock" [drivers/gpu/drm/xe/xe.ko] undefined!
ERROR: modpost: "drm_dp_mst_topology_mgr_set_mst" [drivers/gpu/drm/xe/xe.ko] undefined!
ERROR: modpost: "drm_atomic_state_init" [drivers/gpu/drm/xe/xe.ko] undefined!
ERROR: modpost: "drm_atomic_set_fb_for_plane" [drivers/gpu/drm/xe/xe.ko] undefined!
ERROR: modpost: "drm_dp_remove_payload_part2" [drivers/gpu/drm/xe/xe.ko] undefined!
ERROR: modpost: "drm_dp_channel_eq_ok" [drivers/gpu/drm/xe/xe.ko] undefined!
ERROR: modpost: "drm_dp_downstream_debug" [drivers/gpu/drm/xe/xe.ko] undefined!
ERROR: modpost: "drm_modeset_lock_all_ctx" [drivers/gpu/drm/xe/xe.ko] undefined!
WARNING: modpost: suppressed 507 unresolved symbol warnings because there were too many)
make[3]: *** [../scripts/Makefile.modpost:145: Module.symvers] Error 1
make[2]: *** [/home/lucas/p/linux-dim/src/Makefile:1916: single_modules] Error 2
make[1]: *** [/home/lucas/p/linux-dim/src/Makefile:240: __sub-make] Error 2
make[1]: Leaving directory '/home/lucas/p/linux-dim/src/build64'
make: *** [Makefile:240: __sub-make] Error 2

Alternatives that seem to work:

1) pass the absolute path to M=:

	make O=build64 W=1 M=$PWD/drivers/gpu/drm/xe/

2) just pass the directory:

	make O=build64 W=1 drivers/gpu/drm/xe/
	
I think we avoided (2) due to it not working if we were building commit
by commit and something touched things outside xe. But for this current
use case it seems it's the more correct approach since Makefile says:

	# Use make M=dir or set the environment variable KBUILD_EXTMOD to specify the 
	# directory of external module to build. Setting M= takes precedence.         

Lucas De Marchi

>make[3]: *** No rule to make target 'drivers/gpu/drm/xe/Makefile'.  Stop.
>make[2]: *** [/workspace/kernel/Makefile:1934: drivers/gpu/drm/xe] Error 2
>make[1]: Leaving directory '/workspace/kernel/build64-default'
>make[1]: *** [/workspace/kernel/Makefile:240: __sub-make] Error 2
>make: *** [Makefile:240: __sub-make] Error 2
>run-parts: /workspace/ci/hooks/10-build-W1 exited with return code 2
>
>