Received-SPF: pass (google.com: domain of linux-kernel+bounces-204794-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
From: Stephen Brennan <stephen.s.brennan@oracle.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
        Stephen Brennan <stephen.s.brennan@oracle.com>,
        David Hildenbrand <david@redhat.com>, Hao Ge <gehao@kylinos.cn>,
        Vlastimil Babka <vbabka@suse.cz>,
        "Vishal Moola (Oracle)" <vishal.moola@gmail.com>,
        "Matthew Wilcox (Oracle)" <willy@infradead.org>,
        Omar Sandoval <osandov@osandov.com>
Subject: [PATCH] mm: convert page type macros to enum
Date: Thu,  6 Jun 2024 10:25:29 -0700
Message-ID: <20240606172530.829790-1-stephen.s.brennan@oracle.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?us-ascii?Q?5AVedErpLgCiIrTaY2crpNdB+RVRYl4ZcwLw8pp7DFQg02w81htc+3eawrtr?=
 =?us-ascii?Q?wBpkOAoL6f4gPeHK0wdhvYTucSfONwua7kMXkpAHIu6nUSfNBdU87r9nRwld?=
 =?us-ascii?Q?nVWd2De1E4/HiIQpt+CR+L8W1BXQ3v0xiL45aFRRJ/pqbC2tNNRm8IrNEZUa?=
 =?us-ascii?Q?nR71hCDw6JGwTtNrTJQtCC2yDe888LgxLElxje3a5U/wtufRw4QURMUUkNBr?=
 =?us-ascii?Q?Cn0ApkyNC6JMJEk5eCMkxUZNr9S0e37eMP/BMY9jPO2MUOlcmSNgVj91Fpbb?=
 =?us-ascii?Q?HcVaZWX694CHsh+cAgE3UFbFFPlDiSNKRhMK3KfZLgPtY2/nulSRBcYwgkg5?=
 =?us-ascii?Q?kPDG5TtNvCkP/9CTVvLv4TRjpAUogV/u1aNYp5XVyeQVkjlpPJ1eG69rBjXM?=
 =?us-ascii?Q?9Pn1uKul3RpV9qlQ7lL977sXExDuGYMLPsVSehPFqPp4fly7yMOrdbRC9d6z?=
 =?us-ascii?Q?9Q3rVIHe1BBx3jY+zcfowMC4v1NaF1x12/oyM9Ttz0CYOPCFGfm8LwxyxwF3?=
 =?us-ascii?Q?Ca4U6TuaBFoNMmbPFr2KC8Ua/Mss60tz2UJEcIwiV4hiJFGsQTSOazS2WS6l?=
 =?us-ascii?Q?+uVYm95XGed//JcZL+9soOXxEVIst9QzGxUkJt668QJGljb4OZb0GsVIbQYa?=
 =?us-ascii?Q?Def0ijooSjXlw0/i6w0wMKQaz6hR2LP2yTr5bEKNGMRVX/OBDr13B1CWioNl?=
 =?us-ascii?Q?hgNKkJpM4PszaXsKXorvmL8shBFjFAVbH7oWgWfSLww4In+kqlk+/p/p8gkV?=
 =?us-ascii?Q?B15xYqmqO5JP2o4dGzPTszGPoEDy9yn1kWI89xPcoYI+zKKUKn8uzPWygAJf?=
 =?us-ascii?Q?eLmTGO8rZJIkAX8k3NaA8d+Kt9yv744UPqRSd09jMf9hnj83FzNTSlLfYTnG?=
 =?us-ascii?Q?oniPARd5OMw81rp2LU9VAT7ZunsFR+HkNrYvW4pIO+iJrzfB/7C3FG8mFq4u?=
 =?us-ascii?Q?2LYC4KyQsNGArowEYqsgl1nPVMliBu1ceKrFW0J2ZDtLUwHFahOAWEmchLUa?=
 =?us-ascii?Q?NntfpucN1vEcQXT3RQDOhBjsFrsvMS6FnPX3p8WHf5neSmyzi5zYCRASNNbI?=
 =?us-ascii?Q?GRR5YaUUzwcfT+Ezb6QnYAbA7ZXl8X3+4JKwvIaFrkeFMV9S4rAGq2MIPTFJ?=
 =?us-ascii?Q?fQ0ZdPymkCIKVaCMR29Q4jTQ4YSMenQMjKk+ZREBNzmN+1hE8J/KJCr749EC?=
 =?us-ascii?Q?NAtNnFUdCQI0SX7G2ueF/RsrV2FMmFc8GLHHjybDkVPlQtDXcIs/X4izOX4Z?=
 =?us-ascii?Q?NHK/+IMtaowJY5BtBpxD6UajIF9P07e8yTbdtGx+5vw/XgChI0kH6bAW5mcL?=
 =?us-ascii?Q?dDL6+N/wsCN2q/IC3w3RY1g2O3ntm4J+Zqtsdbef81O+dgH/3pcPCj06a1Mb?=
 =?us-ascii?Q?JueGNP4CFe2xkygxbXmXTKNdapiaO1fzE7cajV0TvzUC/8WkOFq5Ktd9dtd8?=
 =?us-ascii?Q?Af9M6NlcouDAhc/2V3p4LMtMtr3fZwT4QJEEjmT2D807jhT8S0lTfD62iij5?=
 =?us-ascii?Q?qt7x926XiJGTXH6QeT8RIaKuFSEo2SmGs3n6fqLJmgyoVVvbDakyeXhAjTFr?=
 =?us-ascii?Q?SYofo56BbCy4cANUN1/WbKMtLs8rK4VV70xKjTKWp7SzbFhhmkL3GqJuOJj8?=
 =?us-ascii?Q?xWPQwguZ5k9+rb0qZ5WSG3QK2qyUNur5nrrM9rMEs0KunMBA38iOcRTE81T5?=
 =?us-ascii?Q?dYDxeQ=3D=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	zom4q2G5LEB+m6DuZkdEqB/myPh00FcstJpPlClVtlSX/GFJdVHYbYMuKIihv6yjMLMjq//ch2D8HJVIilCWfyjGHIkP7/ni2u/iRR6OQ4BQvksYJmXJufn5QGbS21juAZrMoA2CIdxtnuqdSL2Dadyf/A99fZMfbi/3uwS+kpDr6Ibr/ShWyZJJRYg8/lyOU821vFxCkK7w3DPWy3yC83ZxjUI3qmkcz4DolSnN/ZIrouQXOKzSYe8VYrnuV1FQeKcjrshHyh/X3ZH7xVq2vmMYwnf9BWGH2pBrYR0n34K6pOqbdjhdme0Xq6pBejgnUjwYt4aZljoPpOg8Syt1dal/Wpnnylw701brjf8QBNQ1LUcIwU/2kRoEFhokmtQZ5xfy4PAGEP3qHa/AEEVT+OWHWD0F9vgg+nLCejNlqLOsGihaTCiAEggwIJJOQ0TAV2bsyaO5COT0voY4Smr4uDBVlfPhI6HKuje5pggqfV70fWtU9OprDwK6j/SxJXFeLhRTgmUvtDHo+aswvao8xZKWKjNz5Fgyi84krhchlTuHCzx+kHyv3ttUZXI4hcz2XwMWXNYhgCzHvxQIjraoxv0pLGaRAJSwSsyzbuRTud0=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2511f38e-7ff7-4e78-e3e1-08dc864dab35
X-MS-Exchange-CrossTenant-AuthSource: PH8PR10MB6597.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Jun 2024 17:25:32.4228
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: QhKG62JF6SFons4A4eULeVhZiejrhBI40qJy3CgULEkVbXpZMzlGrSimoqq/q+WRX19kN59UvlLvXRxPHBEtT0O1ByPoRdpdyNjYH9lZkc4=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR10MB5898
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.28.16
 definitions=2024-06-06_14,2024-06-06_02,2024-05-17_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 malwarescore=0 adultscore=0
 phishscore=0 suspectscore=0 bulkscore=0 spamscore=0 mlxlogscore=999
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2405010000
 definitions=main-2406060123
X-Proofpoint-GUID: xeIUb3xLW93gn4Dp0QJ70SYqIworwC6F
X-Proofpoint-ORIG-GUID: xeIUb3xLW93gn4Dp0QJ70SYqIworwC6F

Changing PG_slab from a page flag to a page type in commit 46df8e73a4a3
("mm: free up PG_slab") in has the unintended consequence of removing
the PG_slab constant from kernel debuginfo. The commit does add the
value to the vmcoreinfo note, which allows debuggers to find the value
without hardcoding it. However it's most flexible to continue
representing the constant with an enum. To that end, convert the page
type fields into an enum. Debuggers will now be able to detect that
PG_slab's type has changed from enum pageflags to enum page_type.

Fixes: 46df8e73a4a3 ("mm: free up PG_slab")

Signed-off-by: Stephen Brennan <stephen.s.brennan@oracle.com>
---
 include/linux/page-flags.h | 15 +++++++++------
 1 file changed, 9 insertions(+), 6 deletions(-)

diff --git a/include/linux/page-flags.h b/include/linux/page-flags.h
index 104078afe0b16..64fc191a75e8d 100644
--- a/include/linux/page-flags.h
+++ b/include/linux/page-flags.h
@@ -947,12 +947,15 @@ PAGEFLAG_FALSE(HasHWPoisoned, has_hwpoisoned)
 #define PAGE_TYPE_BASE	0xf0000000
 /* Reserve		0x0000007f to catch underflows of _mapcount */
 #define PAGE_MAPCOUNT_RESERVE	-128
-#define PG_buddy	0x00000080
-#define PG_offline	0x00000100
-#define PG_table	0x00000200
-#define PG_guard	0x00000400
-#define PG_hugetlb	0x00000800
-#define PG_slab		0x00001000
+
+enum page_type {
+	PG_buddy	= 0x00000080,
+	PG_offline	= 0x00000100,
+	PG_table	= 0x00000200,
+	PG_guard	= 0x00000400,
+	PG_hugetlb	= 0x00000800,
+	PG_slab		= 0x00001000,
+};
 
 #define PageType(page, flag)						\
 	((page->page_type & (PAGE_TYPE_BASE | flag)) == PAGE_TYPE_BASE)
-- 
2.43.0