Received: by 2002:ab2:6309:0:b0:1fb:d597:ff75 with SMTP id s9csp550982lqt; Thu, 6 Jun 2024 10:54:31 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCUgO+lBv9n6NnMOxdOGPb9FAdc/c6F2+SI17bB9M/vI2TbwLE9bwS1OLHt2jDG2v6WT21cJ+ertWikfceO4oBcLIu7WANeO9pczT3fW6Q== X-Google-Smtp-Source: AGHT+IFS00QGzHk0A+PqlCPVfzEOYyGATZHJAdJbLk4C42/3i/njckf/x/uo9SfwmSbdRan3UMhO X-Received: by 2002:a05:6a20:5513:b0:1b2:b12d:e364 with SMTP id adf61e73a8af0-1b2f9df7ca1mr241342637.60.1717696470952; Thu, 06 Jun 2024 10:54:30 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1717696470; cv=pass; d=google.com; s=arc-20160816; b=te/Rbqnr+xr3PKRDU1DYj3+RzKcyi5oh5JQ/h0sCHjnGYGBQmrWL9UDkP+WioOX3hp 9a/f0VwTdcna536OYVLMiG2cQEV5rP5NMWUCjHhExwrGdNA1AvhCoPcc55M4GXBV/kS8 3eBuG4m+/S/AUBSEZlQ15wH4DXN6o+X0bzckJAFiATSLA0MZR6x9E8dqPdMABf3jN41T meHKghbRjBhAfYciyFkcf0mPDkRxAwIKbMXhpm3glxLFQrvFeZ0LXAKIcjhnlYm+Fj5d rYdWmFzp0OX8oX4wb8VmFEr4SJT31VWdkb3Rb7l3xmDszIRLjLkYSYK7W5mPgHMbNbgc Ep2w== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=organization:in-reply-to:content-disposition:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:references :message-id:subject:cc:to:from:date:dkim-signature; bh=EtM+juaVmeQkm0TACbQ9zWcMXbw7+CNvMtkgzdI09dQ=; fh=/7CcL++C1a10FgJ93Z2IU81Anf9aNUXYlBignHjRxoc=; b=o9cPHzOkhrwdZ+zDJ2KLDUK2G/PBoMbteivQglivAbmLBvTwe0mhkXTz7GZeYpxhNX pvFR+0Gqex1EfA9tjGgTETN5kUzbzXlH2NyznEsjP6YacjZmmWzaTtz1Ib2jTMnxyk3B cO7bGDasalYFV6byn/e6l5d0Wp7HZCM4DVBdG98X/PqGLugB1mlhAlIgDloYKqwNPmIP aKtzFhcCN0FDONbU2UqTbEDae368+Va+kVMoVsUUtt+mC/boavKuuZbWxOZpLrZ6VDUz /8Hu3WYFWR8+Dt/mLvmR73k3DbGmEabz/5z4ilf0Op42t3ECDjLYcCDGecxa1/fRkZF3 QRXQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=KvGPwprp; arc=pass (i=1 dkim=pass dkdomain=intel.com dmarc=pass fromdomain=linux.intel.com); spf=pass (google.com: domain of linux-kernel+bounces-204841-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-204841-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id d2e1a72fcca58-703fd582f88si1450010b3a.396.2024.06.06.10.54.30 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 06 Jun 2024 10:54:30 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-204841-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=KvGPwprp; arc=pass (i=1 dkim=pass dkdomain=intel.com dmarc=pass fromdomain=linux.intel.com); spf=pass (google.com: domain of linux-kernel+bounces-204841-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-204841-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 9800B2894F5 for ; Thu, 6 Jun 2024 17:54:30 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 7F67B19924B; Thu, 6 Jun 2024 17:54:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="KvGPwprp" Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.11]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 332252AD33; Thu, 6 Jun 2024 17:54:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.11 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717696466; cv=none; b=JJVf/AoizMNirJCNeu8LfmDxo4ZTYWXIDYjcnwlARgYbn6U5AbRG4bjpC5vJWXmIIbonYUa8o1hwsh1iQ9eOcuD8jLbWCBhX3jF5t6UGiyvcL4Baz8JNYo74HeMqh1JrdNrPYq11pYq6D88/ZSnP5UarXJ7U7F/FO9aErSvPMFs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717696466; c=relaxed/simple; bh=YQIiTGoH/7xsWc3WunGC30RQOf4K846Ne+BcGMXwERY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=hp4zS6++gqwrCTnwJ3ffX/XLsZdrW2j4vbwbvbRvytSyVeIybm2noN7UDFr6+rBcxMAx5Iv9zBOU4rjJcbgO9xL5nm2DcH75Agpd+JRkhzK0aMWdwpX93FZ8unJG8EW8uEZxxxX9pCX4mW0kluRzHLl7fVCpdgUZ5IXLbniRLqo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=KvGPwprp; arc=none smtp.client-ip=198.175.65.11 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1717696465; x=1749232465; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=YQIiTGoH/7xsWc3WunGC30RQOf4K846Ne+BcGMXwERY=; b=KvGPwprpWQdFuDKhl0f0xTU67f8krTWeMK+BizjFHLVP6UVaXEGZpr4c ohAP3ReAkrJma1qFDCkSbfRXpeXowMpZWCwYmWT+7KpBZkffkQ/1kIn72 sdojPP1FBhvpJdmXFPbHXKkY49QALNJBrHfs/tYDn7ZsRAfsbMBU343xi YiB1bAtOeeSOFv7a1SnQgT1NCD/l1xAR/yVtK4+4dUlZFNLS+fnFgzSwu xQ+g6CngO60G7Y4X4Pmd3uhG2LPLqQp69BXzD7IzH3j+I2L7UeCsaE8AE WB1m0MEiP5kcfWL23QMgPGUrhpxwcUC/PoN+V9+t7/6m1HncZi5weHn+K w==; X-CSE-ConnectionGUID: sWzi7nAQTICMG9qLBNgFmQ== X-CSE-MsgGUID: X9EisFG0QmiWUmaYVvzFgg== X-IronPort-AV: E=McAfee;i="6600,9927,11095"; a="24960470" X-IronPort-AV: E=Sophos;i="6.08,219,1712646000"; d="scan'208";a="24960470" Received: from orviesa006.jf.intel.com ([10.64.159.146]) by orvoesa103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Jun 2024 10:54:20 -0700 X-CSE-ConnectionGUID: AmF52hkXQXKaxGk+y+i4sA== X-CSE-MsgGUID: 67DuAJyvT8WVcW3OJS89Ug== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.08,219,1712646000"; d="scan'208";a="38496504" Received: from smile.fi.intel.com ([10.237.72.54]) by orviesa006.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Jun 2024 10:54:17 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.97) (envelope-from ) id 1sFHJW-0000000EGdc-1Dv7; Thu, 06 Jun 2024 20:54:14 +0300 Date: Thu, 6 Jun 2024 20:54:14 +0300 From: Andy Shevchenko To: linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Pavel Machek , Lee Jones Subject: Re: [PATCH v1 1/6] leds: spi-byte: call of_node_put() on error path Message-ID: References: <20240606173037.3091598-1-andriy.shevchenko@linux.intel.com> <20240606173037.3091598-2-andriy.shevchenko@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240606173037.3091598-2-andriy.shevchenko@linux.intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo On Thu, Jun 06, 2024 at 08:29:18PM +0300, Andy Shevchenko wrote: > Add a missing call to of_node_put(np) on error. Oh, yeah, this might need the Fixes tag. depending if you want to backport this fix or no hurry. -- With Best Regards, Andy Shevchenko