Received-SPF: pass (google.com: domain of linux-kernel+bounces-204895-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID: <fc5fafa6-cd82-4509-bbfb-dacb16070dcb@quicinc.com>
Date: Thu, 6 Jun 2024 11:33:42 -0700
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] dmaengine: add missing MODULE_DESCRIPTION() macros
Content-Language: en-US
To: =?UTF-8?Q?P=C3=A9ter_Ujfalusi?= <peter.ujfalusi@gmail.com>,
        Vinod Koul
	<vkoul@kernel.org>, Fenghua Yu <fenghua.yu@intel.com>,
        Dave Jiang
	<dave.jiang@intel.com>
CC: <dmaengine@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <kernel-janitors@vger.kernel.org>
References: <20240605-md-drivers-dma-v1-1-bcbcfd9ce706@quicinc.com>
 <b57827de-8e72-442d-99fa-307a719ea33b@gmail.com>
From: Jeff Johnson <quic_jjohnson@quicinc.com>
In-Reply-To: <b57827de-8e72-442d-99fa-307a719ea33b@gmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit

On 6/6/2024 10:44 AM, Péter Ujfalusi wrote:
> Hi,
> 
> On 6/5/24 10:28 PM, Jeff Johnson wrote:
>> make allmodconfig && make W=1 C=1 reports:
>> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/dma/idxd/idxd.o
>> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/dma/ti/omap-dma.o
>> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/dma/dmatest.o
>> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/dma/ioat/ioatdma.o
>>
>> Add the missing invocations of the MODULE_DESCRIPTION() macro.
>>
>> Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com>
>> ---
>>  drivers/dma/dmatest.c     | 1 +
>>  drivers/dma/idxd/init.c   | 1 +
>>  drivers/dma/ioat/init.c   | 1 +
>>  drivers/dma/ti/omap-dma.c | 1 +
>>  4 files changed, 4 insertions(+)
>>
>> diff --git a/drivers/dma/dmatest.c b/drivers/dma/dmatest.c
>> index a4f608837849..1f201a542b37 100644
>> --- a/drivers/dma/dmatest.c
>> +++ b/drivers/dma/dmatest.c
>> @@ -1372,4 +1372,5 @@ static void __exit dmatest_exit(void)
>>  module_exit(dmatest_exit);
>>  
>>  MODULE_AUTHOR("Haavard Skinnemoen (Atmel)");
>> +MODULE_DESCRIPTION("DMA Engine test module");
>>  MODULE_LICENSE("GPL v2");
>> diff --git a/drivers/dma/idxd/init.c b/drivers/dma/idxd/init.c
>> index a7295943fa22..cb5f9748f54a 100644
>> --- a/drivers/dma/idxd/init.c
>> +++ b/drivers/dma/idxd/init.c
>> @@ -22,6 +22,7 @@
>>  #include "perfmon.h"
>>  
>>  MODULE_VERSION(IDXD_DRIVER_VERSION);
>> +MODULE_DESCRIPTION("Intel Data Accelerators support");
>>  MODULE_LICENSE("GPL v2");
>>  MODULE_AUTHOR("Intel Corporation");
>>  MODULE_IMPORT_NS(IDXD);
>> diff --git a/drivers/dma/ioat/init.c b/drivers/dma/ioat/init.c
>> index 9c364e92cb82..d84d95321f43 100644
>> --- a/drivers/dma/ioat/init.c
>> +++ b/drivers/dma/ioat/init.c
>> @@ -23,6 +23,7 @@
>>  #include "../dmaengine.h"
>>  
>>  MODULE_VERSION(IOAT_DMA_VERSION);
>> +MODULE_DESCRIPTION("Intel I/OAT DMA Linux driver");
>>  MODULE_LICENSE("Dual BSD/GPL");
>>  MODULE_AUTHOR("Intel Corporation");
>>  
>> diff --git a/drivers/dma/ti/omap-dma.c b/drivers/dma/ti/omap-dma.c
>> index b9e0e22383b7..5b994c325b41 100644
>> --- a/drivers/dma/ti/omap-dma.c
>> +++ b/drivers/dma/ti/omap-dma.c
>> @@ -1950,4 +1950,5 @@ static void __exit omap_dma_exit(void)
>>  module_exit(omap_dma_exit);
>>  
>>  MODULE_AUTHOR("Russell King");
>> +MODULE_DESCRIPTION("OMAP DMAengine support");
> 
> It would be better to "Texas Instruments sDMA DMAengine support"

will update in v2, thanks

> 
>>  MODULE_LICENSE("GPL");
>>
>> ---
>> base-commit: a693b9c95abd4947c2d06e05733de5d470ab6586
>> change-id: 20240605-md-drivers-dma-2105b7b6f243
>>
>