Received: by 2002:ab2:6309:0:b0:1fb:d597:ff75 with SMTP id s9csp578665lqt; Thu, 6 Jun 2024 11:43:31 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCVVmOCzmdDW9y4x4qP7DqN/oEmmzzByv8WsMb4TuPZilynBJCWq7zyfgUybs5g62rKqSQApCHcY2/A7wTzziHzCJTHOk/GqCQufQJk5Sg== X-Google-Smtp-Source: AGHT+IE4f+fwVTKH1QAZ8WJz6qXgWqmKJfHG1Pcw3nXB70Yx3p4eO4hMJkPHuOSdowS7w1nbanXN X-Received: by 2002:a05:6a20:9688:b0:1b2:c6c7:f626 with SMTP id adf61e73a8af0-1b2f97fdb31mr383360637.18.1717699411421; Thu, 06 Jun 2024 11:43:31 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1717699411; cv=pass; d=google.com; s=arc-20160816; b=Yv/XJ5zgN9llff62a+Ze/23Ji8HQ96CT8QGFlrMiUurfnqQCQiblRXRUeadSfefqIi hUVdweSxgJ/SBKq7CgDPuK9EMYsafoSDPP6YH3u5imvLFDVxfDcPJ2iWqYb9fwaQz7O0 epNmNgQcDFzL6awPJEr4CZABQqwpixOlXyICN1RWAacorTUP6ol6kl/NzlF+vr1kj1Wt qmM6Mzrhl+WB00qU8qu25dxMfSyDjTj7sn+wxMjD2rLeVi6Ofyc+7iYfbV+ZdlLIDLTT ppPRQubNKF9tfvtBDVq4oaqHIuJxwlWEKxlc2Gwz/zoY83B7hNhs4aMvOVJ1f72gExyJ 9Nqg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:list-unsubscribe:list-subscribe:list-id:precedence :date:message-id:dkim-signature; bh=WGuIH4TVekos8V6QPEp5pobse7mh1XHdJCXaTSpOv44=; fh=MAuTGuALUs9ho9GHKDkMkcge9jDa7GKAnfzLgbOvD/U=; b=STdD9fG1Lqk+c0wDxnRWRTMKU1BbXXYbiT4eai4MuCoHNIr0gChAdTVCLMCGQ/J1NJ Zz3RM40mwWOHQTOUftuz+/kYjB1yhwhxe8UphvIvvCLnC1C9ys25QznzZ83M6kjo+wt8 0NH+Orcp0kdLoQB6ELGO1ZOoMkAcm3dgfXDaLCxEXElIFLUlKv5KXoXM1hpBEr0tcSVI 1hp8DOaJdKkQ/Ev7AhcU+WkEr9qAOmh8XloxrMT4larubhkYtnKxDwbic5XcAmGtAq81 wuHBxFTSw/Q4xsP09P9SQrx8HOT5imOcoKB8SKLCEz4OXGqVnisrd4YhlvBdPXA3uc65 vl9Q==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=JfBAd8Ge; arc=pass (i=1 spf=pass spfdomain=redhat.com dkim=pass dkdomain=redhat.com dmarc=pass fromdomain=redhat.com); spf=pass (google.com: domain of linux-kernel+bounces-204903-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-204903-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id d2e1a72fcca58-703ff115c9fsi1366479b3a.2.2024.06.06.11.43.31 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 06 Jun 2024 11:43:31 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-204903-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=JfBAd8Ge; arc=pass (i=1 spf=pass spfdomain=redhat.com dkim=pass dkdomain=redhat.com dmarc=pass fromdomain=redhat.com); spf=pass (google.com: domain of linux-kernel+bounces-204903-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-204903-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id EAB7C28A565 for ; Thu, 6 Jun 2024 18:42:46 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 96AE445945; Thu, 6 Jun 2024 18:42:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="JfBAd8Ge" Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 02A4545012 for ; Thu, 6 Jun 2024 18:42:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717699355; cv=none; b=Qou9FCx2MLL40Bk7KCBJujlsudjS/oP9Vl8rsyZ7is+s1B5+q2hsIixJC7ALIwQEnCP4F6DlT1xVYIPeMgl8MoRnmHwNUxOizkv54Fyx/Io4k4aRuMOlHRJ6JgdkwyOJ2MBqkqSkSSEt7owBhxvck61JrBFcoVkIwjBfkJEArm0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717699355; c=relaxed/simple; bh=2V49E/B6BWL8skLBcpq2oCIhdd36FF2nWRGhN2dTWPg=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=tEl7L3/NB85+gWgiN26hLDoew0LBCUK4pgOAjSeDmJPLvOy1R3uBXJBUM7wAAj2MR+T16KwA+9f6GT7J+pksWJ+YZ6YMFHZgtf7huX1N4tmPdZTotCwDB3G3/qZgpaK9W2YreAQdMj1AxmUwRe5CWOpA/q6rwaq7jxJtWWxdaX0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=JfBAd8Ge; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1717699352; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=WGuIH4TVekos8V6QPEp5pobse7mh1XHdJCXaTSpOv44=; b=JfBAd8GemEWiBQ5BilUoOQaWk1estV5RwYb0IgBNdcdgdTsrUFW8LItS87eubM7iAt/SmQ QU7dl/uApYHA2PH/jSQGcfskYGYaKrsAniU9fRO+KN+ripzdi9JlPmhW1CCTs7aScsATBV eU9jLFIWu74n5VR0x4CQfVZC4FDO3XA= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-28-8JdUYJFaPZeOit0ponIF6Q-1; Thu, 06 Jun 2024 14:42:31 -0400 X-MC-Unique: 8JdUYJFaPZeOit0ponIF6Q-1 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-35e0e59dcf7so916441f8f.2 for ; Thu, 06 Jun 2024 11:42:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717699350; x=1718304150; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=WGuIH4TVekos8V6QPEp5pobse7mh1XHdJCXaTSpOv44=; b=tjZa1a1F8djXAo58ahykmV5RcPYVy+2zgU5Qxsoe9cif/XmIKNEIaEcByVuXz0Nkon kvB8Z9rjKJN/ZZJrwc9J/0s2kc9hu7b7xGpXlRL4/aeGj1o0K+NR7LHaFyTMNZ+0N8yh CGtru+cnovuSSzdV5XMMZeKwMC2QnYYjicWK3cuN/e7Z5nkwG7x6cX3z2+StkohcAK+z 3uYJGc8WQIXtMb3gxPzI7NxpT8Jz7Jm5THGFBoSRNC4TLujmHJLI62wZ86BqZ6hgN2/r EVxMnJBCtG1ympzahV3lh9EqgIWEJSUeC12mRWgcm6ch01m7bz/m/JaJ868HLt35rNrk 8Zkg== X-Forwarded-Encrypted: i=1; AJvYcCWmOaI4wXK4kpWp5x7Yush35usbCCRRpMvOPB91p6WSxxE688oQQP1H2BmSD8l9VFD+l4KTBK2pYRr98HyYIXDLpVspbxyGk1z8c0iG X-Gm-Message-State: AOJu0YxD02dvxcjQ9LbZpLRlKjF1auTXdYWbkDetK+nlibtQyiUq33uS Jz5V5/vqGyWJmjtDu6dPa/YqLudm+DzFrfMwjn3bniIux34rBKHDms8JxkNnGqiOyVOAhpLwfFo TQVqfoRbF+8yZ0IM4nfg7iXFoh7ES60dMLIv9+WjXlbfy2OUVKPchIPZdZUhAgQ== X-Received: by 2002:a5d:42c6:0:b0:355:673:dd95 with SMTP id ffacd0b85a97d-35efed787c8mr325378f8f.38.1717699350138; Thu, 06 Jun 2024 11:42:30 -0700 (PDT) X-Received: by 2002:a5d:42c6:0:b0:355:673:dd95 with SMTP id ffacd0b85a97d-35efed787c8mr325370f8f.38.1717699349697; Thu, 06 Jun 2024 11:42:29 -0700 (PDT) Received: from ?IPV6:2003:cb:c710:8800:a73c:ec5b:c02c:5e0b? (p200300cbc7108800a73cec5bc02c5e0b.dip0.t-ipconnect.de. [2003:cb:c710:8800:a73c:ec5b:c02c:5e0b]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-35ef5d69e71sm2220595f8f.65.2024.06.06.11.42.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 06 Jun 2024 11:42:29 -0700 (PDT) Message-ID: Date: Thu, 6 Jun 2024 20:42:28 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] mm: convert page type macros to enum To: Stephen Brennan , Andrew Morton Cc: Omar Sandoval , Hao Ge , Vlastimil Babka , linux-kernel@vger.kernel.org, "Vishal Moola (Oracle)" , linux-mm@kvack.org, linux-debuggers@vger.kernel.org, "Matthew Wilcox (Oracle)" References: <20240606182630.851750-1-stephen.s.brennan@oracle.com> From: David Hildenbrand Content-Language: en-US Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20240606182630.851750-1-stephen.s.brennan@oracle.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 06.06.24 20:26, Stephen Brennan wrote: > Changing PG_slab from a page flag to a page type in commit 46df8e73a4a3 > ("mm: free up PG_slab") in has the unintended consequence of removing > the PG_slab constant from kernel debuginfo. The commit does add the > value to the vmcoreinfo note, which allows debuggers to find the value > without hardcoding it. However it's most flexible to continue > representing the constant with an enum. To that end, convert the page > type fields into an enum. Debuggers will now be able to detect that > PG_slab's type has changed from enum pageflags to enum page_type. > > Fixes: 46df8e73a4a3 ("mm: free up PG_slab") > > Signed-off-by: Stephen Brennan > --- > v1 -> v2: include PAGE_TYPE_BASE and PAGE_MAPCOUNT_RESERVE This has a conflict with mm/mm-unstable. -- Cheers, David / dhildenb