Received-SPF: pass (google.com: domain of linux-kernel+bounces-204921-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Message-ID: <f901fd06-3b6b-4444-a3da-2b75c59059d3@marvell.com>
Date: Fri, 7 Jun 2024 00:21:54 +0530
User-Agent: Mozilla Thunderbird
Subject: [PATCH v6 1/1] irqchip/gic-v3: Enable non-coherent
 redistributors/ITSes ACPI probing
To: Lorenzo Pieralisi <lpieralisi@kernel.org>, linux-kernel@vger.kernel.org
Cc: Robin Murphy <robin.murphy@arm.com>, Marc Zyngier <maz@kernel.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        Mark Rutland <mark.rutland@arm.com>,
        "Rafael J. Wysocki" <rafael@kernel.org>,
        linux-arm-kernel@lists.infradead.org, linux-acpi@vger.kernel.org,
        acpica-devel@lists.linux.dev
References: <20240123110332.112797-1-lpieralisi@kernel.org>
 <20240606094238.757649-1-lpieralisi@kernel.org>
 <20240606094238.757649-2-lpieralisi@kernel.org>
Content-Language: en-US
From: Amit Singh Tomar <amitsinght@marvell.com>
In-Reply-To: <20240606094238.757649-2-lpieralisi@kernel.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?utf-8?B?QWtFeTRkeVNWVndpei8yR2NvNk9BVVlYVDNWaWZPRnp6TGl4dHVXb1M5K1Fs?=
 =?utf-8?B?Qnd3RWc1SGJKU1JGV0wzNW5lVmFvL1RkSTZBcldsdjRJQW1jWUIvRjMycEs5?=
 =?utf-8?B?QzhDUGh2eUF5NTlyeFFoTUswZUJRalpEejdyMnF6b2RNZFFtRzlKSzhDNWZZ?=
 =?utf-8?B?ZTF4K05ndk1SdGZOS3VBNjlJREl2VmxKM2xJODc2WUtPZUsrNDkyMWMxaTRq?=
 =?utf-8?B?ZXVkKzhYRVRHQmdHU203U0h0d2ZyV05CWWtaU2dPUS8xR3JMR0FHbEFLVjVx?=
 =?utf-8?B?K3R5ZHFVR0hWNjBUR1VkeWxITERrZ3RGMlRLbUhoWjM5OXg2MW55VHpiSFdt?=
 =?utf-8?B?dEEyV3F6Yk8ybkRWdDhXS2dCRHlaekZMMFA3Q2Vkd3hBK1RQblgzT25OeVds?=
 =?utf-8?B?cEp5VmxWeTZCMDl5aFJCZjRMZk1lV0RuTFpGa0hFdmdmTTNiL3hvQ0tVYmht?=
 =?utf-8?B?UGdpZzMrUWpHTFJYUStGM2NuNGU5a0E1TnZkVGRwVE9pZGpIc1RqTFRRY3pF?=
 =?utf-8?B?aFBoc0pOSCtXQW5nN0E1aWNPT1JIVmM2R3ZPVyt0amVad0k0NXVTdWJzT0hD?=
 =?utf-8?B?OUhCM0dPeVVyUlhmdkwrR0JUd3pmdUVsQnRUUDFYZ2Y4N2VMcVR2L3l5Vnk0?=
 =?utf-8?B?ajBTTDFlOG5Ucmp0bzBJT1Q5YmJ0c0RVd2hMY2M1OVliZlQwbkFiUHlPM05F?=
 =?utf-8?B?YkVxUG8wbHFBUWpla29vM1RWVHJGOE55SVZGOXM0MEFOZUNXcmxrayt4R3Mz?=
 =?utf-8?B?dHN4dk5wQ3VZSkFMNmtKaUd0Q2VRd1BycjdUZ3AyVjQxWURibGh0L3YwOGFp?=
 =?utf-8?B?Mk5nM292WVBwdDN6QnZNcEFreVlKMWhWajc4RTFJTlF0anpxZDhSSldwem9Q?=
 =?utf-8?B?L25tRHQxOEhmNUlzS2JVZlpIcXlocUFORE1MVEdVVkdRN1VobjIwQThDTzc4?=
 =?utf-8?B?SldaZnVMdVdzbkVnT0twNG5tY2F4eWRuTitlSTRjMDhVS2xnbjNyTmVvalVF?=
 =?utf-8?B?d0FONmxGd1BGbS9CZ3ZyMlR2NTAvMC9QaEUyMTJoOThXbmlaUDBDaFZFdVRw?=
 =?utf-8?B?ME9zRG9FV0lqSUdiblNTQWxia3l4TjZGZHlpRDA1MjFyQ1NPa29FbzloWTdS?=
 =?utf-8?B?dWR1ZklKNmVNYXdnVDZWZHhxaVhOVFQ3ZkQwbExmTktXL1duZGNNNyt5SmRk?=
 =?utf-8?B?UDNrc3BjTVJBc1dpZ3ZXWEtXUTdQa281UjJ3Rmg1eTFSWDJKbFVvekhHZkZy?=
 =?utf-8?B?cGpuUXBGVEVqOVJoUExsN3NjZ1FPYjcyYzZaeUE4bDlBcWVYOVdrbGVENnc5?=
 =?utf-8?B?QzVlTnZUZVhJWXNPYVRxSUkrSG03VDZxWFdTSkFhRHJDcGVXQURkRmpFQzI1?=
 =?utf-8?B?L0g1c2g5dExFWTBtbkc2QzNWRTVrZlk0UXROLzFHV0RkVDk1bVIwSU9GajV0?=
 =?utf-8?B?bHBWRWtzYzdNMFVyWnVmcDBZcGUzOTVxTFZ3ZlRiYzQ0eE5TNERCY0pIRVZo?=
 =?utf-8?B?U0phbWs4VVZ0UHBCNWQzM2d2ZGNLWGlFWlpoZkpjYWZheDVRTDZZbTBKNlJE?=
 =?utf-8?B?OVY1Qlcyc3BHNkRjT1YyeGlQZ0tnZHNaTXBpWUhMMTYxaE1zQWhEa2VRSGtZ?=
 =?utf-8?B?dmxndDAwb0dCdDZpaXR2QmpJVDNNMjNzWHBFK2dQdXhkRVVFa2pPNS9GRnFH?=
 =?utf-8?B?YVBaS3J3RTJKdDJYRC8yQTdCdUQ2NUJqb28rL2ozblVuSk1yakRMTVljVXlN?=
 =?utf-8?B?NjFqczM4UDVHVWxNUGljRmo4YUtvZnFUaERJK0tYTEFBU0dXYmtsSWEzOXpF?=
 =?utf-8?B?M3I1OXVuRzYwK2JDc1VvL08wR0hsRTkwSXBWVFhpU3lrcTU2VUJEL0RiRnE2?=
 =?utf-8?B?aksrbHBzcURCOVk0WnFobmdRK09IbXNTeGlXSElQNS9xUnRUODlxRjY3dndR?=
 =?utf-8?B?eTNUOGRCODlwbGlMS2JFaWxOeU5LNndOdDh3T2UwZGp2UGRZa2c4Q01qaWo2?=
 =?utf-8?B?SWFEaWw3UkhZSWsvaDVUOFJJKzRmRXpwQlVZT3Foa0NOZ1lQU3FKeGl0K3hR?=
 =?utf-8?B?RHp0Y1dreWRzZE5ZdFZCdzVUSDZ5eHMxckgxMWs4clhqci9WdkFqMm03bUUv?=
 =?utf-8?Q?7zg4yVYyY1ogLLpBJ0lFDYHF6?=
X-OriginatorOrg: marvell.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 150362c8-61d8-42ae-68d6-08dc8659c184
X-MS-Exchange-CrossTenant-AuthSource: MW4PR18MB5084.namprd18.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Jun 2024 18:52:03.8391
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 70e1fb47-1155-421d-87fc-2e58f638b6e0
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: WAdds2HKnZI/MsT+JDWJx15WbUGTzXVYCEaKL9yW5gB6ZY7zqmk0+mUNB9q3urPVOLzXNq+hfn+4fD8NYPr/aw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA3PR18MB5370
X-Proofpoint-GUID: _dfNb5NE8MjCU4jiS6GRg72zmDcgUzNy
X-Proofpoint-ORIG-GUID: _dfNb5NE8MjCU4jiS6GRg72zmDcgUzNy
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.28.16
 definitions=2024-06-06_15,2024-06-06_02,2024-05-17_01

> ----------------------------------------------------------------------
> The GIC architecture specification defines a set of registers for
> redistributors and ITSes that control the sharebility and cacheability
> attributes of redistributors/ITSes initiator ports on the interconnect
> (GICR_[V]PROPBASER, GICR_[V]PENDBASER, GITS_BASER<n>).
> 
> Architecturally the GIC provides a means to drive shareability and
> cacheability attributes signals but it is not mandatory for designs to
> wire up the corresponding interconnect signals that control the
> cacheability/shareability of transactions.
> 
> Redistributors and ITSes interconnect ports can be connected to
> non-coherent interconnects that are not able to manage the
> shareability/cacheability attributes; this implicitly makes the
> redistributors and ITSes non-coherent observers.
> 
> To enable non-coherent GIC designs on ACPI based systems, parse the MADT
> GICC/GICR/ITS subtables non-coherent flags to determine whether the
> respective components are non-coherent observers and force the
> shareability attributes to be programmed into the redistributors and
> ITSes registers.
> 
> An ACPI global function (acpi_get_madt_revision()) is added to retrieve
> the MADT revision, in that it is essential to check the MADT revision
> before checking for flags that were added with MADT revision 7 so that
> if the kernel is booted with an ACPI MADT table with revision < 7 it
> skips parsing the newly added flags (that should be zeroed reserved
> values for MADT versions < 7 but they could turn out to be buggy and
> should be ignored).
> 
> Signed-off-by: Lorenzo Pieralisi <lpieralisi@kernel.org>
> Reviewed-by: Robin Murphy <robin.murphy@arm.com>
> Acked-by: Marc Zyngier <maz@kernel.org>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Cc: Robin Murphy <robin.murphy@arm.com>
> Cc: Mark Rutland <mark.rutland@arm.com>
> Cc: "Rafael J. Wysocki" <rafael@kernel.org>
> Cc: Marc Zyngier <maz@kernel.org>
> ---
>   drivers/acpi/processor_core.c    | 15 +++++++++++++++
>   drivers/irqchip/irq-gic-v3-its.c |  4 ++++
>   drivers/irqchip/irq-gic-v3.c     |  9 +++++++++
>   include/linux/acpi.h             |  3 +++
>   4 files changed, 31 insertions(+)
> 
> diff --git a/drivers/acpi/processor_core.c b/drivers/acpi/processor_core.c
> index b203cfe28550..915713c0e9b7 100644
> --- a/drivers/acpi/processor_core.c
> +++ b/drivers/acpi/processor_core.c
> @@ -215,6 +215,21 @@ phys_cpuid_t __init acpi_map_madt_entry(u32 acpi_id)
>   	return rv;
>   }
>   
> +int __init acpi_get_madt_revision(void)

Wondering, if we can have a generic function (acpi_get_tbl_revision) to 
obtain the revision number for any ACPI table, not just specific to MADT?

> +{
> +	struct acpi_table_header *madt = NULL;
> +	int revision;
> +
> +	if (ACPI_FAILURE(acpi_get_table(ACPI_SIG_MADT, 0, &madt)))
> +		return -EINVAL;
> +
> +	revision = madt->revision;
> +
> +	acpi_put_table(madt);
> +
> +	return revision;
> +}
> +
>   static phys_cpuid_t map_mat_entry(acpi_handle handle, int type, u32 acpi_id)
>   {
>   	struct acpi_buffer buffer = { ACPI_ALLOCATE_BUFFER, NULL };
> diff --git a/drivers/irqchip/irq-gic-v3-its.c b/drivers/irqchip/irq-gic-v3-its.c
> index 40ebf1726393..af5297ef2293 100644
> --- a/drivers/irqchip/irq-gic-v3-its.c
> +++ b/drivers/irqchip/irq-gic-v3-its.c
> @@ -5600,6 +5600,10 @@ static int __init gic_acpi_parse_madt_its(union acpi_subtable_headers *header,
>   		goto node_err;
>   	}
>   
> +	if (acpi_get_madt_revision() >= 7 &&
> +	    (its_entry->flags & ACPI_MADT_ITS_NON_COHERENT))
> +		its->flags |= ITS_FLAGS_FORCE_NON_SHAREABLE;
> +
>   	err = its_probe_one(its);
>   	if (!err)
>   		return 0;
> diff --git a/drivers/irqchip/irq-gic-v3.c b/drivers/irqchip/irq-gic-v3.c
> index 6fb276504bcc..e4bc5f04226e 100644
> --- a/drivers/irqchip/irq-gic-v3.c
> +++ b/drivers/irqchip/irq-gic-v3.c
> @@ -2349,6 +2349,11 @@ gic_acpi_parse_madt_redist(union acpi_subtable_headers *header,
>   		pr_err("Couldn't map GICR region @%llx\n", redist->base_address);
>   		return -ENOMEM;
>   	}
> +
> +	if (acpi_get_madt_revision() >= 7 &&
> +	    (redist->flags & ACPI_MADT_GICR_NON_COHERENT))
> +		gic_data.rdists.flags |= RDIST_FLAGS_FORCE_NON_SHAREABLE;
> +
>   	gic_request_region(redist->base_address, redist->length, "GICR");
>   
>   	gic_acpi_register_redist(redist->base_address, redist_base);
> @@ -2373,6 +2378,10 @@ gic_acpi_parse_madt_gicc(union acpi_subtable_headers *header,
>   		return -ENOMEM;
>   	gic_request_region(gicc->gicr_base_address, size, "GICR");
>   
> +	if (acpi_get_madt_revision() >= 7 &&
> +	    (gicc->flags & ACPI_MADT_GICC_NON_COHERENT))
> +		gic_data.rdists.flags |= RDIST_FLAGS_FORCE_NON_SHAREABLE;
> +
>   	gic_acpi_register_redist(gicc->gicr_base_address, redist_base);
>   	return 0;
>   }
> diff --git a/include/linux/acpi.h b/include/linux/acpi.h
> index 28c3fb2bef0d..000d339e1596 100644
> --- a/include/linux/acpi.h
> +++ b/include/linux/acpi.h
> @@ -279,6 +279,9 @@ static inline bool invalid_phys_cpuid(phys_cpuid_t phys_id)
>   	return phys_id == PHYS_CPUID_INVALID;
>   }
>   
> +
> +int __init acpi_get_madt_revision(void);
> +
>   /* Validate the processor object's proc_id */
>   bool acpi_duplicate_processor_id(int proc_id);
>   /* Processor _CTS control */