Received-SPF: pass (google.com: domain of linux-kernel+bounces-204925-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
From: Thomas Gleixner <tglx@linutronix.de>
To: Matti Vaittinen <mazziesaccount@gmail.com>, Matti Vaittinen
 <mazziesaccount@gmail.com>, Matti Vaittinen
 <matti.vaittinen@fi.rohmeurope.com>
Cc: Lee Jones <lee@kernel.org>, Rob Herring <robh@kernel.org>, Krzysztof
 Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley
 <conor+dt@kernel.org>, Liam Girdwood <lgirdwood@gmail.com>, Mark Brown
 <broonie@kernel.org>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
 "Rafael J. Wysocki" <rafael@kernel.org>, Matti Vaittinen
 <mazziesaccount@gmail.com>, Wim Van Sebroeck <wim@linux-watchdog.org>,
 Guenter Roeck <linux@roeck-us.net>, devicetree@vger.kernel.org,
 linux-kernel@vger.kernel.org, linux-watchdog@vger.kernel.org, Herve Codina
 <herve.codina@bootlin.com>
Subject: Re: [PATCH v3 07/10] irqdomain: Allow giving name suffix for domain
In-Reply-To: <bbd219c95f4fe88752aee5f21232480fe9b949fb.1717486682.git.mazziesaccount@gmail.com>
References: <cover.1717486682.git.mazziesaccount@gmail.com>
 <bbd219c95f4fe88752aee5f21232480fe9b949fb.1717486682.git.mazziesaccount@gmail.com>
Date: Thu, 06 Jun 2024 20:59:47 +0200
Message-ID: <87plst28yk.ffs@tglx>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain

Matti!

On Tue, Jun 04 2024 at 10:55, Matti Vaittinen wrote:
>  struct irq_domain *__irq_domain_add(struct fwnode_handle *fwnode, unsigned int size,
>  				    irq_hw_number_t hwirq_max, int direct_max,
>  				    const struct irq_domain_ops *ops,
> -				    void *host_data);
> +				    void *host_data, const char *name_suffix);
>  struct irq_domain *irq_domain_create_simple(struct fwnode_handle *fwnode,
>  					    unsigned int size,
>  					    unsigned int first_irq,
> @@ -350,7 +350,8 @@ static inline struct irq_domain *irq_domain_add_linear(struct device_node *of_no
>  					 const struct irq_domain_ops *ops,
>  					 void *host_data)
>  {
> -	return __irq_domain_add(of_node_to_fwnode(of_node), size, size, 0, ops, host_data);
> +	return __irq_domain_add(of_node_to_fwnode(of_node), size, size, 0, ops,
> +				host_data, NULL);

....

Looking at the resulting amount of churn to add that argument, I'm not
really enthused. There is some other unrelated change required in this
area:

  https://lore.kernel.org/all/8734pr5yq1.ffs@tglx

My suggestion to convert all of this mess into a template based
mechanism would nicely solve your problem too.

Can you please have a look and eventually team up with Herve (CC'ed) to
sort this out? I'm happy to help and give guidance.

Thanks,

        tglx