Received-SPF: pass (google.com: domain of linux-kernel+bounces-204935-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <f00f2767-c113-0953-9869-c9696da677f0@amd.com>
Date: Thu, 6 Jun 2024 14:15:38 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.15.1
From: Tom Lendacky <thomas.lendacky@amd.com>
To: linux-kernel@vger.kernel.org, x86@kernel.org, linux-coco@lists.linux.dev,
 svsm-devel@coconut-svsm.dev
Cc: Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>,
 Borislav Petkov <bp@alien8.de>, Dave Hansen <dave.hansen@linux.intel.com>,
 "H. Peter Anvin" <hpa@zytor.com>, Andy Lutomirski <luto@kernel.org>,
 Peter Zijlstra <peterz@infradead.org>,
 Dan Williams <dan.j.williams@intel.com>, Michael Roth
 <michael.roth@amd.com>, Ashish Kalra <ashish.kalra@amd.com>
References: <cover.1717600736.git.thomas.lendacky@amd.com>
 <965015dce3c76bb8724839d50c5dea4e4b5d598f.1717600736.git.thomas.lendacky@amd.com>
Content-Language: en-US
Subject: Re: [PATCH v5 12/13] x86/sev: Extend the config-fs attestation
 support for an SVSM
In-Reply-To: <965015dce3c76bb8724839d50c5dea4e4b5d598f.1717600736.git.thomas.lendacky@amd.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?UzVwdkR2SXQvcENhdE1ockN4alZNZWU4RlJNdlplVXlhMEVZcXJ4MTlmSTR5?=
 =?utf-8?B?NEM0MjVRYm92eUdzVjA2cFNLSG15Qlo2RmJrZFJlbFVSZENZOS9uaEhKc0Iv?=
 =?utf-8?B?S0NTaS9OTTFwZWJaWXNyU090SitCWmVLQUN2a1AvUFNoMGdSeGFGdSt3TDgw?=
 =?utf-8?B?VXd3Z3FBa3daRkg4eUVUZCs3aXBqVFhCbFNVUHB2Yzd3akMwVmg2b0FpV2k5?=
 =?utf-8?B?Q3JtVDNpODhQR3NFaEc1ZitrVXc0ckMzS3lrSCt0S3piQzd2T3BzZWpEd3ZW?=
 =?utf-8?B?SVRjU01pT1U5RHZUNW1uWE1GbmdsS05GMSt4U3RkTk5WaHExb2FTN3c0RVE3?=
 =?utf-8?B?a1RQdlgwOE8wNzBMNkl4azloLzYxV2RZTEk4QVRwbGNBYkpGU2hReFZCWGhM?=
 =?utf-8?B?TDlIZlZJQkFuMjZpL0p6Y1dNaXlpMTJMUWZBOGdVV1pzQlpveVJBNXZHM1Q4?=
 =?utf-8?B?bjcrQVBHWVBDVEtNQnBxU1lkWVZmYmlwb0gzaHd6UlVLTk9aS1cxVnZhTXRM?=
 =?utf-8?B?c215QjNNRXRGOWhsUkREZlhhSmxRNTNlcXFaRVA0eit2NnNuc1RrKzlaUDFQ?=
 =?utf-8?B?aEFwVkx6d2hKdlhXTTM0QzYycVpaQ0gvS2JmWGl4cVQxaVk5c21tbFVlbmFD?=
 =?utf-8?B?NEI5dVFxMlJaR0NDTEJEMTRBNHZidnFVZ25xamduKy9IUXY0ejJOQ0hYZkZZ?=
 =?utf-8?B?SUR3WFFDcVE4MDZaeWVaWmxla3JNS1NSczR1WS9tRzVabFlPWmhzUFRTUEJn?=
 =?utf-8?B?M2FWT2RTelcvYTdYU1ZKMEpON3QxS1prWGcxbitCcmJOQjlGb0phVW9JU0Z4?=
 =?utf-8?B?TkpIbWZmR1pvNTI3cTFjL283QUs2QlVZcXVBU3VQWUJLMnJuZDBWRVJXTjEw?=
 =?utf-8?B?SjRLclpxbXRkWUc5allweUxjUXBUSjZNZEQwazJYdk1nQmFnVkJETEtwbUVn?=
 =?utf-8?B?MlhBK1kxSWllRk9Qc3FIeS9nT1RkbHFIbnZhWkMxWmhmTksxMWg1ZmU0Q3F6?=
 =?utf-8?B?TUIwck13czhvNUllbWxsdG40SlpvaERYa1VQTGI1ck14NHFTTlFEeU15R21M?=
 =?utf-8?B?MWFEWmtnamNoVENLZ2JxaC9pZUpjYXh3L2FobFA1SVlVUm5jb3FzOUxYc3Ux?=
 =?utf-8?B?bFcvTzNXMHIxdmVVK3phQWxkM09JMm56VE1FWkhMMTh5WCt4Y2krdmlLZDQv?=
 =?utf-8?B?dEVhcHNTNmxQN3p1aWV5Wi9wc1g3c05QTHl4SVUyTjRJYzRnV2ZEZThwOU1E?=
 =?utf-8?B?Z3JSdjlna2Z5emZzN1lkS3JPb0NwTGtjaGl4WXp5d1JScWdYaTM5RUJjYXQy?=
 =?utf-8?B?b2E2YTV2YUNVdGkycnFYTXE5NXdjbzhRMGhLY2ZoNnVLcDJpY0NrWWg3UG5N?=
 =?utf-8?B?R3Fjc3YyTDREK1RoUmkzNDVrZ1ZUUkx6NGVwRDAyTUFtdFZ1WlBEeXBaa3lI?=
 =?utf-8?B?aVJvUHFicHNtazRsengzRGovd2c5WjV1RE1vZWVCNEpPa1FDa0Qxd0lFWVJK?=
 =?utf-8?B?MHZ5VmFYNVpYS0hSaHI1a212V2Z4L1lmM1BURGQ5eHN5cjFvRE1CVzN5amJ0?=
 =?utf-8?B?bjRBSFhqMGc5c2dNNjhFdkgwVWFSMjJnLzVyd2M3R1dKUVpaOS94L1ZQMmYx?=
 =?utf-8?B?YVAxdVpNOGhTYkNTU3lxQnY4MlBKa2VvOW4yVkdmL0x4cmRjNWZJSjVUUHhl?=
 =?utf-8?B?aVlwUlJTNzdtVUpJNWN5cVdCVzUzSjZ2bDhYdGhzMS9XR1oyOGt4dy9Nc0dM?=
 =?utf-8?B?anZpblpkSnRzQm9TMlZGR1BIT2p0dmVHME1LR1BkVUNNQlhXelRsZEVna00z?=
 =?utf-8?B?VVJjdUJQOVRlYnJudFF2N1p3RHF1TEdiTjluckpscDhuN0hqT2RpUkR2c3Vj?=
 =?utf-8?B?WE5ibmNxQWx0djN6WUV5blowNWcyWHhMNm5qTjk1eno3dXNCYjN4Y29wOVJ5?=
 =?utf-8?B?TDBlVlNtSHRKempTQTZBWExQVE1SNCtMaW1UL0pvclZmZStoQmpQYktIMkJM?=
 =?utf-8?B?UWl3cC9YRXRRdVJGQUxMRGtDN3BSS0xQaGNILzg3bitRT2FObDd1ZU1kcHhz?=
 =?utf-8?B?ejRrWkxuN2ZXamZzL0NnZXNpLzZLSTRrREFxWmc2OVM4WWE0Vms2Rnkvc1I4?=
 =?utf-8?Q?gzUPYelXMW5WzAlsX3hsqtIuK?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d19dc8d8-6a13-4d6f-bb28-08dc865d0e57
X-MS-Exchange-CrossTenant-AuthSource: BL1PR12MB5732.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Jun 2024 19:15:41.2095
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: DcTOQZEUnq6QiBjunKqEDDnmAbX0EKdyeUmNVWkVce93WlmEaO/bV3pd1SmO1R82EZGWX/06i+cQI2y0yKHmhA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR12MB6006

On 6/5/24 10:18, Tom Lendacky wrote:
> When an SVSM is present, the guest can also request attestation reports
> from the SVSM. These SVSM attestation reports can be used to attest the
> SVSM and any services running within the SVSM.
> 
> Extend the config-fs attestation support to allow for an SVSM attestation
> report. This involves creating four (4) new config-fs attributes:
> 
>    - 'service-provider' (input)
>      This attribute is used to determine whether the attestation request
>      should be sent to the specified service provider or to the SEV
>      firmware. The SVSM service provider is represented by the value
>      'svsm'.
> 
>    - 'service_guid' (input)
>      Used for requesting the attestation of a single service within the
>      service provider. A null GUID implies that the SVSM_ATTEST_SERVICES
>      call should be used to request the attestation report. A non-null
>      GUID implies that the SVSM_ATTEST_SINGLE_SERVICE call should be used.
> 
>    - 'service_manifest_version' (input)
>      Used with the SVSM_ATTEST_SINGLE_SERVICE call, the service version
>      represents a specific service manifest version be used for the
>      attestation report.
> 
>    - 'manifestblob' (output)
>      Used to return the service manifest associated with the attestation
>      report.
> 
> Only display these new attributes when running under an SVSM.
> 
> Signed-off-by: Tom Lendacky <thomas.lendacky@amd.com>
> ---
>   Documentation/ABI/testing/configfs-tsm  |  63 +++++++++
>   arch/x86/include/asm/sev.h              |  31 ++++-
>   arch/x86/kernel/sev.c                   |  50 +++++++
>   drivers/virt/coco/sev-guest/sev-guest.c | 178 ++++++++++++++++++++++++
>   drivers/virt/coco/tsm.c                 |  93 ++++++++++++-
>   include/linux/tsm.h                     |  19 +++
>   6 files changed, 431 insertions(+), 3 deletions(-)
> 

Here's a small change to provide better error detail that you can squash
into this patch if that's ok.

Thanks,
Tom

diff --git a/drivers/virt/coco/sev-guest/sev-guest.c b/drivers/virt/coco/sev-guest/sev-guest.c
index 655865164705..e32ac31e0630 100644
--- a/drivers/virt/coco/sev-guest/sev-guest.c
+++ b/drivers/virt/coco/sev-guest/sev-guest.c
@@ -886,7 +886,8 @@ static int sev_svsm_report_new(struct tsm_report *report, void *data)
  
  			return -EINVAL;
  		default:
-			pr_err_ratelimited("SVSM attestation request failed (%#x)\n", ret);
+			pr_err_ratelimited("SVSM attestation request failed (%d / 0x%llx)\n",
+					   ret, call.rax_out);
  			return -EINVAL;
  		}
  	}