Received-SPF: pass (google.com: domain of linux-kernel+bounces-204949-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Precedence: bulk
MIME-Version: 1.0
References: <20240606183921.1128911-1-masahiroy@kernel.org>
In-Reply-To: <20240606183921.1128911-1-masahiroy@kernel.org>
From: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>
Date: Thu, 6 Jun 2024 21:40:43 +0200
Message-ID: <CAKy8djTXYt=g_YZbyHJNNYLBKuBGDp4Ur-vGLU9LTnYgvp-L+A@mail.gmail.com>
Subject: Re: [PATCH] modpost: do not warn about missing MODULE_DESCRIPTION()
 for vmlinux.o
To: Masahiro Yamada <masahiroy@kernel.org>
Cc: linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, 
	Nathan Chancellor <nathan@kernel.org>, Nicolas Schier <nicolas@fjasle.eu>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

LGMT, thanks

Reviewed-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>


On Thu, Jun 6, 2024 at 8:39=E2=80=AFPM Masahiro Yamada <masahiroy@kernel.or=
g> wrote:
>
> Building with W=3D1 incorrectly emits the following warning:
>
>   WARNING: modpost: missing MODULE_DESCRIPTION() in vmlinux.o
>
> This check should apply only to modules.
>
> Fixes: 1fffe7a34c89 ("script: modpost: emit a warning when the descriptio=
n is missing")
> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
> ---
>
>  scripts/mod/modpost.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/scripts/mod/modpost.c b/scripts/mod/modpost.c
> index 937294ff164f..f48d72d22dc2 100644
> --- a/scripts/mod/modpost.c
> +++ b/scripts/mod/modpost.c
> @@ -1647,10 +1647,11 @@ static void read_symbols(const char *modname)
>                         namespace =3D get_next_modinfo(&info, "import_ns"=
,
>                                                      namespace);
>                 }
> +
> +               if (extra_warn && !get_modinfo(&info, "description"))
> +                       warn("missing MODULE_DESCRIPTION() in %s\n", modn=
ame);
>         }
>
> -       if (extra_warn && !get_modinfo(&info, "description"))
> -               warn("missing MODULE_DESCRIPTION() in %s\n", modname);
>         for (sym =3D info.symtab_start; sym < info.symtab_stop; sym++) {
>                 symname =3D remove_dot(info.strtab + sym->st_name);
>
> --
> 2.43.0
>