Received-SPF: pass (google.com: domain of linux-kernel+bounces-204960-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Date: Thu, 6 Jun 2024 14:55:58 -0500
From: Bjorn Helgaas <helgaas@kernel.org>
To: "Dr. David Alan Gilbert" <linux@treblig.org>
Cc: Jonathan Cameron <Jonathan.Cameron@huawei.com>, bhelgaas@google.com,
	rafael@kernel.org, linux-pci@vger.kernel.org,
	linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ACPI: PCI: Remove unused struct 'acpi_handle_node'
Message-ID: <20240606195558.GA816336@bhelgaas>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <Zk9cTVvPoyzM4hYm@gallifrey>

On Thu, May 23, 2024 at 03:10:05PM +0000, Dr. David Alan Gilbert wrote:
> * Jonathan Cameron (Jonathan.Cameron@Huawei.com) wrote:
> > On Thu,  9 May 2024 01:08:58 +0100
> > linux@treblig.org wrote:
> > 
> > > From: "Dr. David Alan Gilbert" <linux@treblig.org>
> > > 
> > > 'acpi_handle_node' is unused since
> > > Commit 63f534b8bad9 ("ACPI: PCI: Rework acpi_get_pci_dev()")
> > > Remove it.
> > > 
> > > Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
> > 
> > FWIW, indeed unused.
> > 
> > Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> 
> Thanks; any idea who would pick this up?

Applied with Jonathan's reviewed-by to pci/misc for v6.11, thanks!

Rafael, let me know if you want this instead.  Easy for me to drop if
you do.

> > > ---
> > >  drivers/acpi/pci_root.c | 5 -----
> > >  1 file changed, 5 deletions(-)
> > > 
> > > diff --git a/drivers/acpi/pci_root.c b/drivers/acpi/pci_root.c
> > > index 58b89b8d950ed..59e6955e24edb 100644
> > > --- a/drivers/acpi/pci_root.c
> > > +++ b/drivers/acpi/pci_root.c
> > > @@ -293,11 +293,6 @@ struct acpi_pci_root *acpi_pci_find_root(acpi_handle handle)
> > >  }
> > >  EXPORT_SYMBOL_GPL(acpi_pci_find_root);
> > >  
> > > -struct acpi_handle_node {
> > > -	struct list_head node;
> > > -	acpi_handle handle;
> > > -};
> > > -
> > >  /**
> > >   * acpi_get_pci_dev - convert ACPI CA handle to struct pci_dev
> > >   * @handle: the handle in question
> > 
> > 
> -- 
>  -----Open up your eyes, open up your mind, open up your code -------   
> / Dr. David Alan Gilbert    |       Running GNU/Linux       | Happy  \ 
> \        dave @ treblig.org |                               | In Hex /
>  \ _________________________|_____ http://www.treblig.org   |_______/