Received-SPF: pass (google.com: domain of linux-kernel+bounces-204963-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Date: Thu, 6 Jun 2024 20:58:13 +0100
From: Jonathan Cameron <jic23@kernel.org>
To: "Ceclan, Dumitru" <mitrutzceclan@gmail.com>
Cc: Dumitru Ceclan via B4 Relay
 <devnull+dumitru.ceclan.analog.com@kernel.org>, dumitru.ceclan@analog.com,
 Lars-Peter Clausen <lars@metafoo.de>, Michael Hennerich
 <Michael.Hennerich@analog.com>, Rob Herring <robh@kernel.org>, Krzysztof
 Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley
 <conor+dt@kernel.org>, David Lechner <dlechner@baylibre.com>,
 linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
 linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 1/6] dt-bindings: adc: ad7173: add support for ad411x
Message-ID: <20240606205813.65b342c4@jic23-huawei>
In-Reply-To: <0f0c0b92-af0d-4e68-9880-bacfd53d726f@gmail.com>
References: <20240531-ad4111-v4-0-64607301c057@analog.com>
	<20240531-ad4111-v4-1-64607301c057@analog.com>
	<20240601193512.0e17992b@jic23-huawei>
	<efa10caa-5e78-4f3f-8cca-c61d7a01e6fd@gmail.com>
	<20240603210014.6258134d@jic23-huawei>
	<0f0c0b92-af0d-4e68-9880-bacfd53d726f@gmail.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

On Wed, 5 Jun 2024 09:54:31 +0300
"Ceclan, Dumitru" <mitrutzceclan@gmail.com> wrote:

> On 03/06/2024 23:00, Jonathan Cameron wrote:
> > On Mon, 3 Jun 2024 12:46:10 +0300
> > "Ceclan, Dumitru" <mitrutzceclan@gmail.com> wrote:
> >  =20
> >> On 01/06/2024 21:35, Jonathan Cameron wrote: =20
> >>> On Fri, 31 May 2024 22:42:27 +0300
> >>> Dumitru Ceclan via B4 Relay <devnull+dumitru.ceclan.analog.com@kernel=
.org> wrote:
> >>>    =20
> >>>> From: Dumitru Ceclan <dumitru.ceclan@analog.com> =20
>=20
> ...
>=20
> >>>> +          Supported only by AD7172-2, AD7172-4, AD7175-2, AD7175-8,=
 AD7177-2:
> >>>> +            19: ((AVDD1 =E2=88=92 AVSS)/5)+
> >>>> +            20: ((AVDD1 =E2=88=92 AVSS)/5)=E2=88=92   =20
> >>>
> >>> That's what it says on the datasheet (so fine to copy that here) but =
I'm curious, what does
> >>> that mean in practice?  How can we have negative and postive signals =
of the difference
> >>> between two power supply voltages where I'm fairly sure AVDD1 always =
greater than AVSS.
> >>>   =20
> >>
> >> I have not tested that as I do not have a model that supports this wir=
ed up.
> >> If I had to guess they are the same signal but one should be connected=
 to the
> >> positive input, one to the negative input...but I could be wrong. =20
> >=20
> > If they are, then as far as I we are concerned is this one channel with=
 two
> > representations depending on whether it is 1st or 2nd in the list?
> > Can we use one number and hide that detail in the driver?
> >=20
> > Seems odd though if that is the case.
> >=20
> > I guess if we find out later this is the case we can tighten the bindin=
g to
> > enforce the right one instead of squashing them to one value, but that
> > is a bit ugly.  Any chance of digging out the info?  If not we can go a=
head
> > but ideally answering things like this make a our life easier in the lo=
ng run.
> >=20
> > Jonathan
> >  =20
>=20
> "(Avdd1/Avss)/5+ as positive input and (Avdd/Avss)/5- as negative
>   this is used for monitoring power supplies, the inputs must be selected=
 in pair"
> Perhaps it's an internal voltage divider...? I dunno
>=20
> So it seems like this cannot be used as a common mode voltage input.
> I'll restrict the driver to only allow these inputs paired together
> and rename the define for these selections.
Most mysterious :)  I'd be interested to know what value it reads
back if you ever get the part.

Ah well, great to have gotten that extra detail even if it leaves
more questions!

Jonathan

>=20
>=20
>=20