Received-SPF: pass (google.com: domain of linux-kernel+bounces-204965-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
From: "Luck, Tony" <tony.luck@intel.com>
To: Borislav Petkov <bp@alien8.de>
CC: "x86@kernel.org" <x86@kernel.org>, "Yu, Fenghua" <fenghua.yu@intel.com>,
	"Chatre, Reinette" <reinette.chatre@intel.com>, "Wieczor-Retman, Maciej"
	<maciej.wieczor-retman@intel.com>, Peter Newman <peternewman@google.com>,
	James Morse <james.morse@arm.com>, Babu Moger <babu.moger@amd.com>, "Drew
 Fustini" <dfustini@baylibre.com>, Dave Martin <Dave.Martin@arm.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"patches@lists.linux.dev" <patches@lists.linux.dev>
Subject: RE: [PATCH v3 1/2] cacheinfo: Add function to get cacheinfo for a
 given (cpu, cachelevel)
Thread-Topic: [PATCH v3 1/2] cacheinfo: Add function to get cacheinfo for a
 given (cpu, cachelevel)
Thread-Index: AQHauDBdYeGsvVFf40e5nFEfBMSU4rG7FovAgAANIfA=
Date: Thu, 6 Jun 2024 19:58:29 +0000
Message-ID: <SJ1PR11MB608331168096BFEBBB311EDCFCFA2@SJ1PR11MB6083.namprd11.prod.outlook.com>
References: <20240606164047.318378-1-tony.luck@intel.com>
 <20240606164047.318378-2-tony.luck@intel.com>
 <SJ1PR11MB60830475F52F359E116B2274FCFA2@SJ1PR11MB6083.namprd11.prod.outlook.com>
In-Reply-To: <SJ1PR11MB60830475F52F359E116B2274FCFA2@SJ1PR11MB6083.namprd11.prod.outlook.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?4XJvdg8VARgc7RekvYda5YP4VBuHCG34SItC6DqxbUNPA5TZUZ8m8qcc6NB7?=
 =?us-ascii?Q?vfGvSOMoeSYvquWx4dl4lNwSbjT3x08LRrm3MjtelQcckmzHuGsN10w8H9dj?=
 =?us-ascii?Q?0bdecQBw5CdAmEH98Tqz/kzVTEejGm8kX/U/nFhgHpfIjLpT0pJNdOP2dts5?=
 =?us-ascii?Q?Iv8Xyr546SQ2DNPLX6b7Nmds0uKuSpZwq8AuMUnk9O/muDo0DZFRIVsmhbIP?=
 =?us-ascii?Q?1rvuJz+dI4zdu+6VVibvhbUFlaFRyKROvdx/yfnIS4eI631lYjY6L1xPptx+?=
 =?us-ascii?Q?F5wlNaRxlBgTM4xuLUYJOaavHjNKvisqXyPpf0I1ytoPSjw9K0akSMaYKPyJ?=
 =?us-ascii?Q?9/G7SC1hM0KZ5vL3izhWj19xBYubbJ+hMcZPDcztB0wyUUUb+dLUB7Tk9cNs?=
 =?us-ascii?Q?RRM/JbH4jxWEME8euLfhdkPYqXDbLmyifQ8QbBUNFqn1EZNTEBrQogstFWVf?=
 =?us-ascii?Q?tn6hHoVWpE2w+6+PRKU9e3jLhQNJB+lOcE7shVmVaDWExAUgb8pHPKd75Cxl?=
 =?us-ascii?Q?PA40qz+TE/YVhNuNg9XY8XvrqhraZjOuOCJFh6qWwx7aU6gP3jKGSFZmVSlx?=
 =?us-ascii?Q?AITAn4QAdCyMR7UbUCqJmO9r0L69ws/g6gz9OPOIrMprd+n7OMPcWKk+mDHb?=
 =?us-ascii?Q?IdtfMxT04nDHce4BkrOFDtOpFAsbZ0aiuSHpsW+xDL8nOf0qd1fdHu/BZHJA?=
 =?us-ascii?Q?lxW8ClqiuxqqYu3ACtJjGmRwQt9lHc60BaKbwTLPSdEN01GUVvw4Snk1yepy?=
 =?us-ascii?Q?+lc7GcBU0ZOjtJRSSZCCJ9JcrX1cwFSGiIqdJu13W9UAeweqlOTZwFeLMJwl?=
 =?us-ascii?Q?gd9KpcrvYDGSCMjDoDjWCd8IdmUHCrOPYNXaK0EJ7bJkUuzGr3vh/arEoex1?=
 =?us-ascii?Q?ERCSXwBE2p9SnUX2J50TXTY7aN7uSN9OnSv5+/Qwn3ebaaH6nl5RIJ0zPVy4?=
 =?us-ascii?Q?gapFhe/dnN4K5O2OBxNsHXuTwtYS56fO5knRvNIF/qzPtH43vfXmhs+Tskmj?=
 =?us-ascii?Q?74Hi/twYDwTx0N/s73vPs2mCAsSiasDjy7SK82KR2uNMXLMhI3Lk74UcNyIp?=
 =?us-ascii?Q?EPNX6UtE7fmd9264FJL3FbdHB134kRe6jtPsFMwPwISPfwoEx4wu4WGa4bBF?=
 =?us-ascii?Q?yNlfk3iuNXnQ2OWXeQAR3bJwxDJ+znOwCu1ciYrbjPmMdcdxe8Eow9W1akj9?=
 =?us-ascii?Q?jFz7UsI9KiXqbgIKk2kQKSjkSrBzPlxN86IWR7N78xPo6B+zLju1K2oaccEp?=
 =?us-ascii?Q?bnYcjEIykpo15LJzw+OKpaZj4KwW+JRkjDHREWsYoh3bQ0Fv1u02qKtpu2ar?=
 =?us-ascii?Q?Q4asg8MzBHDsj8/1L9tVlS95HC5uJic+PQD4wVOmUthHfsnh6g46TnpGX1yM?=
 =?us-ascii?Q?IMOQ/G5DFOnCNe52AlYsRmc0c2Ie5ukZE+DLtxMdI9G97Scuuw2kHY+rbSol?=
 =?us-ascii?Q?8imKn9HY3/Do8tm4Drl91zklTTlBukuo9a0vHJ2iCMqKL3wmikUTmJwIziwY?=
 =?us-ascii?Q?XzQ1zzsAA+BxdCd5WXozRWtDw7eFdJ2qQDtrddGIdU0FOKKpdCIa8DE0oldJ?=
 =?us-ascii?Q?506ONmloUSnRxamV1hqiUtLCVbo3XVaoUUNKMI/j?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SJ1PR11MB6083.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5cc9e33e-5d9a-49c6-3668-08dc8663090c
X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Jun 2024 19:58:29.1069
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: KvJUdWFH3l/H6H4hAM4hJ9uMek6HL9HIa92eW/t/G6VRkCzG1SW5PnmnK81qBpR/WW0W9gpGbfdGm9e9m0VX1w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR11MB7774
X-OriginatorOrg: intel.com

> +     lockdep_assert_cpus_held();
> +
>
> lkp says this breaks riscv-allnoconfig and riscv-defconfig
>
>    In file included from arch/riscv/include/asm/cacheinfo.h:9:
> >> include/linux/cacheinfo.h:126:2: error: call to undeclared function 'l=
ockdep_assert_cpus_held'; ISO C99 and later do not support implicit functio=
n declarations [-Wimplicit-function-declaration]
>      126 |         lockdep_assert_cpus_held();
>
> but I'm not really sure why. I added "#include <linux/cpu.h>" to <linux/c=
puinfo,h> to deal with similar warning when building for x86.

Ah. The full trace from lkp explains:

   In file included from io_uring/io_uring.c:45:
   In file included from include/linux/syscalls.h:93:
   In file included from include/trace/syscall.h:5:
   In file included from include/linux/tracepoint.h:22:
   In file included from include/linux/static_call.h:135:
   In file included from include/linux/cpu.h:17:                    <<<< on=
ly part way through cpu.h, lockdep_assert_cpus_held not defined yet
   In file included from include/linux/node.h:18:
   In file included from include/linux/device.h:32:
   In file included from include/linux/device/driver.h:21:
   In file included from include/linux/module.h:19:
   In file included from include/linux/elf.h:6:
   In file included from arch/riscv/include/asm/elf.h:16:
   In file included from arch/riscv/include/asm/cacheinfo.h:9:   <<< doesn'=
t matter that this includes cpu.h because of #ifndef _LINUX_CPU_H_

>> include/linux/cacheinfo.h:126:2: error: call to undeclared function 'loc=
kdep_assert_cpus_held'; ISO C99 and later do not support implicit function =
declarations [-Wimplicit-function-declaration]
     126 |         lockdep_assert_cpus_held();

So this is #include hell that many others have complained about.


How much do you *REALLY* want that lockdep_assert_cpus_held() to be in <lin=
ux/cacheinfo.h>

The lack of an assert did not come up when James added get_cpu_cacheinfo_id=
()

   https://lkml.kernel.org/r/20200708163929.2783-11-james.morse@arm.com

-Tony