Received-SPF: pass (google.com: domain of linux-kernel+bounces-204972-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Thu, 6 Jun 2024 21:12:22 +0100
From: Jonathan Cameron <jic23@kernel.org>
To: Conor Dooley <conor@kernel.org>
Cc: Josua Mayer <josua@solid-run.com>, Andrew Lunn <andrew@lunn.ch>, Gregory
 Clement <gregory.clement@bootlin.com>, Sebastian Hesselbarth
 <sebastian.hesselbarth@gmail.com>, Rob Herring <robh+dt@kernel.org>,
 Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley
 <conor+dt@kernel.org>, Rob Herring <robh@kernel.org>, Krzysztof Kozlowski
 <krzk+dt@kernel.org>, Lars-Peter Clausen <lars@metafoo.de>, Daniel Baluta
 <daniel.baluta@nxp.com>, Vinod Koul <vkoul@kernel.org>, Kishon Vijay
 Abraham I <kishon@kernel.org>, Konstantin Porotchkin <kostap@marvell.com>,
 Richard Cochran <richardcochran@gmail.com>, Yazan Shhady
 <yazan.shhady@solid-run.com>, linux-arm-kernel@lists.infradead.org,
 devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
 linux-iio@vger.kernel.org, linux-phy@lists.infradead.org,
 netdev@vger.kernel.org
Subject: Re: [PATCH v6 3/7] dt-bindings: iio: adc: ti,ads1015: add
 compatible for tla2021
Message-ID: <20240606211222.3b0f7a01@jic23-huawei>
In-Reply-To: <20240604-suspend-schnapps-191d2c1ad53e@spud>
References: <20240602-cn9130-som-v6-0-89393e86d4c7@solid-run.com>
	<20240602-cn9130-som-v6-3-89393e86d4c7@solid-run.com>
	<20240604-suspend-schnapps-191d2c1ad53e@spud>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Tue, 4 Jun 2024 18:42:46 +0100
Conor Dooley <conor@kernel.org> wrote:

> On Sun, Jun 02, 2024 at 05:49:38PM +0200, Josua Mayer wrote:
> > TI tla2021 is a limited single-channel variant of tla2024 which is
> > similar enough to be easily supportable through the same driver.
> > 
> > Add compatible string for tla2021 so boards may describe it in
> > device-tree.
> > 
> > Signed-off-by: Josua Mayer <josua@solid-run.com>  
> 
> Acked-by: Conor Dooley <conor.dooley@microchip.com>

This binding has per channel descriptions. Perhaps for this device
it should be updated to include a restriction on number of
such sub nodes (probably via the reg value in them) ?

Mind you it's currently 8 and the ti,tla2024 only has 4.
So a possible job for another day, hopefully alongside the
driver support and the tla2022 which seems to be the 2 channel
version.

Applied.

Thanks,

Jonathan

> 
> Thanks,
> Conor.
> 
> > ---
> >  Documentation/devicetree/bindings/iio/adc/ti,ads1015.yaml | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/iio/adc/ti,ads1015.yaml b/Documentation/devicetree/bindings/iio/adc/ti,ads1015.yaml
> > index d605999ffe28..718f633c6e04 100644
> > --- a/Documentation/devicetree/bindings/iio/adc/ti,ads1015.yaml
> > +++ b/Documentation/devicetree/bindings/iio/adc/ti,ads1015.yaml
> > @@ -18,6 +18,7 @@ properties:
> >      enum:
> >        - ti,ads1015
> >        - ti,ads1115
> > +      - ti,tla2021
> >        - ti,tla2024
> >  
> >    reg:
> > 
> > -- 
> > 2.35.3
> >