Received-SPF: pass (google.com: domain of linux-kernel+bounces-204997-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <9a7213d2-a782-4342-93f2-acf191c745fd@intel.com>
Date: Thu, 6 Jun 2024 13:33:52 -0700
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] selftests/resctrl: Fix noncont_cat_run_test for AMD
To: Babu Moger <babu.moger@amd.com>, <fenghua.yu@intel.com>,
	<shuah@kernel.org>
CC: <linux-kernel@vger.kernel.org>, <linux-kselftest@vger.kernel.org>,
	<ilpo.jarvinen@linux.intel.com>, <maciej.wieczor-retman@intel.com>,
	<peternewman@google.com>, <eranian@google.com>
References: <3a6c9dd9dc6bda6e2582db049bfe853cd836139f.1717622080.git.babu.moger@amd.com>
From: Reinette Chatre <reinette.chatre@intel.com>
Content-Language: en-US
In-Reply-To: <3a6c9dd9dc6bda6e2582db049bfe853cd836139f.1717622080.git.babu.moger@amd.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MGpvZmxmWnZiYlBScGVJZlhpY1BTTU9NVmdkL2FQbDZibFhBUUwrKzdpS01U?=
 =?utf-8?B?Yis2R1M5NStSU1IybURVc2xzZ2pEdm9hN3JWaFJmb2pMVDh2R1FseG9GRXV5?=
 =?utf-8?B?dkFpYVZkSDA3U1psdkdnQU5oZ1JMVjJqRlFRZndGL0dkblJyTSs1TVdLU1hs?=
 =?utf-8?B?d2pGMlVsN1hXQndRdHBvL2ZEYm1vcEwzSmwwQkNWTGE3OHdsR0hremJuQW9X?=
 =?utf-8?B?cW9GNWJhU005WTBXUkNjMjJMM2FWZFlldmplSlZjd1NENVlhbjBZNHBlcXVn?=
 =?utf-8?B?akRjeGlhcEZMTVpFS0wvTkNQUnRhU1RySmpiUFhkNEdIZFRMTGJrSkcwM2sx?=
 =?utf-8?B?eUhCSS9GdWgvVDlzNldIcTRYOFJzT2FHdkp2MHN0YngrUEQvQ2tSdzdBRElD?=
 =?utf-8?B?WVZZY3RGMkw2dmo1MEhHckYzK2pOUllOZzljWXcyYWxFVlU0ODVLRGR0UWpI?=
 =?utf-8?B?ZmZkcFJNZDhRK05razFpWnlqdW5nQ0xFUFdTN2c5Q1BGclFBQ1ozSWFYVWdz?=
 =?utf-8?B?M2EzMnl6dUNlODIxZXBLdUM1S2xjQTdSZ1Z5V0x1bnBzWlBEN09XUktyRXJ3?=
 =?utf-8?B?bzJjOUxwZkg1TnVqVlIvelVzc0VWd29TV05hNWtWakY1aEJJdHhvMjllc3Ns?=
 =?utf-8?B?bzZKSERJcVVTQU9XaDE2MGFNS21xQUZFR09JZmRwbi8zdlYzWmlmRDJyZGU4?=
 =?utf-8?B?OXBIdjJxSVdkV0dkNytqR2lQK2o1RjVhelgrMmNNeENQSXBRMU9pNkRMenlJ?=
 =?utf-8?B?Ly9RQkRET2locEJSc1F0RjVVLys3TXdaRDdIZW1mVVA0cjVCT0lHcXpnY0xX?=
 =?utf-8?B?R05IUGNtQm9YYXB5alpmUXJ6YWROdUUzMDVLMjNkR24vazJ4NlFiVGN1VllN?=
 =?utf-8?B?N0JFZkU4akRDcUVnOXJCNVhMTXVkUDYwdStpdUxKMXJ4N2dxekt4UXZpZ2NZ?=
 =?utf-8?B?SGFqay9kVDZZVDF4SXdZazlJTmhkTlZvYW9wWXVSRHcwcHB6Z3Bxa1RRbmZk?=
 =?utf-8?B?UmtucGU5TGhwcnFIY3pLcVlLREZoUE5FV0RZTTBieUlNWUF2dDRsdzQwZXZu?=
 =?utf-8?B?QmZtNERxdWV0WlpPaEJ3Ri9idThTaDZ2L1NZeFpnOG5ud3kyK0xISjBzTXhh?=
 =?utf-8?B?bVZhMzRha0d2RWcwL0xKVFFPWVFmV2lFeTZiemppSXhOb2dlK3YxNTdWK1Nn?=
 =?utf-8?B?Z1AvMENJNXJVTGNiUzd4dkUwaURJazRiakl6Y201azNyRkJxeGdQTUpsVENY?=
 =?utf-8?B?Y3hLL1huR3JWQXNMWGNQR0RXdnZnYWxNSXlyQmFENXlTUmwrT2w1cmpsdUpK?=
 =?utf-8?B?dEthS2gzZGhCdVhPVjd5S3NUQ0o5VCs2NHUvREVFM3Y2cHpySCtkMzFjR21s?=
 =?utf-8?B?V0wvNExEZkhJZlU1VndQS2pqR2hWa0gyekxQNkdEZU8yMlFWY2RHejlBWHV1?=
 =?utf-8?B?eTg1bUIyK0s3a1RzN1JLMjBlNDN0aFZFYmlzMEc4U0c3aVNvQzZsdyt2SFM5?=
 =?utf-8?B?OVVJWi91VGplNmZZM0lhcEdOUi9vcGsrQmc1VVFtcksxaXFIYnNkUDdXR283?=
 =?utf-8?B?akVSUElySU9RUC8vT01wYjR0T0FIWGJOQVdFR0gwWC9EZTgvd1d1L0ZNY2kw?=
 =?utf-8?B?NXQzSlZ6NnZWL0M3N0RlQW1rWmZtNWsyN0FhMHNBY3Z5QTR0dC84eWxHb3Bu?=
 =?utf-8?B?MDlKeGpZTkRYbHdLV1FLUVorY0VVaVREcVdlSnB3alNrQzNWRXlVdjZybkZD?=
 =?utf-8?B?SW9yMjRrVXRtL0p5M3lKbldhWCtPL1B2TmZDSzZ6Yk85OW5ZbnRrai9ucUNw?=
 =?utf-8?B?VDRxaXk2N0IrSng0NkpLck1ERnRDV0pNeklETEExUHowOUVXVkhzQVZaUGw3?=
 =?utf-8?B?Y2tHYkFuQUdwclkvSWl3c0VSVksvTWtXS2x4cCtXdk9ZemZ3QjNqRXFRNlZP?=
 =?utf-8?B?OFI4VVA3MWhLWEtQcGU5cEJ1YXpIeFRmWno1VzJhWml4VGNZR2hIQjVmK08r?=
 =?utf-8?B?MDBTQjBaaVBmN3BieDAvcE5CL3hJSWNsOFhwKzJLMC9yS2dLR1ZGWGtMaXl1?=
 =?utf-8?B?ZGNzY01pL1FrOU5sMUo5YndFMVhKNGEzTVVXbEc2WC9iUVVROVk5cUU4UnpK?=
 =?utf-8?B?MXZoa3c0cjMrSlBHRTdwK20yL20ySXpEOUdQSGV3TGg5anRLeHc0RFVBV255?=
 =?utf-8?B?K0E9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: bc5dbb3b-6c27-410d-2989-08dc8667fbb8
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Jun 2024 20:33:54.3777
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 7e+0e5CTduj1Ypyuot4PfwLW2mGV8bJE7QLnhprFbTdXA1KKdP8s0p8sUk0UCXOAvkT/+UFrT9+ZXOwKHuyzLNgnChlEtowI/E4CZ3eFyfE=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR11MB5162
X-OriginatorOrg: intel.com

Hi Babu,

On 6/5/24 2:36 PM, Babu Moger wrote:
> The selftest noncont_cat_run_test fails on AMD with the warnings. Reason
> is, AMD supports non contiguous CBM masks but does not report it via CPUID.
> 
> Update noncont_cat_run_test to check for the vendor when verifying CPUID.
> 
> Fixes: ae638551ab64 ("selftests/resctrl: Add non-contiguous CBMs CAT test")
> Signed-off-by: Babu Moger <babu.moger@amd.com>
> ---
> This was part of the series
> https://lore.kernel.org/lkml/cover.1708637563.git.babu.moger@amd.com/
> Sending this as a separate fix per review comments.
> ---
>   tools/testing/selftests/resctrl/cat_test.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/testing/selftests/resctrl/cat_test.c b/tools/testing/selftests/resctrl/cat_test.c
> index d4dffc934bc3..b2988888786e 100644
> --- a/tools/testing/selftests/resctrl/cat_test.c
> +++ b/tools/testing/selftests/resctrl/cat_test.c
> @@ -308,7 +308,7 @@ static int noncont_cat_run_test(const struct resctrl_test *test,
>   	else
>   		return -EINVAL;
>   
> -	if (sparse_masks != ((ecx >> 3) & 1)) {
> +	if ((get_vendor() == ARCH_INTEL) && sparse_masks != ((ecx >> 3) & 1)) {
>   		ksft_print_msg("CPUID output doesn't match 'sparse_masks' file content!\n");
>   		return 1;
>   	}

Since AMD does not report this support via CPUID it does not seem
appropriate to use CPUID at all on AMD when doing the hardware check.
I think the above check makes it difficult to understand what is different
on AMD.

What if instead there is a new function, for example,
"static bool arch_supports_noncont_cat(const struct resctrl_test *test)"
that returns true if the hardware supports non-contiguous CBM?

The vendor check can be in there to make it obvious what is going on:

	/* AMD always supports non-contiguous CBM. */
	if (get_vendor() == AMD)
		return true;

	/* CPUID check for Intel here. */

The "sparse_masks" from kernel can then be checked against
hardware support with an appropriate (no mention of CPUID)
error message if this fails.

Reinette