Received-SPF: pass (google.com: domain of linux-kernel+bounces-205018-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Precedence: bulk
MIME-Version: 1.0
References: <20240606174203124_OW-VQZ_ZLm4lGEimA-K9@zte.com.cn> <51DED95F-832A-4836-AA81-556968F6B645@nvidia.com>
In-Reply-To: <51DED95F-832A-4836-AA81-556968F6B645@nvidia.com>
From: Barry Song <21cnbao@gmail.com>
Date: Fri, 7 Jun 2024 09:00:33 +1200
Message-ID: <CAGsJ_4w9cRZUEF7PaVjz1HQoUr1pxHEO15gpbsnAoJHMZG0djQ@mail.gmail.com>
Subject: Re: [PATCH linux-next v2] mm: huge_memory: fix misused
 mapping_large_folio_support() for anon folios
To: Zi Yan <ziy@nvidia.com>
Cc: xu.xin16@zte.com.cn, david@redhat.com, v-songbaohua@oppo.com, 
	akpm@linux-foundation.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, 
	mhocko@kernel.org, yang.yang29@zte.com.cn, ran.xiaokai@zte.com.cn, 
	Matthew Wilcox <willy@infradead.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Fri, Jun 7, 2024 at 2:35=E2=80=AFAM Zi Yan <ziy@nvidia.com> wrote:
>
> +Matthew
>
> For mapping_large_folio_support() changes.
>
> On 6 Jun 2024, at 2:42, xu.xin16@zte.com.cn wrote:
>
> > From: Ran Xiaokai <ran.xiaokai@zte.com.cn>
> >
> > When I did a large folios split test, a WARNING
> > "[ 5059.122759][  T166] Cannot split file folio to non-0 order"
> > was triggered. But the test cases are only for anonmous folios.
> > while mapping_large_folio_support() is only reasonable for page
> > cache folios.
> >
> > In split_huge_page_to_list_to_order(), the folio passed to
> > mapping_large_folio_support() maybe anonmous folio. The
> > folio_test_anon() check is missing. So the split of the anonmous THP
> > is failed. This is also the same for shmem_mapping(). We'd better add
> > a check for both. But the shmem_mapping() in __split_huge_page() is
> > not involved, as for anonmous folios, the end parameter is set to -1, s=
o
> > (head[i].index >=3D end) is always false. shmem_mapping() is not called=
.
> >
> > Also add a VM_WARN_ON_ONCE() in mapping_large_folio_support()
> > for anon mapping, So we can detect the wrong use more easily.
> >
> > THP folios maybe exist in the pagecache even the file system doesn't
> > support large folio, it is because when CONFIG_TRANSPARENT_HUGEPAGE
> > is enabled, khugepaged will try to collapse read-only file-backed pages
> > to THP. But the mapping does not actually support multi order
> > large folios properly.
> >
> > Using /sys/kernel/debug/split_huge_pages to verify this, with this
> > patch, large anon THP is successfully split and the warning is ceased.
> >
> > Signed-off-by: Ran Xiaokai <ran.xiaokai@zte.com.cn>
> > ---
> >  include/linux/pagemap.h |  4 ++++
> >  mm/huge_memory.c        | 27 ++++++++++++++++-----------
> >  2 files changed, 20 insertions(+), 11 deletions(-)
> >
> > diff --git a/include/linux/pagemap.h b/include/linux/pagemap.h
> > index ee633712bba0..59f1df0cde5a 100644
> > --- a/include/linux/pagemap.h
> > +++ b/include/linux/pagemap.h
> > @@ -381,6 +381,10 @@ static inline void mapping_set_large_folios(struct=
 address_space *mapping)
> >   */
> >  static inline bool mapping_large_folio_support(struct address_space *m=
apping)
> >  {
> > +     /* AS_LARGE_FOLIO_SUPPORT is only reasonable for pagecache folios=
 */
> > +     VM_WARN_ONCE((unsigned long)mapping & PAGE_MAPPING_ANON,
> > +                     "Anonymous mapping always supports large folio");
> > +
> >       return IS_ENABLED(CONFIG_TRANSPARENT_HUGEPAGE) &&
> >               test_bit(AS_LARGE_FOLIO_SUPPORT, &mapping->flags);
> >  }
> > diff --git a/mm/huge_memory.c b/mm/huge_memory.c
> > index 317de2afd371..62d57270b08e 100644
> > --- a/mm/huge_memory.c
> > +++ b/mm/huge_memory.c
> > @@ -3009,30 +3009,35 @@ int split_huge_page_to_list_to_order(struct pag=
e *page, struct list_head *list,
> >       if (new_order >=3D folio_order(folio))
> >               return -EINVAL;
> >
> > -     /* Cannot split anonymous THP to order-1 */
> > -     if (new_order =3D=3D 1 && folio_test_anon(folio)) {
> > -             VM_WARN_ONCE(1, "Cannot split to order-1 folio");
> > -             return -EINVAL;
> > -     }
> > -
> > -     if (new_order) {
> > -             /* Only swapping a whole PMD-mapped folio is supported */
> > -             if (folio_test_swapcache(folio))
> > +     if (folio_test_anon(folio)) {
> > +             /* Cannot split anonymous THP to order-1 */
> > +             if (new_order =3D=3D 1) {
> > +                     VM_WARN_ONCE(1, "Cannot split to order-1 folio");
> >                       return -EINVAL;
> > +             }
> > +     } else if (new_order) {
> >               /* Split shmem folio to non-zero order not supported */
> >               if (shmem_mapping(folio->mapping)) {
> >                       VM_WARN_ONCE(1,
> >                               "Cannot split shmem folio to non-0 order"=
);
> >                       return -EINVAL;
> >               }
> > -             /* No split if the file system does not support large fol=
io */
> > -             if (!mapping_large_folio_support(folio->mapping)) {
> > +             /* No split if the file system does not support large fol=
io.
> > +              * Note that we might still have THPs in such mappings du=
e to
> > +              * CONFIG_READ_ONLY_THP_FOR_FS. But in that case, the map=
ping
> > +              * does not actually support large folios properly.
> > +              */
> > +             if (IS_ENABLED(CONFIG_READ_ONLY_THP_FOR_FS) &&
> > +                     !mapping_large_folio_support(folio->mapping)) {
>
> Shouldn=E2=80=99t this be
>
> if (!IS_ENABLED(CONFIG_READ_ONLY_THP_FOR_FS) &&
>         !mapping_large_folio_support(folio->mapping)) {
>
> ?
>
> When CONFIG_READ_ONLY_THP_FOR_FS is not set, we need to check
> mapping_large_folio_support(), otherwise we do not.

while CONFIG_READ_ONLY_THP_FOR_FS is not set, that is no way
a large folio can be mapped to a filesystem which doesn't support
large folio mapping. i think
if (IS_ENABLED(CONFIG_READ_ONLY_THP_FOR_FS)) is correct.

The below means a BUG which has never a chance to happen if it
is true.

!IS_ENABLED(CONFIG_READ_ONLY_THP_FOR_FS) &&
        !mapping_large_folio_support(folio->mapping));

>
> >                       VM_WARN_ONCE(1,
> >                               "Cannot split file folio to non-0 order")=
;
> >                       return -EINVAL;
> >               }
> >       }
> >
> > +     /* Only swapping a whole PMD-mapped folio is supported */
> > +     if (folio_test_swapcache(folio) && new_order)
> > +             return -EINVAL;
> >
> >       is_hzp =3D is_huge_zero_folio(folio);
> >       if (is_hzp) {
> > --
> > 2.15.2
>
>
> Best Regards,
> Yan, Zi

Thanks
Barry