Received-SPF: pass (google.com: domain of linux-kernel+bounces-205029-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Thu, 6 Jun 2024 17:08:11 -0400
From: Frank Li <Frank.li@nxp.com>
To: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Cc: Vignesh Raghavendra <vigneshr@ti.com>,
	Siddharth Vadapalli <s-vadapalli@ti.com>,
	Lorenzo Pieralisi <lpieralisi@kernel.org>,
	Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= <kw@linux.com>,
	Rob Herring <robh@kernel.org>, Bjorn Helgaas <bhelgaas@google.com>,
	Richard Zhu <hongxing.zhu@nxp.com>,
	Lucas Stach <l.stach@pengutronix.de>,
	Shawn Guo <shawnguo@kernel.org>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	Fabio Estevam <festevam@gmail.com>,
	Minghuan Lian <minghuan.Lian@nxp.com>,
	Mingkai Hu <mingkai.hu@nxp.com>, Roy Zang <roy.zang@nxp.com>,
	Jesper Nilsson <jesper.nilsson@axis.com>,
	Jingoo Han <jingoohan1@gmail.com>,
	Srikanth Thokala <srikanth.thokala@intel.com>,
	Marek Vasut <marek.vasut+renesas@gmail.com>,
	Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>,
	Thierry Reding <thierry.reding@gmail.com>,
	Jonathan Hunter <jonathanh@nvidia.com>,
	Kunihiko Hayashi <hayashi.kunihiko@socionext.com>,
	Masami Hiramatsu <mhiramat@kernel.org>,
	Kishon Vijay Abraham I <kishon@kernel.org>,
	linux-omap@vger.kernel.org, linux-pci@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
	imx@lists.linux.dev, linuxppc-dev@lists.ozlabs.org,
	linux-arm-kernel@axis.com, linux-arm-msm@vger.kernel.org,
	linux-renesas-soc@vger.kernel.org, linux-tegra@vger.kernel.org,
	mhi@lists.linux.dev, Niklas Cassel <cassel@kernel.org>,
	Bjorn Helgaas <helgaas@kernel.org>
Subject: Re: [PATCH 1/5] PCI: dwc: ep: Remove dw_pcie_ep_init_notify() wrapper
Message-ID: <ZmIlO+kVWV+C1QiA@lizhi-Precision-Tower-5810>
References: <20240606-pci-deinit-v1-0-4395534520dc@linaro.org>
 <20240606-pci-deinit-v1-1-4395534520dc@linaro.org>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240606-pci-deinit-v1-1-4395534520dc@linaro.org>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?gO+aqO65ljzF9JhriNTewCs2lCm1zkQIiqPf8UQzjuIcDruY+nvirlsy9erP?=
 =?us-ascii?Q?8rKtDBzV2hZYGcM9NxGAm7HZ5MkefJ4VuLLZjsPZeqWMwgwzW7UJA2mP9Qk/?=
 =?us-ascii?Q?Z8RGpngyOuigbSFZac8et+fUxSNtYgTPnxVeKTQsp0TG2FefE4CVE/wwnmGg?=
 =?us-ascii?Q?zNUaQ7X4mCDfyz8zVh5cFsAGh7mNTx2mlo0JlzVRaEyRkTujv+mpLWJh4cxa?=
 =?us-ascii?Q?Ji8Lg4QCMrMPppDiOJ+5+1qw4z5UVDhIkjiuHaNcYFbZJc+N4MS6GuDg1uBs?=
 =?us-ascii?Q?qKykqG050ZFTdUUSLLJSoL/2l5ow8t8vkytVz6YCp3n4I2H584q1+04wH7ef?=
 =?us-ascii?Q?XYxMwu5onJ8PlF+kATmp7CvMA1DGQT1qqGYhOf+HmEy8yI476J3z83SOZHp6?=
 =?us-ascii?Q?aDs6APQhCgkL4vdsHpxBm/PhM0hOPN+nPBkBPxwQNpwEq1Mfraj0bQyIYr9/?=
 =?us-ascii?Q?UdInFS8CBcuflGskTaQ4NZL83EP6JLcIZvp3HC21fnVrqahBe2qVe/ahdCj6?=
 =?us-ascii?Q?gm6jmb0x9LQ1g+Ks+GzDra6gF4tawA2oUOVgqPMrcqAzcpogyY5NlfsGzqcv?=
 =?us-ascii?Q?jyGWLTwLKNgzOcErZzYOyAf2e0zJhebO8byHoFMtDtslEI60c5T3nhKnJTCm?=
 =?us-ascii?Q?ayByogVHQvX+OYTrXOVdhgNp6Qz8n2Bs67IpdDkW3m2sjSegQmtDdn9Lbs92?=
 =?us-ascii?Q?QxwL0YK3LMjnMrju0lfYB+8CpbM9RqqnoUg4036lOWkUkCLKJ+oFhc5+aQUf?=
 =?us-ascii?Q?dnHa2aj4Iz+5xrXu8QeExUtDe6pDVe0FokRWDrIYcEB+AzXw6afJ9NJ3Ttt6?=
 =?us-ascii?Q?7vfGiU0RMZ0Eal9GeLk6oqT+upoTtyUisLF/u4LkRGB2LQbRcMcMUi7x3hEy?=
 =?us-ascii?Q?15NJiGPu+E7uPUn2gB/sy7H8sOe5hffWfB+/bjO4DyKyGAlnn7V00QgCI/u7?=
 =?us-ascii?Q?A/MNZcjWA8fMBGlwLdj+A017BCGw/m+52+yQJWSBmF8upANbMVfQu8h7otUR?=
 =?us-ascii?Q?jcY7p1cj+MzmwyDVL9Emzvg0/kkYyHsPgH753LRqpUl8mYXJj2Kh7Uww3wFX?=
 =?us-ascii?Q?k33i4eGV6w5fCrpUus5R2PBsGXX9Z6kgDl3yKwRGJRqjfpN2upyHr8A3pwlf?=
 =?us-ascii?Q?+UbUsNa337G2zBiKu7BhbI1+UGdUTAOEWeYVnDqpUI4VTqIGv1+mClTYQLY9?=
 =?us-ascii?Q?ArG6vWZYRBiPaTpxKm4g+FXazsIeurzB7IGN0UYth9dDQ353vwMrOdbVD6l4?=
 =?us-ascii?Q?zT99rhsARnQCx1z/h89/14h62In9UaljX9aqqscwGMlF7NBoeWXvR0QVV+El?=
 =?us-ascii?Q?IZvoFfXrOGeG53eIvuqK7duY0Dz9lA33aTzRRu6Ey25hBg4oBOSnloGmIAWx?=
 =?us-ascii?Q?uHMo/9shoswEqG31el5hb6y+fdGRf0zLI0TZjTY9fVAiUA1Tr030i8xmiffz?=
 =?us-ascii?Q?UHxNfGZUtf4/T6bqBFhen9iy0X0Fvu/P2XL5FGOY6GAMtIMStFhZbPFTwojc?=
 =?us-ascii?Q?g/XQa9UBC2mY6TWKkvsMUUA17KAOWQfL9iiMM0SURKBrT5xvEaK+w3a28Nue?=
 =?us-ascii?Q?OMB/SO67CBY+5maDUU2jG3TkieDR4dGw64ICmBvl?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 57b188bb-ae03-4173-6833-08dc866ccd86
X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9642.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Jun 2024 21:08:24.4682
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: bDTq7qRU3pMpwxMqjXkkuzHwRKY/OTUQRpwCsQon00Uz/7Fjb8y4AC6jYjUHgVvcwsBf58XyUV4LsrO524ZYFA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA1PR04MB10208

On Thu, Jun 06, 2024 at 12:56:34PM +0530, Manivannan Sadhasivam wrote:
> Currently dw_pcie_ep_init_notify() wrapper just calls pci_epc_init_notify()
> directly. So this wrapper provides no benefit to the glue drivers.
> 
> So let's remove it and call pci_epc_init_notify() directly from glue
> drivers.
> 
> Suggested-by: Bjorn Helgaas <helgaas@kernel.org>
> Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>

Reviewed-by: Frank Li <Frank.Li@nxp.com>

> ---
>  drivers/pci/controller/dwc/pci-dra7xx.c           |  2 +-
>  drivers/pci/controller/dwc/pci-imx6.c             |  2 +-
>  drivers/pci/controller/dwc/pci-keystone.c         |  2 +-
>  drivers/pci/controller/dwc/pci-layerscape-ep.c    |  2 +-
>  drivers/pci/controller/dwc/pcie-artpec6.c         |  2 +-
>  drivers/pci/controller/dwc/pcie-designware-ep.c   | 12 ------------
>  drivers/pci/controller/dwc/pcie-designware-plat.c |  2 +-
>  drivers/pci/controller/dwc/pcie-designware.h      |  5 -----
>  drivers/pci/controller/dwc/pcie-keembay.c         |  2 +-
>  drivers/pci/controller/dwc/pcie-qcom-ep.c         |  2 +-
>  drivers/pci/controller/dwc/pcie-rcar-gen4.c       |  2 +-
>  drivers/pci/controller/dwc/pcie-tegra194.c        |  2 +-
>  drivers/pci/controller/dwc/pcie-uniphier-ep.c     |  2 +-
>  13 files changed, 11 insertions(+), 28 deletions(-)
> 
> diff --git a/drivers/pci/controller/dwc/pci-dra7xx.c b/drivers/pci/controller/dwc/pci-dra7xx.c
> index d2d17d37d3e0..e491d0ff3962 100644
> --- a/drivers/pci/controller/dwc/pci-dra7xx.c
> +++ b/drivers/pci/controller/dwc/pci-dra7xx.c
> @@ -474,7 +474,7 @@ static int dra7xx_add_pcie_ep(struct dra7xx_pcie *dra7xx,
>  		return ret;
>  	}
>  
> -	dw_pcie_ep_init_notify(ep);
> +	pci_epc_init_notify(ep->epc);
>  
>  	return 0;
>  }
> diff --git a/drivers/pci/controller/dwc/pci-imx6.c b/drivers/pci/controller/dwc/pci-imx6.c
> index 917c69edee1d..a876b8e6e741 100644
> --- a/drivers/pci/controller/dwc/pci-imx6.c
> +++ b/drivers/pci/controller/dwc/pci-imx6.c
> @@ -1131,7 +1131,7 @@ static int imx6_add_pcie_ep(struct imx6_pcie *imx6_pcie,
>  		return ret;
>  	}
>  
> -	dw_pcie_ep_init_notify(ep);
> +	pci_epc_init_notify(ep->epc);
>  
>  	/* Start LTSSM. */
>  	imx6_pcie_ltssm_enable(dev);
> diff --git a/drivers/pci/controller/dwc/pci-keystone.c b/drivers/pci/controller/dwc/pci-keystone.c
> index d3a7d14ee685..ca1054f5c79a 100644
> --- a/drivers/pci/controller/dwc/pci-keystone.c
> +++ b/drivers/pci/controller/dwc/pci-keystone.c
> @@ -1293,7 +1293,7 @@ static int ks_pcie_probe(struct platform_device *pdev)
>  			goto err_ep_init;
>  		}
>  
> -		dw_pcie_ep_init_notify(&pci->ep);
> +		pci_epc_init_notify(pci->ep.epc);
>  
>  		break;
>  	default:
> diff --git a/drivers/pci/controller/dwc/pci-layerscape-ep.c b/drivers/pci/controller/dwc/pci-layerscape-ep.c
> index 7dde6d5fa4d8..35bb481564c7 100644
> --- a/drivers/pci/controller/dwc/pci-layerscape-ep.c
> +++ b/drivers/pci/controller/dwc/pci-layerscape-ep.c
> @@ -286,7 +286,7 @@ static int __init ls_pcie_ep_probe(struct platform_device *pdev)
>  		return ret;
>  	}
>  
> -	dw_pcie_ep_init_notify(&pci->ep);
> +	pci_epc_init_notify(pci->ep.epc);
>  
>  	return ls_pcie_ep_interrupt_init(pcie, pdev);
>  }
> diff --git a/drivers/pci/controller/dwc/pcie-artpec6.c b/drivers/pci/controller/dwc/pcie-artpec6.c
> index a4630b92489b..dc8dd7f27b78 100644
> --- a/drivers/pci/controller/dwc/pcie-artpec6.c
> +++ b/drivers/pci/controller/dwc/pcie-artpec6.c
> @@ -452,7 +452,7 @@ static int artpec6_pcie_probe(struct platform_device *pdev)
>  			return ret;
>  		}
>  
> -		dw_pcie_ep_init_notify(&pci->ep);
> +		pci_epc_init_notify(pci->ep.epc);
>  
>  		break;
>  	default:
> diff --git a/drivers/pci/controller/dwc/pcie-designware-ep.c b/drivers/pci/controller/dwc/pcie-designware-ep.c
> index 47391d7d3a73..2e69f81baf99 100644
> --- a/drivers/pci/controller/dwc/pcie-designware-ep.c
> +++ b/drivers/pci/controller/dwc/pcie-designware-ep.c
> @@ -27,18 +27,6 @@ void dw_pcie_ep_linkup(struct dw_pcie_ep *ep)
>  }
>  EXPORT_SYMBOL_GPL(dw_pcie_ep_linkup);
>  
> -/**
> - * dw_pcie_ep_init_notify - Notify EPF drivers about EPC initialization complete
> - * @ep: DWC EP device
> - */
> -void dw_pcie_ep_init_notify(struct dw_pcie_ep *ep)
> -{
> -	struct pci_epc *epc = ep->epc;
> -
> -	pci_epc_init_notify(epc);
> -}
> -EXPORT_SYMBOL_GPL(dw_pcie_ep_init_notify);
> -
>  /**
>   * dw_pcie_ep_get_func_from_ep - Get the struct dw_pcie_ep_func corresponding to
>   *				 the endpoint function
> diff --git a/drivers/pci/controller/dwc/pcie-designware-plat.c b/drivers/pci/controller/dwc/pcie-designware-plat.c
> index 8490c5d6ff9f..771b9d9be077 100644
> --- a/drivers/pci/controller/dwc/pcie-designware-plat.c
> +++ b/drivers/pci/controller/dwc/pcie-designware-plat.c
> @@ -154,7 +154,7 @@ static int dw_plat_pcie_probe(struct platform_device *pdev)
>  			dw_pcie_ep_deinit(&pci->ep);
>  		}
>  
> -		dw_pcie_ep_init_notify(&pci->ep);
> +		pci_epc_init_notify(pci->ep.epc);
>  
>  		break;
>  	default:
> diff --git a/drivers/pci/controller/dwc/pcie-designware.h b/drivers/pci/controller/dwc/pcie-designware.h
> index f8e5431a207b..49ae845a3662 100644
> --- a/drivers/pci/controller/dwc/pcie-designware.h
> +++ b/drivers/pci/controller/dwc/pcie-designware.h
> @@ -670,7 +670,6 @@ static inline void __iomem *dw_pcie_own_conf_map_bus(struct pci_bus *bus,
>  void dw_pcie_ep_linkup(struct dw_pcie_ep *ep);
>  int dw_pcie_ep_init(struct dw_pcie_ep *ep);
>  int dw_pcie_ep_init_registers(struct dw_pcie_ep *ep);
> -void dw_pcie_ep_init_notify(struct dw_pcie_ep *ep);
>  void dw_pcie_ep_deinit(struct dw_pcie_ep *ep);
>  void dw_pcie_ep_cleanup(struct dw_pcie_ep *ep);
>  int dw_pcie_ep_raise_intx_irq(struct dw_pcie_ep *ep, u8 func_no);
> @@ -698,10 +697,6 @@ static inline int dw_pcie_ep_init_registers(struct dw_pcie_ep *ep)
>  	return 0;
>  }
>  
> -static inline void dw_pcie_ep_init_notify(struct dw_pcie_ep *ep)
> -{
> -}
> -
>  static inline void dw_pcie_ep_deinit(struct dw_pcie_ep *ep)
>  {
>  }
> diff --git a/drivers/pci/controller/dwc/pcie-keembay.c b/drivers/pci/controller/dwc/pcie-keembay.c
> index 98bbc83182b4..278205db60a2 100644
> --- a/drivers/pci/controller/dwc/pcie-keembay.c
> +++ b/drivers/pci/controller/dwc/pcie-keembay.c
> @@ -442,7 +442,7 @@ static int keembay_pcie_probe(struct platform_device *pdev)
>  			return ret;
>  		}
>  
> -		dw_pcie_ep_init_notify(&pci->ep);
> +		pci_epc_init_notify(pci->ep.epc);
>  
>  		break;
>  	default:
> diff --git a/drivers/pci/controller/dwc/pcie-qcom-ep.c b/drivers/pci/controller/dwc/pcie-qcom-ep.c
> index 1ecf602c225a..4d2d7457dcb3 100644
> --- a/drivers/pci/controller/dwc/pcie-qcom-ep.c
> +++ b/drivers/pci/controller/dwc/pcie-qcom-ep.c
> @@ -482,7 +482,7 @@ static int qcom_pcie_perst_deassert(struct dw_pcie *pci)
>  	val &= ~PARF_MSTR_AXI_CLK_EN;
>  	writel_relaxed(val, pcie_ep->parf + PARF_MHI_CLOCK_RESET_CTRL);
>  
> -	dw_pcie_ep_init_notify(&pcie_ep->pci.ep);
> +	pci_epc_init_notify(pcie_ep->pci.ep.epc);
>  
>  	/* Enable LTSSM */
>  	val = readl_relaxed(pcie_ep->parf + PARF_LTSSM);
> diff --git a/drivers/pci/controller/dwc/pcie-rcar-gen4.c b/drivers/pci/controller/dwc/pcie-rcar-gen4.c
> index cfeccc2f9ee1..237a6a8818de 100644
> --- a/drivers/pci/controller/dwc/pcie-rcar-gen4.c
> +++ b/drivers/pci/controller/dwc/pcie-rcar-gen4.c
> @@ -437,7 +437,7 @@ static int rcar_gen4_add_dw_pcie_ep(struct rcar_gen4_pcie *rcar)
>  		rcar_gen4_pcie_ep_deinit(rcar);
>  	}
>  
> -	dw_pcie_ep_init_notify(ep);
> +	pci_epc_init_notify(ep->epc);
>  
>  	return ret;
>  }
> diff --git a/drivers/pci/controller/dwc/pcie-tegra194.c b/drivers/pci/controller/dwc/pcie-tegra194.c
> index 93f5433c5c55..432ed9d9a463 100644
> --- a/drivers/pci/controller/dwc/pcie-tegra194.c
> +++ b/drivers/pci/controller/dwc/pcie-tegra194.c
> @@ -1903,7 +1903,7 @@ static void pex_ep_event_pex_rst_deassert(struct tegra_pcie_dw *pcie)
>  		goto fail_init_complete;
>  	}
>  
> -	dw_pcie_ep_init_notify(ep);
> +	pci_epc_init_notify(ep->epc);
>  
>  	/* Program the private control to allow sending LTR upstream */
>  	if (pcie->of_data->has_ltr_req_fix) {
> diff --git a/drivers/pci/controller/dwc/pcie-uniphier-ep.c b/drivers/pci/controller/dwc/pcie-uniphier-ep.c
> index a2b844268e28..d6e73811216e 100644
> --- a/drivers/pci/controller/dwc/pcie-uniphier-ep.c
> +++ b/drivers/pci/controller/dwc/pcie-uniphier-ep.c
> @@ -410,7 +410,7 @@ static int uniphier_pcie_ep_probe(struct platform_device *pdev)
>  		return ret;
>  	}
>  
> -	dw_pcie_ep_init_notify(&priv->pci.ep);
> +	pci_epc_init_notify(priv->pci.ep.epc);
>  
>  	return 0;
>  }
> 
> -- 
> 2.25.1
>