Received-SPF: pass (google.com: domain of linux-kernel+bounces-205027-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Thu, 6 Jun 2024 17:06:55 -0400
From: Frank Li <Frank.li@nxp.com>
To: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Cc: Vignesh Raghavendra <vigneshr@ti.com>,
	Siddharth Vadapalli <s-vadapalli@ti.com>,
	Lorenzo Pieralisi <lpieralisi@kernel.org>,
	Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= <kw@linux.com>,
	Rob Herring <robh@kernel.org>, Bjorn Helgaas <bhelgaas@google.com>,
	Richard Zhu <hongxing.zhu@nxp.com>,
	Lucas Stach <l.stach@pengutronix.de>,
	Shawn Guo <shawnguo@kernel.org>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	Fabio Estevam <festevam@gmail.com>,
	Minghuan Lian <minghuan.Lian@nxp.com>,
	Mingkai Hu <mingkai.hu@nxp.com>, Roy Zang <roy.zang@nxp.com>,
	Jesper Nilsson <jesper.nilsson@axis.com>,
	Jingoo Han <jingoohan1@gmail.com>,
	Srikanth Thokala <srikanth.thokala@intel.com>,
	Marek Vasut <marek.vasut+renesas@gmail.com>,
	Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>,
	Thierry Reding <thierry.reding@gmail.com>,
	Jonathan Hunter <jonathanh@nvidia.com>,
	Kunihiko Hayashi <hayashi.kunihiko@socionext.com>,
	Masami Hiramatsu <mhiramat@kernel.org>,
	Kishon Vijay Abraham I <kishon@kernel.org>,
	linux-omap@vger.kernel.org, linux-pci@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
	imx@lists.linux.dev, linuxppc-dev@lists.ozlabs.org,
	linux-arm-kernel@axis.com, linux-arm-msm@vger.kernel.org,
	linux-renesas-soc@vger.kernel.org, linux-tegra@vger.kernel.org,
	mhi@lists.linux.dev, Niklas Cassel <cassel@kernel.org>,
	Bjorn Helgaas <helgaas@kernel.org>
Subject: Re: [PATCH 5/5] PCI: layerscape-ep: Use the generic
 dw_pcie_ep_linkdown() API to handle Link Down event
Message-ID: <ZmIk7zjzfiAENF3I@lizhi-Precision-Tower-5810>
References: <20240606-pci-deinit-v1-0-4395534520dc@linaro.org>
 <20240606-pci-deinit-v1-5-4395534520dc@linaro.org>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240606-pci-deinit-v1-5-4395534520dc@linaro.org>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?fX8zybbuRxMqhwZelzXLXGsKE/Pb7DmFUhbXL9WEBRJ6pzHoTJRQZYs1xhCe?=
 =?us-ascii?Q?rR4y9Wgs/0WLtCSi+I1EoFZcpAQyjbnkhPBEq6o29nbIJpT34b0aPIy6IVsI?=
 =?us-ascii?Q?4YshyhnfhJ7+zZcIniLdzafNn217y3jdgyUKWm81IE3D6+d0Krqzzi0zqRTh?=
 =?us-ascii?Q?1auULzHnn7HuD/jZqOPDYPIXUTgH9UtBZ/3eFqNMGk7BopJMXY0xusmyKHzU?=
 =?us-ascii?Q?M28enIQGfRUn79pEFVsu3ycrIo2tnhJm6/Me1JGPOuHqdSV/t5TC7E8aOLNL?=
 =?us-ascii?Q?yfdGtEWLZ8IN1ENa5Tp/3AHtFZhVrs3fJBQaXaQqofu0RREozBq48L1dlswi?=
 =?us-ascii?Q?rw5JtFFdtAKWSO60+GsIAbaa1dwGEUb5JB/hDdjifbtCyJ9vC9EVRiUaLqnp?=
 =?us-ascii?Q?4LoD3oCwqoR9kQYiUjGsNoPqB28S5HvaGcQ8E80o0i7169gYC4T8C0T8Vy8Z?=
 =?us-ascii?Q?rg8DBr1zSrBE1rvZYuXTjrr+9aBK5ioTthJG/WWx+U13aXyeLirGZ3KPFGTx?=
 =?us-ascii?Q?8SXJG5mAQSIkPtwCDFW6MyaoT0jKv3LcJUS1UHRwDNsBev0wWI6KxMkTIOwn?=
 =?us-ascii?Q?w7qoFaCciNNTNEOSo2GYM8hSl4ecCnmiKhmKFTS43L7r3vJned+dn80xIB7z?=
 =?us-ascii?Q?OFu0IzqCDUjrb6Q+rkE+ouui2kmjxRs9nZ1ywmZcg6WBRagj9sRTZhXQM+Vc?=
 =?us-ascii?Q?FC2qJiDdUfEiHTMg36WOPZPdPa6ifz5lcIdBwQ61qi5H2b3KuTGBiqh7fihQ?=
 =?us-ascii?Q?DIOskOHbunonrpCHPgv8jbsAWLo9sQBQsluKLxzc/N2f8WvuF0SinOwqO1fq?=
 =?us-ascii?Q?+p420qzAq8E12YAUXgGnkkRZKjaDOKxM2A8fubC+Xcauq0fYdl+Zvy4FQiqH?=
 =?us-ascii?Q?904Tykk2mhT9bZXjvmuRJGpdHYlkz/5S02z3zaWqTsK2PQ6iGiuChKgT/uB4?=
 =?us-ascii?Q?qexw1Gp54DJRme/Iptr2agxA+A7vD3d+Nv14Zv5zD+RxVA3EjY9ALENQWjxK?=
 =?us-ascii?Q?06TywWy9zYq3gnnyYWfo2xSWO3Sc1NavURpuOw3yUEw0W/68bfCgOVQ5N966?=
 =?us-ascii?Q?O0/G09D3M/NR+IVMC4689hkamP5/mRKeAOH+57syBQH0eDgsgG0MShpDbAP6?=
 =?us-ascii?Q?IWp+HS0P3Pr1iu7KiK6J1ruTTXkdvSm5gdK09luh+ip3/WT17sx5NSlkbjR+?=
 =?us-ascii?Q?dy38SLcv00iCN+kYsU4FiJtbbH/q9zNRAeVTm9F076sJOoA4QyUTBm81Otno?=
 =?us-ascii?Q?mCHocPNDFFbX2zEexjHwDBhwtNapWkQ4xD/kowT5bQlA2wJazhgVTO0YQiJi?=
 =?us-ascii?Q?TxCrGzhXZl3G+uNLXJsMKEKNB8MQoWJ4A0VtaUbKpQ5bNvO3kG2zEDECKcJm?=
 =?us-ascii?Q?bnXxlcXB3zUJ5XVzdEMZv7IWwhf58t/IQvBlWSSnuQARr8wLeUaTDXZ4liRZ?=
 =?us-ascii?Q?mYRfC8xNUDmr48wQQp6YaTQ2rj4X/PjiToor80UgGg0eWxWJPFFvKVnToeOx?=
 =?us-ascii?Q?VOQF/UMdXQ5hzlcnK+yGzyf9bUVr1O5fnsO7U2wkrT0PVqog046H+eIi0f18?=
 =?us-ascii?Q?lWIsTJ0snT0x1+QZPLQ=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 118840ea-47cf-43a8-8417-08dc866ca098
X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9642.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Jun 2024 21:07:09.1165
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Svn2v8m8EN0GvgcgqCiLvPxbV0oaTGuc2IgLz0oPQIFOIu1HBvZl3BkBr3Hk4BQo7y80bKK7aX1gl7nn2XdvEg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA1PR04MB10208

On Thu, Jun 06, 2024 at 12:56:38PM +0530, Manivannan Sadhasivam wrote:
> Now that the API is available, let's make use of it. It also handles the
> reinitialization of DWC non-sticky registers in addition to sending the
> notification to EPF drivers.
> 
> Reported-by: Bjorn Helgaas <helgaas@kernel.org>
> Closes: https://lore.kernel.org/linux-pci/20240528195539.GA458945@bhelgaas/
> Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>

Reviewed-by: Frank Li <Frank.Li@nxp.com>

> ---
>  drivers/pci/controller/dwc/pci-layerscape-ep.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/pci/controller/dwc/pci-layerscape-ep.c b/drivers/pci/controller/dwc/pci-layerscape-ep.c
> index 35bb481564c7..a4a800699f89 100644
> --- a/drivers/pci/controller/dwc/pci-layerscape-ep.c
> +++ b/drivers/pci/controller/dwc/pci-layerscape-ep.c
> @@ -104,7 +104,7 @@ static irqreturn_t ls_pcie_ep_event_handler(int irq, void *dev_id)
>  		dev_dbg(pci->dev, "Link up\n");
>  	} else if (val & PEX_PF0_PME_MES_DR_LDD) {
>  		dev_dbg(pci->dev, "Link down\n");
> -		pci_epc_linkdown(pci->ep.epc);
> +		dw_pcie_ep_linkdown(&pci->ep);
>  	} else if (val & PEX_PF0_PME_MES_DR_HRD) {
>  		dev_dbg(pci->dev, "Hot reset\n");
>  	}
> 
> -- 
> 2.25.1
>