Received-SPF: pass (google.com: domain of linux-kernel+bounces-205079-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Thu, 6 Jun 2024 17:24:59 -0400
From: Frank Li <Frank.li@nxp.com>
To: Richard Zhu <hongxing.zhu@nxp.com>,
	Lucas Stach <l.stach@pengutronix.de>,
	Lorenzo Pieralisi <lpieralisi@kernel.org>,
	Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= <kw@linux.com>,
	Rob Herring <robh@kernel.org>, Bjorn Helgaas <bhelgaas@google.com>,
	Shawn Guo <shawnguo@kernel.org>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	Fabio Estevam <festevam@gmail.com>,
	NXP Linux Team <linux-imx@nxp.com>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Mark Brown <broonie@kernel.org>,
	Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>
Cc: linux-pci@vger.kernel.org, imx@lists.linux.dev,
	linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
	bpf@vger.kernel.org, devicetree@vger.kernel.org,
	Jason Liu <jason.hui.liu@nxp.com>,
	Conor Dooley <conor.dooley@microchip.com>
Subject: Re: [PATCH v5 00/12] PCI: imx6: Fix\rename\clean up and add lut
 information for imx95
Message-ID: <ZmIpK4l6fdZ9BZu/@lizhi-Precision-Tower-5810>
References: <20240528-pci2_upstream-v5-0-750aa7edb8e2@nxp.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20240528-pci2_upstream-v5-0-750aa7edb8e2@nxp.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?anFWcThVeXJpd2ZGNVFOeHZVTnZRUEgza1gzc0RVVDVVWVUxOG5ZbkpleVpj?=
 =?utf-8?B?WVRmWlBHU2oxR2JIMFlzeDRhMHp0aGhqWnFiOUhIRExodGNlV1NTYkZwRHRK?=
 =?utf-8?B?N3NmbFduUURSYUlvTFRqeFN4RExDYlB5T3NWSFMySUE2TkRycERJRGwxOGlT?=
 =?utf-8?B?MllrRXVOQjR2UHNxTVJlSEhCbkVZVDNlZStubjhWWTVwNGFoRzlESUVuYjB2?=
 =?utf-8?B?Q0NybDlpcmpuZExqVmtTYkxMNXdmSUlSS0h4Y3JYQzBBNzl2UC8vTnF4S0Fs?=
 =?utf-8?B?VVNQTzVBV0JybnV3UTNGK0twbHhrVEMxZ3UrUjFNUHI1eTNLdFB2RWFxa1pN?=
 =?utf-8?B?ZkQyMVdMNDJIYVdEbDVaTkxQWnJsTHZtbjBXc25VY3NmUDk2Ulk3RG5hMFVM?=
 =?utf-8?B?ZG5BSUJVK2tmRXJwQ2c2aHd3cHl3UTg1anNHeUt5dWE4Wnd2R1RXUWF5SytS?=
 =?utf-8?B?RU9hSnJJaTU0NExLK2gyR0UxTEx0YTJpbXE4bVFoaTRHMWkwd3oxc3c1Nitt?=
 =?utf-8?B?RFV3b3huem1kNkZ5L2JzbTN6TXVPcm1ieTd6VVUrN2RodW5sV0FZc3VFeTdN?=
 =?utf-8?B?U2pPM20vclNzTDAxUlM2bEp4alpVUHVrWTlFekJIbWdLTHJqeTI4ZStJdU5S?=
 =?utf-8?B?ZFdHeFhISjJyQnhpa2wrKzJXN050ck4waEp6ZkRyNWpLcFV6Nkk4bk14WXdx?=
 =?utf-8?B?ZWFvVGFxZ1JnN3czdnQ1SDdicm9OT1NOQlYvQ2V5TVBTcW5uMjdsWGljRVJI?=
 =?utf-8?B?dEJSWDFvOWNzbENibTdyMmIyUkhZTWZ6VzB2bnBTdVdremgyRHJjQXFQQ0xl?=
 =?utf-8?B?cWlTZzhjYXRlc09ydXJaVmQxNFZvdTloZ1NJVEJyaytaOVh6TVNkT1A3R2FQ?=
 =?utf-8?B?YlorWjhYc2NyWGx2WDJaOGxQREFjZmFlUGk0THpnTkV3Qmwza2t3cFA4bkpF?=
 =?utf-8?B?OEJvMTJycmwrTTB1c3AxNzh3ZjZ1U3JFT29MWkl5TjVncld4SU1Pb2VMMHho?=
 =?utf-8?B?RGs1bmJDWi9KLy9OU3hTZjVoejdNa210RWwvSXBSQ096bVgrVHZpZVNPWDV4?=
 =?utf-8?B?RlVkOEdRcFhZTktIdkpzNjZOQlNhYlpDeFBRL0tIc3FiY3NuRVlnYnRDbVJz?=
 =?utf-8?B?dHNybmtEeStlYUdqdDFDZXZJV2RVRU9mMWxKRk40QzVzM2czM2ZvU2RIUmdi?=
 =?utf-8?B?cVFUVUJQdFNERlpFZFlQaXF3RitTZWJSOGtJdUUzZWd4MVd4ZjBDQmJtY3Mz?=
 =?utf-8?B?OE1Ka3l4aWFLaVc1enR2S3B5TFEyemY2dHRiQ3c2cG1DQ1lVK0ZGUllnbVdk?=
 =?utf-8?B?QUlidmkwQTl0NzdRWEIrWlJPZzZiM1NVNElHU241UnNCc1pQMjhrUnJlNGRC?=
 =?utf-8?B?TnY5WFp1U09nbkRMQ2hlblNFdFI2cnpUdnJIemtZTzdKT2ljRW0yeVZiSVFX?=
 =?utf-8?B?T2JYQXQ4QlFSTk1VQkFLc1JVSFFMZFZOTHpxSExCekh2ZlZyb3BVQllxS2lL?=
 =?utf-8?B?SXJTQ01tRHlneXdId3QzS1Ntbk5jamhTanZGaHNNcHZPbGRHZHcrbnZ5NFAv?=
 =?utf-8?B?VFZqS2tsNjFEYjVYdVQzN1psSldCR2U1V0VtZXdQQ2Y5OXVWOTYvbUhPOU8y?=
 =?utf-8?B?SGJicnBXRzZOQ2lHK25iR0ZxTUtJZE82Vzc4djlYZUh4SzVzcFFhL0tncUdq?=
 =?utf-8?B?cVpIODRjTFdMT3NSYUFxMmIyeGNNMDlyNysrQmJDZ3BMOGo4dWI4WDNnbzR3?=
 =?utf-8?B?RFB3SmlxYmVkQ1IyNG5aQ0lVRGxtdFkySWhaRUxCT2M3TzdMZHRhZGllNld2?=
 =?utf-8?B?ekx0TVZrZmlwemlnNUc3QXYxQlo3UUE0a0czR0VoUzF1MllianNlWStvc3U1?=
 =?utf-8?B?Ti9rTW9obFNrVUIvNWViY0h1bTFxS3FBQmkvSG5ZNFlUS0ZqMjJKTW1jQ3dC?=
 =?utf-8?B?b0F4TWUwQ01JRm5jWlRYc2pOSm1mWXFJTFUvcHdoMGhLM1FvK2VEbkpyOHlD?=
 =?utf-8?B?WXBOZW1JcUtjeElDSFpjcTRXN05oWjZmdmJ6Mm0xSjVGYXYzdmlMVUJ2NFVC?=
 =?utf-8?B?aUJiOS9tOFFNWVNzN1pPZHBsVzh1S0ZaVXI0enl5YllqY2Z5Y1U4NEZYQWhv?=
 =?utf-8?Q?NTPw=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: fb8154de-c5e9-4168-150c-08dc866f2490
X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9642.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Jun 2024 21:25:09.3740
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: iim0MBHXov983LWy7iAYq2FN2kvtJNAmVHbDirH+HMlAUnsVjIkaL8I1Eo/CLzmaDQa+cS/aDw8YyZ/1Oeatbw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB9092

On Tue, May 28, 2024 at 03:39:13PM -0400, Frank Li wrote:
> Fixed 8mp EP mode problem.


hi Manivannan:

	Do you have any additional comments except for the patch
Config look up table(LUT) to support MSI ITS and IOMMU for i.MX95?


Frank Li

> 
> imx6 actaully for all imx chips (imx6*, imx7*, imx8*, imx9*). To avoid     
> confuse, rename all imx6_* to imx_*, IMX6_* to IMX_*. pci-imx6.c to        
> pci-imx.c to avoid confuse.                                                
> 
> Using callback to reduce switch case for core reset and refclk.            
> 
> Add imx95 iommux and its stream id information.                            
> 
> Base on linux-pci/controller/imx
> 
> To: Richard Zhu <hongxing.zhu@nxp.com>
> To: Lucas Stach <l.stach@pengutronix.de>
> To: Lorenzo Pieralisi <lpieralisi@kernel.org>
> To: Krzysztof Wilczyński <kw@linux.com>
> To: Rob Herring <robh@kernel.org>
> To: Bjorn Helgaas <bhelgaas@google.com>
> To: Shawn Guo <shawnguo@kernel.org>
> To: Sascha Hauer <s.hauer@pengutronix.de>
> To: Pengutronix Kernel Team <kernel@pengutronix.de>
> To: Fabio Estevam <festevam@gmail.com>
> To: NXP Linux Team <linux-imx@nxp.com>
> To: Philipp Zabel <p.zabel@pengutronix.de>
> To: Liam Girdwood <lgirdwood@gmail.com>
> To: Mark Brown <broonie@kernel.org>
> To: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> To: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
> To: Conor Dooley <conor+dt@kernel.org>
> Cc: linux-pci@vger.kernel.org
> Cc: imx@lists.linux.dev
> Cc: linux-arm-kernel@lists.infradead.org
> Cc: linux-kernel@vger.kernel.org
> Cc: bpf@vger.kernel.org
> Cc: devicetree@vger.kernel.org
> Signed-off-by: Frank Li <Frank.Li@nxp.com>
> 
> Changes in v5:                                                             
> - Rebase to linux-pci next. fix conflict with gpiod change                    
> - Add rob and cornor's review tag                         
> - Link to v4: https://lore.kernel.org/r/20240507-pci2_upstream-v4-0-e8c80d874057@nxp.com
> 
> Changes in v4:                                                             
> - Improve comment message for patch 1 and 2.
> - Rework commit message for patch 3 and add mani's review tag
> - Remove file rename patch and update maintainer patch
> - [PATCH v3 06/11] PCI: imx: Simplify switch-case logic by involve set_ref_clk callback
> 	remove extra space.
> 	keep original comments format (wrap at 80 column width)
> 	update error message "'Failed to enable PCIe REFCLK'"
> - PATCH v3 07/11] PCI: imx: Simplify switch-case logic by involve core_reset callback
> 	keep exact the logic as original code
> - Add patch to update comment about workaround ERR010728
> - Add patch about help function imx_pcie_match_device()
> - Using bus device notify to update LUT information for imx95 to avoid
> parse iommu-map and msi-map in driver code.  Bus notify will better and
> only update lut when device added.
> - split patch call PHY interface function.
> - Improve commit message for imx8q. remove local-address dts proptery. and
> use standard "range" to convert cpu address to bus address.             
> - Check entry in cpu_fix function is too late. Check it at probe
> - Link to v3: https://lore.kernel.org/r/20240402-pci2_upstream-v3-0-803414bdb430@nxp.com
> 
> Changes in v3:
> - Add an EP fixed patch
>   PCI: imx6: Fix PCIe link down when i.MX8MM and i.MX8MP PCIe is EP mode
>   PCI: imx6: Fix i.MX8MP PCIe EP can not trigger MSI
> - Add 8qxp rc support
> dt-bing yaml pass binding check
> make ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- -j8  dt_binding_check DT_SCHEMA_FILES=fsl,imx6q-pcie.yaml
>   LINT    Documentation/devicetree/bindings
>   DTEX    Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.example.dts
>   CHKDT   Documentation/devicetree/bindings/processed-schema.json
>   SCHEMA  Documentation/devicetree/bindings/processed-schema.json
>   DTC_CHK Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.example.dtb
> 
> - Link to v2: https://lore.kernel.org/r/20240304-pci2_upstream-v2-0-ad07c5eb6d67@nxp.com
> 
> Changes in v2:
> - remove file to 'pcie-imx.c'
> - keep CONFIG unchange.
> - Link to v1: https://lore.kernel.org/r/20240227-pci2_upstream-v1-0-b952f8333606@nxp.com
> 
> ---
> Frank Li (8):
>       PCI: imx6: Rename imx6_* with imx_*
>       PCI: imx6: Introduce SoC specific callbacks for controlling REFCLK
>       PCI: imx6: Simplify switch-case logic by involve core_reset callback
>       PCI: imx6: Improve comment for workaround ERR010728
>       PCI: imx6: Add help function imx_pcie_match_device()
>       PCI: imx6: Config look up table(LUT) to support MSI ITS and IOMMU for i.MX95
>       PCI: imx6: Consolidate redundant if-checks
>       PCI: imx6: Call: Common PHY API to set mode, speed, and submode
> 
> Richard Zhu (4):
>       PCI: imx6: Fix establish link failure in EP mode for iMX8MM and iMX8MP
>       PCI: imx6: Fix i.MX8MP PCIe EP's occasional failure to trigger MSI
>       dt-bindings: imx6q-pcie: Add i.MX8Q pcie compatible string
>       PCI: imx6: Add i.MX8Q PCIe root complex (RC) support
> 
>  .../devicetree/bindings/pci/fsl,imx6q-pcie.yaml    |   16 +
>  drivers/pci/controller/dwc/pci-imx6.c              | 1181 ++++++++++++--------
>  2 files changed, 730 insertions(+), 467 deletions(-)
> ---
> base-commit: 50d96936b7b1be01bcc7b9ff898191214ee72697
> change-id: 20240227-pci2_upstream-0cdd19a15163
> 
> Best regards,
> ---
> Frank Li <Frank.Li@nxp.com>
>