Received-SPF: pass (google.com: domain of linux-kernel+bounces-205094-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
From: Zi Yan <ziy@nvidia.com>
To: xu.xin16@zte.com.cn
Cc: david@redhat.com, v-songbaohua@oppo.com, akpm@linux-foundation.org,
 linux-kernel@vger.kernel.org, linux-mm@kvack.org, mhocko@kernel.org,
 yang.yang29@zte.com.cn, ran.xiaokai@zte.com.cn
Subject: Re: [PATCH linux-next v2] mm: huge_memory: fix misused
 =?utf-8?q?mapping=5Flarge=5Ffolio=5Fsupport=28=29=C2=A0for?= anon folios
Date: Thu, 06 Jun 2024 14:44:28 -0700
Message-ID: <7F148A60-5BF0-4745-B61D-9AF5DD2F977C@nvidia.com>
In-Reply-To: <20240606174203124_OW-VQZ_ZLm4lGEimA-K9@zte.com.cn>
References: <20240606174203124_OW-VQZ_ZLm4lGEimA-K9@zte.com.cn>
Content-Type: multipart/signed;
 boundary="=_MailMate_8F064AE0-CC61-4222-94F6-4FE5D5C3BB46_=";
 micalg=pgp-sha512; protocol="application/pgp-signature"
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?uG6GUGNfDew482B/+TnwqYojQddP1/IyiHoEbnrbExvkJyXcpZEYq5IjCFkC?=
 =?us-ascii?Q?TuWxqEaXkaa29VRqXM4pYWNOz3q6zfHK48rgjCHBwNAV6qbkrIUBdgY2jeYj?=
 =?us-ascii?Q?L+ph9/GsKXI2hbUES9YaiueEYUoRJhl1SFdRn8VbRPqqVWbX1CPL9tkD+dTY?=
 =?us-ascii?Q?c9dLgqMVGjcHuv7WZgBF8GSJdpsFEFG4GKOTCQcXO8vVwoOjANqUQoNKK+On?=
 =?us-ascii?Q?eppEV2K6yLM+ln+ERamK6I+DvI8Pi9c3rG7dWaxbvNJDDuZ2v+INjQ1WsVdu?=
 =?us-ascii?Q?KdSxl0Q89nsvNuUX3FfIDmTNQ9X9Hsj17y+EW3rDkfP9/cJNCHeV8IiwK87x?=
 =?us-ascii?Q?6X3j8eLGcv2KP1aQ3g7PY4Z9bk8eSVlOEvedM27BWR9k9cylPAC1YYBcW9th?=
 =?us-ascii?Q?Hf8RVhMaTY+h8a+Igq5hRWaNKEX+2CrJ+YSD0hjdbpEryZFPQKE1CuvS90LN?=
 =?us-ascii?Q?cIaGbbhsJFmT0yjNpnocjuT1llmkw0j7QvpGk33NxmsWLhAh3E2EoKatYbo1?=
 =?us-ascii?Q?tlYi5Wjd2jJOO4eEp1MbMubDCh9spP0SfJt/Cb6J4dKk7zVkZGNzhP76X2R/?=
 =?us-ascii?Q?G8qsQhCbcD4QrS/Vp+u8tuS7BP8xYKs+kQzZtkw8lVix9QACbvb4tc1l/afq?=
 =?us-ascii?Q?4NO2XckqBvjgEL94goXMouROgWvB/SicQxIPi4UDQV+rPuYhLcgXue8q6g/y?=
 =?us-ascii?Q?3PlnnGd8z4MeBvCIpPsKm5epMHAJQZ4yAWq59s25YzvryDv6DcTmpPM6fWcx?=
 =?us-ascii?Q?aTCJfI4ekp6nSdvesTd9OCK/bca5ki0fza6gt4TY6lNy6qElACmlWPLuc87l?=
 =?us-ascii?Q?jwIEFfFl9pY16xOKv7xvHcXYZhy6crx+j3IkP7yenfvd/zmBcHcrOZj7IihX?=
 =?us-ascii?Q?zhp2Kf0FiIceQ7ZVQ7v7PMELOd/KgfJQf+fF0T/MZArBdSl2lPS3o8aK9g/G?=
 =?us-ascii?Q?8qE8vO1HN5tkXCPoyCcCh8S/Xb7A0h2IxNaRqh5bUFpvczX/B1QnsgD7vNb7?=
 =?us-ascii?Q?ntUI11jjh0c0Axt3CbIYewnUaNSyjgngTpUPvWgEpzUaUfDevtW/RCaDL9uH?=
 =?us-ascii?Q?X7JcAaLyNtM1HqbHrOJ0qBpMoagWMFQScu1d+NTU97qP/6mls6ottgX5Il+F?=
 =?us-ascii?Q?wXkUXNledSEzSlxMbsbftG7dNrgMOsr+t7rinDg7C5aceiMuSCCID3Sp1YvK?=
 =?us-ascii?Q?IGOdc3/NwoiQvlO9Q1ZiyXlnn6xPi0QZIopwD+He/MgIWwXY+NK7d2JJ/Hij?=
 =?us-ascii?Q?iQGlAUTnrchakZlg7Vcsqi0ZtBQKO+CG/5XtPaRIYF0KN7iz40VKrIJpbiQz?=
 =?us-ascii?Q?O2zL3dfPa3FRX5cSqlni/R0p5aMI+rAXYwCgJz8bMp3g3qod6e5gd1etYGYY?=
 =?us-ascii?Q?PDZWNJPSftXSsG84z4yNo8ZxCaWIVcVIgSvDBffr08w2+XKht45D7p6KCon0?=
 =?us-ascii?Q?Y3BTwR8j2VKV7ehO/ZrkACDDW/4FvuRbUEjWXvyB0sYTqF3Xk9tU14SpJoMD?=
 =?us-ascii?Q?Nc5Mm7RSx02f7rrNcPbX6HyPtkKI7vTLhJTgOLsZj3TN9ZZUiduVUJl+Cd5y?=
 =?us-ascii?Q?ILur7+wH1sf2lVpxpME=3D?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a038c0ee-95e5-43b0-4625-08dc8671da24
X-MS-Exchange-CrossTenant-AuthSource: DS7PR12MB5744.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Jun 2024 21:44:33.0229
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: M6bfq8wq+9r5JAcdnakU4aItCIjMh3GH8CEHdTo9cEHAH+KYIz46vlXfibO8B43L
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR12MB7535

--=_MailMate_8F064AE0-CC61-4222-94F6-4FE5D5C3BB46_=
Content-Type: text/plain

On 6 Jun 2024, at 2:42, xu.xin16@zte.com.cn wrote:

> From: Ran Xiaokai <ran.xiaokai@zte.com.cn>
>
> When I did a large folios split test, a WARNING
> "[ 5059.122759][  T166] Cannot split file folio to non-0 order"
> was triggered. But the test cases are only for anonmous folios.
> while mapping_large_folio_support() is only reasonable for page
> cache folios.
>
> In split_huge_page_to_list_to_order(), the folio passed to
> mapping_large_folio_support() maybe anonmous folio. The
> folio_test_anon() check is missing. So the split of the anonmous THP
> is failed. This is also the same for shmem_mapping(). We'd better add
> a check for both. But the shmem_mapping() in __split_huge_page() is
> not involved, as for anonmous folios, the end parameter is set to -1, so
> (head[i].index >= end) is always false. shmem_mapping() is not called.
>
> Also add a VM_WARN_ON_ONCE() in mapping_large_folio_support()
> for anon mapping, So we can detect the wrong use more easily.
>
> THP folios maybe exist in the pagecache even the file system doesn't
> support large folio, it is because when CONFIG_TRANSPARENT_HUGEPAGE
> is enabled, khugepaged will try to collapse read-only file-backed pages
> to THP. But the mapping does not actually support multi order
> large folios properly.
>
> Using /sys/kernel/debug/split_huge_pages to verify this, with this
> patch, large anon THP is successfully split and the warning is ceased.
>
> Signed-off-by: Ran Xiaokai <ran.xiaokai@zte.com.cn>
> ---
>  include/linux/pagemap.h |  4 ++++
>  mm/huge_memory.c        | 27 ++++++++++++++++-----------
>  2 files changed, 20 insertions(+), 11 deletions(-)

Reviewed-by: Zi Yan <ziy@nvidia.com>

Thanks.

Best Regards,
Yan, Zi

--=_MailMate_8F064AE0-CC61-4222-94F6-4FE5D5C3BB46_=
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename=signature.asc
Content-Type: application/pgp-signature; name=signature.asc

-----BEGIN PGP SIGNATURE-----

iQJDBAEBCgAtFiEEh7yFAW3gwjwQ4C9anbJR82th+ooFAmZiLbwPHHppeUBudmlk
aWEuY29tAAoJEJ2yUfNrYfqK84gP/0aLzlx+Xn31V4aGDj+0GLTyLVdMkgEdAs7x
h2l5aCfwGeCjocyw39Dh8Xgucx/tccaugi+jmkb5QgBQ4ocpWAvDCrT+rW1maQrv
agIoE7vBiBK+wni7XeCRx8/SKBnnKx5lLo/kW4sOKVYlfcV1Xccu2mHdw3wsfC3R
H1eSo3Q9FL+OsHgvd1xnFQWUIUBBApeHCKt2lXD3RzLq/hq91ZMwZDBQze8TSOyg
HCbF9JjaOHWomLNew1EsUAl+UPHJpT+uzC+SIYfCKdyXSonfeXyZr2Hvu5vsGjX3
LgNTDb0waRWw9jFtV4Wz8ZlidHbr947I+Xl/yyDlBXF3yZDrjkk5dOi2F8LssyWa
R/7j04xHMTax81K2ZMhuGncLcYZ86k75rwAtEqybtKbC2U4Wyb/a5/FN+Vj9k6UW
RKddMNX4e/ToKFGt2PPRE5z7B8NQWvgiA7gNrQjhyP6Q2OUwWvXij92cOGrIWL2T
6zQgRD2ZVqhsPpcL5PzkYbKv1WH+B29cSdWOpYE+17zdPIMMDgmWal7olI1xrTG3
ZWZhFCl5nQRDZvkGd5oKtp2P2IWlZh70oePb7IfSJgvcifoEdH6CUBEW6BPcm3+l
BVQ48FaadFo0R2Nn5tiM9bqljKV/YSbu+0EPttAPkoR9rxWOpYMLodlA6qlVH42O
iueIztHc
=unfZ
-----END PGP SIGNATURE-----

--=_MailMate_8F064AE0-CC61-4222-94F6-4FE5D5C3BB46_=--