Received-SPF: pass (google.com: domain of linux-kernel+bounces-205020-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Feedback-ID: i5ec1447f:Fastmail
User-Agent: Cyrus-JMAP/3.11.0-alpha0-497-g97f96844c-fm-20240526.001-g97f96844
Precedence: bulk
MIME-Version: 1.0
Message-Id: <01808eec-29e4-4901-a5bf-396ec2eff3fe@app.fastmail.com>
In-Reply-To: <fc03506c-210f-4d79-9a99-8bc9b0587d25@redhat.com>
References: <20240529012827.146005-1-luke@ljones.dev>
 <b0d8eebc-5abb-4ec0-898c-af7eedc730d9@redhat.com>
 <dflqwdl4fo3wv4zjj4jl6sbot6cotscksgpyrbiu3j77lyrwal@s6nomonx4gv6>
 <fc03506c-210f-4d79-9a99-8bc9b0587d25@redhat.com>
Date: Fri, 07 Jun 2024 09:02:12 +1200
From: "Luke Jones" <luke@ljones.dev>
To: "Hans de Goede" <hdegoede@redhat.com>,
 "Benjamin Tissoires" <bentiss@kernel.org>
Cc: "Jiri Kosina" <jikos@kernel.org>,
 =?UTF-8?Q?Ilpo_J=C3=A4rvinen?= <ilpo.jarvinen@linux.intel.com>,
 corentin.chary@gmail.com, platform-driver-x86@vger.kernel.org,
 linux-kernel@vger.kernel.org, linux-input@vger.kernel.org
Subject: Re: [PATCH v1 0/2] asus wmi and hid: use HID LED for brightness
Content-Type: text/plain

On Thu, 6 Jun 2024, at 9:53 PM, Hans de Goede wrote:
> Hi Benjamin,
> 
> On 6/6/24 10:49 AM, Benjamin Tissoires wrote:
> > On May 29 2024, Hans de Goede wrote:
> >> Hi all,
> >>
> >> On 5/29/24 3:28 AM, Luke D. Jones wrote:
> >>> Changelog:
> >>> - v1
> >>>   - Split the patch in two
> >>>   - Move function body to asus-wmi and export
> >>>   - Use array of names and for loops
> >>>
> >>> History:
> >>> - https://lore.kernel.org/linux-input/20240528013959.14661-1-luke@ljones.dev/T/#u
> >>>
> >>> Luke D. Jones (2):
> >>>   hid-asus: use hid for brightness control on keyboard
> >>>   hid-asus: change the report_id used for HID LED control
> >>>
> >>>  drivers/hid/hid-asus.c                     | 32 +++++++++++++++++++-
> >>>  drivers/platform/x86/asus-wmi.c            | 35 +++++++++++++++++++++-
> >>>  include/linux/platform_data/x86/asus-wmi.h | 10 +++++++
> >>>  3 files changed, 75 insertions(+), 2 deletions(-)
> >>
> >> Jiri, Benjamin since the first patch now also touches pdx86 files
> >> we need to coordinate merging this.
> >>
> >> There also is a long list of patches pending for
> >> drivers/platform/x86/asus-wmi.c
> >>
> >> So I would prefer to take this series (both patches) upstream through
> >> the pdx86 tree to avoid conflicts.
> >>
> >> May we have an ack from one of you for merging this through pdx86/for-next ?
> > 
> > Sure:
> > Acked-by: Benjamin Tissoires <bentiss@kernel.org>
> 
> Thank you for the ack.
> 
> > But I haven't seen the v2. Are you sure you want to take this series as
> > it is?
> 
> No I plan to wait for v2, I just thought it would be good to have
> an ack to merge this through the pdx86 tree beforehand.

My apologies for the delay, I have v2 prepped, but I'm waiting on feedback from a few folks regarding the 2024 G16 and G14, plus the TUF laptops - these are possibly affected by the patch. Shouldn't be more than a day or two now.

Regards,
Luke.