Received-SPF: pass (google.com: domain of linux-kernel+bounces-205130-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <e90b6291-7f6e-4e5d-9131-7eb7604f575f@I-love.SAKURA.ne.jp>
Date: Fri, 7 Jun 2024 07:41:43 +0900
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [GIT PULL] tomoyo update for v6.10
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: LKML <linux-kernel@vger.kernel.org>
References: <c86f0ed7-4336-4bc8-a27c-8d7ccaaec5d8@I-love.SAKURA.ne.jp>
 <CAHk-=wh5Odts_1ZL3gLuxmQBveTWveeWn3equ2JcH2yA9cyjxQ@mail.gmail.com>
 <d17e8d0c-b292-4915-a61b-1a4c2c496bae@I-love.SAKURA.ne.jp>
 <CAHk-=wgU-ybmkd7rA+GcN1fSE+w3Hbm1E_Q0YHO2q5Uoo69pUQ@mail.gmail.com>
Content-Language: en-US
From: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
In-Reply-To: <CAHk-=wgU-ybmkd7rA+GcN1fSE+w3Hbm1E_Q0YHO2q5Uoo69pUQ@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit

On 2024/06/07 7:22, Linus Torvalds wrote:
> On Thu, 6 Jun 2024 at 15:13, Tetsuo Handa
> <penguin-kernel@i-love.sakura.ne.jp> wrote:
>>
>> On 2024/06/07 1:50, Linus Torvalds wrote:
>>> On Thu, 6 Jun 2024 at 07:40, Tetsuo Handa
>>> <penguin-kernel@i-love.sakura.ne.jp> wrote:
>>>>
>>>>   git://git.code.sf.net/p/tomoyo/tomoyo.git
>>>
>>> Tssk, tssk. I want to see a proper pull request from a signed tag.
>>>
>>> I did find the tag in your repo, so I pulled it, but please don't make
>>> me have to go look for it.
>>
>> Excuse me, but what did I miss?
> 
> Note how it doesn't actually mention the tag-name anywhere.

Oops, I didn't notice that

  git request-pull tomoyo-pr-20240606 git://git.code.sf.net/p/tomoyo/tomoyo.git

command does not include the tag name in the output. (Since I previously didn't
need to manually add the tag name, this seems to be caused by moving to the new
repository.)

That line should have been in the following format.

  git://git.code.sf.net/p/tomoyo/tomoyo.git tags/$tagname

I'll add the tag name manually. Thank you for pointing this out.

> 
>> I think I made the tag using "git tag -s tomoyo-pr-20240606".
>> What is "a proper pull request from a signed tag"?
> 
> Oh, the signed tag _existed_. And it was in the public repository. But
> it wasn't actually ever mentioned in the pull-request itself, so I had
> to find it by doing
> 
>     git ls-remote git://git.code.sf.net/p/tomoyo/tomoyo | less
> 
> and then look for the tag that pointed to the commit ID that you mentioned.
> 
> 
>                 Linus