Received-SPF: pass (google.com: domain of linux-kernel+bounces-205176-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
From: Stephen Brennan <stephen.s.brennan@oracle.com>
To: David Hildenbrand <david@redhat.com>,
        Andrew Morton
 <akpm@linux-foundation.org>
Cc: Omar Sandoval <osandov@osandov.com>, Hao Ge <gehao@kylinos.cn>,
        Vlastimil Babka <vbabka@suse.cz>, linux-kernel@vger.kernel.org,
        "Vishal
 Moola (Oracle)" <vishal.moola@gmail.com>, linux-mm@kvack.org,
        linux-debuggers@vger.kernel.org,
        "Matthew Wilcox (Oracle)"
 <willy@infradead.org>
Subject: Re: [PATCH v2] mm: convert page type macros to enum
In-Reply-To: <b96b3d41-cf6d-4c5e-bf42-01fa168510a5@redhat.com>
References: <20240606182630.851750-1-stephen.s.brennan@oracle.com>
 <b96b3d41-cf6d-4c5e-bf42-01fa168510a5@redhat.com>
Date: Thu, 06 Jun 2024 17:06:27 -0700
Message-ID: <87r0d9obuk.fsf@oracle.com>
Content-Type: text/plain
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?us-ascii?Q?v7HmK6YdNNZxmoPCsev6rlUquZisALgSEzRdMouwVO8PG/WIo3LFCLC4YM7f?=
 =?us-ascii?Q?QKpKPFujzGqzWoI7Wu/cf9gEguSDYXlp3ScmmAHSHJKISV4eFHydaJtb42sF?=
 =?us-ascii?Q?nnjmOFeoSATrsdKFVN7agUKDk6J+Olf5T8CM8JahU73KtyRnwogCPyK4uAwi?=
 =?us-ascii?Q?Ba3pLqLKbemBbjZXI6Oq6GBiJXntDBWQUsvTrjRjUlax6qZ1ylfy62+6nREb?=
 =?us-ascii?Q?F3oYdey6i5tNdfs7tPOzGpNl3LvaFheeqpkmL1ogaW3lcsUrXZfqnfNB2r2F?=
 =?us-ascii?Q?FdwlFhNLk7RA4wztjvUnxq0iqyZD7mVuUg5/CuXrTZIH58NlXgNEAPsYXNTh?=
 =?us-ascii?Q?ws4JErb3Igto5+MvROsvedjw9TTylX+O3ORjLb/PJ3DBf8qMGmPu1ogBA33c?=
 =?us-ascii?Q?yBc8s8XHcn1xp/H9rEMlSlbS+lQekJTVczgRsCJT6zg5mA8nW7DJ57J5RCl3?=
 =?us-ascii?Q?TiE+bPRRetHsBsizzDYnGuulNDcA/HVjgleoegCoF4dOwlTkU8ysrT3BW7AB?=
 =?us-ascii?Q?FOj9ANQ5dDPlVlPe0wLX6R18dmZoJAK5mVZu9+76G7b20soNo2FDGWf3Sey+?=
 =?us-ascii?Q?1OabFdMS3g6BhOWTpTAfdfgQTAgJ/vuS243ixOBq89tnCUVeYVNdR7W0g1SG?=
 =?us-ascii?Q?1DP5YkNuk28L9cUR8PUlbutlPc737Y4CzwgUX0mp37yDNx5JzMx74N0tTrjF?=
 =?us-ascii?Q?5adywek8xV+MIRgyEA/XH642LhRD/stzBv3UdKCuYDXh/xBp9ZkI1Zeuqw3c?=
 =?us-ascii?Q?vpMexT3HhTNOBel1bRoONAYSrdbMi/UW6R0w7GpTx4w/gbcqqHiX8/BkPOI2?=
 =?us-ascii?Q?RYI5CYf4cfIWGykIa7YqUu87VX41s/HqKZT7CajXE4Hd7tGg/DTBMpj2Iw9P?=
 =?us-ascii?Q?ieXmdaCOcQCsM0H6rdrxomVS0kIGN6aOE/wurRyTV2L0TCe2IHyMhpNGo3TN?=
 =?us-ascii?Q?p0i5dra8aXVbthVQ9tQCCgV5qKtUf1yaMCWzgGPpPMYF3lCgm2wxmlghAyjV?=
 =?us-ascii?Q?6xBIa1Y95JQQIoUkenPaG8cl5O7jYp15za6cerdzU2VC6aSkzjeAoXjELO2I?=
 =?us-ascii?Q?x+yBMgVpHXxT4QOqO8pWJVP7Ql17aL01Hk2du2H8SMAwHw00q5EhQm7TDL9M?=
 =?us-ascii?Q?dLQ6anG8zfkZPI5D5ynhJD8y4kpx+/Zl6tTM9WwXQ2gFhOGSfyMNVbHAiBTT?=
 =?us-ascii?Q?cu3Xrl0qMX+8SAdrm/hIiMJ3RNXMcmvA+OqFPeCVuxO8S6Frslv/WFbhdrpO?=
 =?us-ascii?Q?9mxw42JMjSgtqLffcKHfIWvYIdwsghayaYijYTYW7HQQ4Ri3NmAGO2np3qZ7?=
 =?us-ascii?Q?jzGZcI16pIwT6UtPHdg1R+eTkSCnCF53OoqMlMUcsKEyOTADFQIeKyIoFVMt?=
 =?us-ascii?Q?q9tnPt0EL9RI6tv0VVPQnlaaXUrk4nRKRd8CKf0mMYjAdjVC1+EySCO9sKFP?=
 =?us-ascii?Q?Guv0N6KTJHC+IfhBEqP6evO54/hnEAKNI6qcFv1Ri6dUkKFM6/+OKeQxAsvW?=
 =?us-ascii?Q?XN0BRN+J2/kTH/i2KvykMx4W94gqLLLMIulNPzW0jeEQwkhx8mXfDOvksrh9?=
 =?us-ascii?Q?9Fv5yGfpI2sD7C9E8khGrBDje6HDiVpa9P/4fnvhBe+9q1cyoIKoAnNOH21p?=
 =?us-ascii?Q?FGRI3CQyDEzMRX82DIv6u4kaql2TOagGVvWIww8hN4I8RnZ4xnrC3vJ6XoNz?=
 =?us-ascii?Q?omCfCw=3D=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	doHrGQkx0WdsPQBg9PHzGinQwLIw3ddlPw0ZANmyibwyh7ZPkfeTAEsGbvdhC94oEMljew4mHzZFGS1BOroYch4wWutG4qzcUpYLgvGDLq/YhWxmHG+B4507PVVyHMlrnU1XOx9aj8+Ct0Z3n+YWaE+lfLr24pc6agwzjZRx8lIn9dZpzUnCMN/6UOLgwDlps+X9l5dz4P1qFKgAk54m0x3OGuZg4HBFf5grOA7dpdlhKF8QDJ1naNnDLAbQUsVSOi42qwhEh54kRZx/2QFL3y2Gf1ddO32OnwKnbrqRgfWgrg6bMrzcQNmsdENu/SOOOp4vWVeU0QyAPYS7sVvgSB035i+HNON3bKrEiOX98C6KvgfRvxihDnm7hfN3pHM+DtKMRC3znPpC1HTZqkhVAgT27YV13Vh5KxoAouC6eoGWvAXNW/I8utKWhofzbyQLwNgWjECPSjW62viunIRqD9JgLoC6enP150kahbIae5CdcZYEt6Kbd5m19up6be6asx0PDfSYjq+M9R8w7M0pW3C/nKYaEtm39NbyQGyAzxOpLJ0dpGUuD7wbr7xELmiifMxyF6GTY7revoQ8vFwdHkF0c/dSIVb0R/2GJCiYcbs=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e6b1a356-c9e6-4548-ad93-08dc8685ae4c
X-MS-Exchange-CrossTenant-AuthSource: PH8PR10MB6597.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Jun 2024 00:06:29.4485
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: VDx3qwhn1/6aogmc+ESBnj7EW3s/dojAD3ppBc7PTmnyaPmQA1SRLEb+U71lERX8RKQxARpK4anXsTVbuukA+TeqX5VrL/mvLsgGD6Bfrp0=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY5PR10MB6261
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.28.16
 definitions=2024-06-06_19,2024-06-06_02,2024-05-17_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 bulkscore=0 spamscore=0
 malwarescore=0 suspectscore=0 phishscore=0 mlxlogscore=999 adultscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2405010000
 definitions=main-2406060168
X-Proofpoint-GUID: H0yWCf1VdQtMdxE3mKb7NTHBp2rV61nt
X-Proofpoint-ORIG-GUID: H0yWCf1VdQtMdxE3mKb7NTHBp2rV61nt

David Hildenbrand <david@redhat.com> writes:
> On 06.06.24 20:26, Stephen Brennan wrote:
>> Changing PG_slab from a page flag to a page type in commit 46df8e73a4a3
>> ("mm: free up PG_slab") in has the unintended consequence of removing
>> the PG_slab constant from kernel debuginfo. The commit does add the
>> value to the vmcoreinfo note, which allows debuggers to find the value
>> without hardcoding it. However it's most flexible to continue
>> representing the constant with an enum. To that end, convert the page
>> type fields into an enum. Debuggers will now be able to detect that
>> PG_slab's type has changed from enum pageflags to enum page_type.
>> 
>> Fixes: 46df8e73a4a3 ("mm: free up PG_slab")
>> 
>> Signed-off-by: Stephen Brennan <stephen.s.brennan@oracle.com>
>> ---
>> v1 -> v2: include PAGE_TYPE_BASE and PAGE_MAPCOUNT_RESERVE
>
> This has a conflict with mm/mm-unstable.

Thank you, that's what I get for developing on master. I'll send v3
based on mm-unstable once it finishes compiling.

-Stephen