Received-SPF: pass (google.com: domain of linux-kernel+bounces-205178-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
From: Stephen Brennan <stephen.s.brennan@oracle.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: "Vishal Moola (Oracle)" <vishal.moola@gmail.com>, linux-mm@kvack.org,
        Omar Sandoval <osandov@osandov.com>, linux-debuggers@vger.kernel.org,
        "Matthew Wilcox (Oracle)" <willy@infradead.org>,
        Stephen Brennan <stephen.s.brennan@oracle.com>,
        David Hildenbrand <david@redhat.com>, linux-kernel@vger.kernel.org,
        Hao Ge <gehao@kylinos.cn>, Vlastimil Babka <vbabka@suse.cz>
Subject: [PATCH v3] mm: convert page type macros to enum
Date: Thu,  6 Jun 2024 17:11:15 -0700
Message-ID: <20240607001116.1061485-1-stephen.s.brennan@oracle.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?us-ascii?Q?I3cDBm5S8msK58UjG0D1naqNwiTOJsqmpkcibo7CkkS7StNOhnFij2X5z9+/?=
 =?us-ascii?Q?EizqAV/thCDg+iRLtDY1db6nHjonXNS/RNmhgmJzKusLblhhzQIKY4jIL9hX?=
 =?us-ascii?Q?D+7b/sIoDk+U4t9kAS6xd7JY+Z23AnypVlL4sSkfJ/0fJSUMnOTSKCVkhdGC?=
 =?us-ascii?Q?A0F6lQo3O+cTiaBtvo+XjQbkEUEDKrEoeuW0FfzemwrWATcZ3gdwVv5ZfkN5?=
 =?us-ascii?Q?M9fOJYX22Et7V2pKVbpII7bt7fsMgEUxDUifVOaE8z1N4XtBiGmTCGr/3zEG?=
 =?us-ascii?Q?B454zL5YEddT7JlRPjeDQmsOyZqxoXOle8/SJl6o0H0dCXfh8ASpIKXZBgHM?=
 =?us-ascii?Q?wwrdjMwd6SZuFhNMtfpBDwUILhCIiBXGfj3DSDT5plyML8DyjSIO7ECouxyI?=
 =?us-ascii?Q?e2z1TicKxFjysYblGO7iDAh2aqWvEpMA+XcPq29AXmuvoj3VgboInU5stIDN?=
 =?us-ascii?Q?i86OWQkx69rRNyGLd/1cvJZ5i08KuEgIFqMLdXu3TdVOSw5kx7VghX2ndepf?=
 =?us-ascii?Q?HSDT62NE21zV7w/+DtVR8yxHpLNfpef8jq4yM6tbKLw4Se9GsXemuequGtEL?=
 =?us-ascii?Q?BvPlAc40ilPZySyKonSc5s0NMEgmKsWIR5K9ZheFwr9nYYienHLJTO9QbtHI?=
 =?us-ascii?Q?ly+/XusrDmfHB1bLIFC8Yl+nIQJh9sfKARAFqzkJ0EUm/37QOFMPK/8dvIRs?=
 =?us-ascii?Q?2spqBu0h8j8jRbaNGb45LHsdaX26FYe2dmpcC6kYSqc15kHBgHrG4sRpcH0+?=
 =?us-ascii?Q?sfBlPLYmqVI/GT64rvfy3fneYUJOBgzTnUoZuWU0jmyIBH00iYblysqgk+zM?=
 =?us-ascii?Q?8BQ2NdJ7OIKEMWdokup0MjXHfezHHgzb/gzaAn+Td2gsW2rsA0laS0Xdx6UO?=
 =?us-ascii?Q?M92YA2Bhazp9gUhWK3uRGETJc+tPgBSLSlVt8Sm6WEHze5WX1xt6bxVYh2Wv?=
 =?us-ascii?Q?qC6+GVNTyF3uuLuaaX1N/CbgCHIgzIpINIlgHft3iCBbbNQAlpY5lnI9/fXc?=
 =?us-ascii?Q?dTsBVLCl17bzUfgrMgCj4ZF73sjTzCBuiOdXvc5nAhkd+u+pjYMe3ag838we?=
 =?us-ascii?Q?wjFyr4KQu5g9IFTyCnhSXxdoCEeaF6mGj9JFWQOEf1VE0kAsuvCow0Nw4iKj?=
 =?us-ascii?Q?r6wPyiCQVj6KfrRTy8XkSLAVpPEStrho8qXRuq0vlge0Olx7LBjp0ThMBecP?=
 =?us-ascii?Q?elQnSAM+cf1AZGRFlDfCaXBBfNDlEnygbUjEa249OvVQ72ZoudvswBWRwc0o?=
 =?us-ascii?Q?pIwHGobHr0ssxcpIlFGxL+XDSeITicXDATM2Cf2z7qm9XVzbj0hGPUE43PnE?=
 =?us-ascii?Q?hOQkSmXZRgMUKzcBbc22jnBHYPVzTUHAmy8WiXm1hgLVsPYi7DrsFgbhDr9K?=
 =?us-ascii?Q?fiA3WtnOFtFgvx3uFC6GaJwf42LvhoHXaoWiGN5qe57f+XqLxGHZ4w7x+TF6?=
 =?us-ascii?Q?hi/Hw8u8xN1FkXOZKWRFi4uH97tF/8lAMyiXaT2Y6VnLAMvKjNqmcXToODI6?=
 =?us-ascii?Q?9BxAuFwojMJksSkRF411m7HgH7nv5PN4GzJfih+LGfGRqCDg3dcneh2nLy9/?=
 =?us-ascii?Q?s34pKnxATqN26d00UWZ2vS3WVKOj7gm+8xykgALZRWpzBXVqEJ2YQp4hcD0p?=
 =?us-ascii?Q?GY1wDG6yfxetqcvG5nH21xmhObmtQnI6252XilvpM3/pFB/xi3jmClQnE2Zd?=
 =?us-ascii?Q?ZuKLiQ=3D=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	5pSMOHlKXiovyHT4vgBHTre4kreleSjglQn0V/uTboR+zKvOBRRyOnMdyMuK2Dxtcz5nhtJ1dRcarTj8LuXrHOcHpTSv13HJlwLj0lQbrZffaHPg4PhaKQuYkZrVATiL7oEOKfMQ54V4jGVCRJ/wTdYLnvy7dx2qVAyaISYLndRlmurYzzAEt888hRyVZXsIsgmCKNs8tOYuAQko4EJLFiGk17s9JArnDalqdhQTXDNfbxV7SaDLSffSdgvcALkFJ6qlnqFH0EBX4yBqha1fsxFhLImyySZqy1r7STWgy1lrw+mdGnV3X+4shnV4g+a394w/8HQscb8s6NV9gNur35PZ1lExMIiG13gXFcBq6wrIIeA4uRBvOw98tVfr+e6jxxY0VuOklZepwGMe/tdjrfzfEhSfuP1GI64OSCUjq4Gm13JaNixING8J5kHjb3Xe0ME1ELk2Zx82N7V9aUr8uy+5vA/X+zj848IuJguDL0YYSfuALLMzP2zEzsb8km6clx+0Tnusdpxw4ITU7d+h4Q342S+gQdYPaNnDp7vt21W65xYnzch8UIqKdveh1qhgGcJv4SlsNAM1H38aUxAKI994jqixi5sKCZ9tsnAJStA=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a953707b-ba86-4dbf-6573-08dc86865a5a
X-MS-Exchange-CrossTenant-AuthSource: PH8PR10MB6597.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Jun 2024 00:11:18.0448
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: EN150q6ToYnP4eeZF3Xq1nv4yhw1Kvjd7rFvlUo0L/rIXb/4kuRkC8vLJya6OuvAaHyxeUDQo+2GZ/Fd6496EjHE7ThHtNOJfzgpP/DfE+4=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR10MB5830
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.28.16
 definitions=2024-06-06_19,2024-06-06_02,2024-05-17_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 bulkscore=0 spamscore=0
 malwarescore=0 suspectscore=0 phishscore=0 mlxlogscore=999 adultscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2405010000
 definitions=main-2406060168
X-Proofpoint-ORIG-GUID: IpfZ7y8xIy1SgUmqZGr8ehY5oNx9UMlo
X-Proofpoint-GUID: IpfZ7y8xIy1SgUmqZGr8ehY5oNx9UMlo

Changing PG_slab from a page flag to a page type in commit 46df8e73a4a3
("mm: free up PG_slab") in has the unintended consequence of removing
the PG_slab constant from kernel debuginfo. The commit does add the
value to the vmcoreinfo note, which allows debuggers to find the value
without hardcoding it. However it's most flexible to continue
representing the constant with an enum. To that end, convert the page
type fields into an enum. Debuggers will now be able to detect that
PG_slab's type has changed from enum pageflags to enum page_type.

Fixes: 46df8e73a4a3 ("mm: free up PG_slab")

Signed-off-by: Stephen Brennan <stephen.s.brennan@oracle.com>
---
v2 -> v3: rebase on mm-unstable
v1 -> v2: include PAGE_TYPE_BASE and PAGE_MAPCOUNT_RESERVE

 include/linux/page-flags.h | 31 +++++++++++++++++--------------
 1 file changed, 17 insertions(+), 14 deletions(-)

diff --git a/include/linux/page-flags.h b/include/linux/page-flags.h
index f04fea86324d9..7c0a8fd2c8c17 100644
--- a/include/linux/page-flags.h
+++ b/include/linux/page-flags.h
@@ -945,20 +945,23 @@ PAGEFLAG_FALSE(HasHWPoisoned, has_hwpoisoned)
  * mistaken for a page type value.
  */
 
-#define PAGE_TYPE_BASE	0x80000000
-/*
- * Reserve 0xffff0000 - 0xfffffffe to catch _mapcount underflows and
- * allow owners that set a type to reuse the lower 16 bit for their own
- * purposes.
- */
-#define PG_buddy	0x40000000
-#define PG_offline	0x20000000
-#define PG_table	0x10000000
-#define PG_guard	0x08000000
-#define PG_hugetlb	0x04000000
-#define PG_slab		0x02000000
-#define PG_zsmalloc	0x01000000
-#define PAGE_MAPCOUNT_RESERVE	(~0x0000ffff)
+enum page_type {
+	/*
+	 * Reserve 0xffff0000 - 0xfffffffe to catch _mapcount underflows and
+	 * allow owners that set a type to reuse the lower 16 bit for their own
+	 * purposes.
+	 */
+	PG_buddy	= 0x40000000,
+	PG_offline	= 0x20000000,
+	PG_table	= 0x10000000,
+	PG_guard	= 0x08000000,
+	PG_hugetlb	= 0x04000000,
+	PG_slab		= 0x02000000,
+	PG_zsmalloc	= 0x01000000,
+
+	PAGE_TYPE_BASE	= 0x80000000,
+	PAGE_MAPCOUNT_RESERVE	= ~0x0000ffff,
+};
 
 #define PageType(page, flag)						\
 	((page->page_type & (PAGE_TYPE_BASE | flag)) == PAGE_TYPE_BASE)
-- 
2.43.0