Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1762171AbYBEWku (ORCPT ); Tue, 5 Feb 2008 17:40:50 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1760421AbYBEWkn (ORCPT ); Tue, 5 Feb 2008 17:40:43 -0500 Received: from pentafluge.infradead.org ([213.146.154.40]:46769 "EHLO pentafluge.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759814AbYBEWkm (ORCPT ); Tue, 5 Feb 2008 17:40:42 -0500 Date: Tue, 5 Feb 2008 14:37:36 -0800 From: Greg KH To: Christoph Lameter Cc: linux-kernel@vger.kernel.org, Andrew Morton , Dhaval Giani , r31dmaeu@pc0312b.rz.unibw-muenchen.de, stable@kernel.org Subject: Re: [stable] OOM-killer invoked but why ? Message-ID: <20080205223736.GA7404@kroah.com> References: <47A1C4B1.8020607@pc0312a.rz.unibw-muenchen.de> <20080205020737.cec97816.akpm@linux-foundation.org> <20080205110303.GA8288@linux.vnet.ibm.com> <20080205220445.GA6889@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.16 (2007-06-09) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2889 Lines: 72 On Tue, Feb 05, 2008 at 02:13:12PM -0800, Christoph Lameter wrote: > On Tue, 5 Feb 2008, Greg KH wrote: > > > > > commit 96990a4ae979df9e235d01097d6175759331e88c > > > > Author: Christoph Lameter > > > > Date: Mon Jan 14 00:55:14 2008 -0800 > > > > > > > > quicklists: Only consider memory that can be used with GFP_KERNEL > > > > > > > > Quicklists calculates the size of the quicklists based on the number of > > > > free pages. This must be the number of free pages that can be allocated > > > > with GFP_KERNEL. node_page_state() includes the pages in ZONE_HIGHMEM and > > > > ZONE_MOVABLE which may lead the quicklists to become too large causing OOM. > > > > > > > > Signed-off-by: Christoph Lameter > > > > Tested-by: Dhaval Giani > > > > Signed-off-by: Andrew Morton > > > > Signed-off-by: Linus Torvalds > > > > > > > > diff --git a/mm/quicklist.c b/mm/quicklist.c > > > > index ae8189c..3f703f7 100644 > > > > --- a/mm/quicklist.c > > > > +++ b/mm/quicklist.c > > > > @@ -26,9 +26,17 @@ DEFINE_PER_CPU(struct quicklist, quicklist)[CONFIG_NR_QUICK]; > > > > static unsigned long max_pages(unsigned long min_pages) > > > > { > > > > unsigned long node_free_pages, max; > > > > + struct zone *zones = NODE_DATA(numa_node_id())->node_zones; > > > > + > > > > + node_free_pages = > > > > +#ifdef CONFIG_ZONE_DMA > > > > + zone_page_state(&zones[ZONE_DMA], NR_FREE_PAGES) + > > > > +#endif > > > > +#ifdef CONFIG_ZONE_DMA32 > > > > + zone_page_state(&zones[ZONE_DMA32], NR_FREE_PAGES) + > > > > +#endif > > > > + zone_page_state(&zones[ZONE_NORMAL], NR_FREE_PAGES); > > > > > > > > - node_free_pages = node_page_state(numa_node_id(), > > > > - NR_FREE_PAGES); > > > > max = node_free_pages / FRACTION_OF_NODE_MEM; > > > > return max(max, min_pages); > > > > } > > > > > > > > > > > > I note that this didn't have the stable@kernel.org cc. Christoph, did we > > > > deliberately decide not to backport? > > > > > > > > > > According to > > > http://archive.netbsd.se/?ml=linux-stable-commits&a=2008-01&m=6134301 , > > > its been added to the stable tree. I remember asking Greg to add it. > > > > And then Christoph told me to remove it... > > No I asked you to add this patch and remove the earlier patch that > tinkered around with tlb flushing. Argh, I'm too confused... As long as everyone is happy with what is currently queued up for .22-stable and .23-stable, I'll just shut up now and get on releasing them :) thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/